diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2019-03-12 12:09:24 -0700 |
---|---|---|
committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-03-18 07:34:16 +0100 |
commit | 0f745bf9bde4e19dd352f10299d4365a4edaf386 (patch) | |
tree | d315a734ab26965c38c09c85f74ad16ced06dd54 /test/parallel/test-tls-multi-key.js | |
parent | 1ceb6d8e9b516052e21b1dabd1ab19e3c3488e1e (diff) | |
download | node-new-0f745bf9bde4e19dd352f10299d4365a4edaf386.tar.gz |
tls: return correct version from getCipher()
OpenSSL 1.0.0 returned incorrect version information. OpenSSL 1.1.0
fixed this, but returning the correct information broke our tests, so
was considered semver-major. Because of this, the version was hard-coded
to the OpenSSL 1.0.0 (incorrect) string in 5fe81c8aff03261.
This is ancient history, start returning the correct cipher version.
PR-URL: https://github.com/nodejs/node/pull/26625
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'test/parallel/test-tls-multi-key.js')
-rw-r--r-- | test/parallel/test-tls-multi-key.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/parallel/test-tls-multi-key.js b/test/parallel/test-tls-multi-key.js index 8ccc0d32d9..63b0363327 100644 --- a/test/parallel/test-tls-multi-key.js +++ b/test/parallel/test-tls-multi-key.js @@ -157,7 +157,7 @@ function test(options) { }, common.mustCall(function() { assert.deepStrictEqual(ecdsa.getCipher(), { name: 'ECDHE-ECDSA-AES256-GCM-SHA384', - version: 'TLSv1/SSLv3' + version: 'TLSv1.2' }); assert.strictEqual(ecdsa.getPeerCertificate().subject.CN, eccCN); // XXX(sam) certs don't currently include EC key info, so depend on @@ -177,7 +177,7 @@ function test(options) { }, common.mustCall(function() { assert.deepStrictEqual(rsa.getCipher(), { name: 'ECDHE-RSA-AES256-GCM-SHA384', - version: 'TLSv1/SSLv3' + version: 'TLSv1.2' }); assert.strictEqual(rsa.getPeerCertificate().subject.CN, rsaCN); assert(rsa.getPeerCertificate().exponent, 'cert for an RSA key'); |