net: use close callback, not process.nextTick

Don't emit the 'close' event with process.nextTick.

Closing a handle is an operation that usually *but not always* completes
on the next tick of the event loop, hence using process.nextTick is not
reliable.

Use a proper handle close callback and emit the 'close' event from
inside the callback.

Update tests that depend on the intricacies of the old model.

Fixes #3459.

1 files changed, 5 insertions, 1 deletions

diff --git a/test/simple/test-net-server-close.js b/test/simple/test-net-server-close.js
index b87a84d96f..afa83f10d6 100644
--- a/test/simple/test-net-server-close.js
+++ b/test/simple/test-net-server-close.js
@@ -28,7 +28,11 @@ var sockets = [];
 
 process.on('exit', function() {
   assert.equal(server.connections, 0);
-  assert.deepEqual(events, 'client client server'.split(' '));
+  assert.equal(events.length, 3);
+  // Expect to see one server event and two client events. The order of the
+  // events is undefined because they arrive on the same event loop tick.
+  assert.equal(events.join(' ').match(/server/g).length, 1);
+  assert.equal(events.join(' ').match(/client/g).length, 2);
 });
 
 var server = net.createServer(function(c) {