tty: make process.binding('tty_wrap') internal

PR-URL: https://github.com/nodejs/node/pull/22477
Refs: https://github.com/nodejs/node/issues/22160
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

8 files changed, 20 insertions, 8 deletions

diff --git a/test/parallel/test-accessor-properties.js b/test/parallel/test-accessor-properties.js
index 064ef844c3..4cb84e0f12 100644
--- a/test/parallel/test-accessor-properties.js
+++ b/test/parallel/test-accessor-properties.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 require('../common');
@@ -9,7 +10,8 @@ const assert = require('assert');
 
 // Objects that call StreamBase::AddMethods, when setting up
 // their prototype
-const TTY = process.binding('tty_wrap').TTY;
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY;
 const UDP = process.binding('udp_wrap').UDP;
 
 {
diff --git a/test/parallel/test-stream-base-prototype-accessors-enumerability.js b/test/parallel/test-stream-base-prototype-accessors-enumerability.js
index f59aced197..d060a0cb84 100644
--- a/test/parallel/test-stream-base-prototype-accessors-enumerability.js
+++ b/test/parallel/test-stream-base-prototype-accessors-enumerability.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 'use strict';
 
 require('../common');
@@ -9,7 +10,8 @@ require('../common');
 const assert = require('assert');
 
 // Or anything that calls StreamBase::AddMethods when setting up its prototype
-const TTY = process.binding('tty_wrap').TTY;
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY;
 
 {
   assert.strictEqual(TTY.prototype.propertyIsEnumerable('bytesRead'), false);
diff --git a/test/parallel/test-tty-backwards-api.js b/test/parallel/test-tty-backwards-api.js
index 547184728e..7b6dc3c092 100644
--- a/test/parallel/test-tty-backwards-api.js
+++ b/test/parallel/test-tty-backwards-api.js
@@ -1,8 +1,10 @@
+// Flags: --expose-internals
 'use strict';
 const common = require('../common');
 
 const noop = () => {};
-const TTY = process.binding('tty_wrap').TTY = function() {};
+const { internalBinding } = require('internal/test/binding');
+const TTY = internalBinding('tty_wrap').TTY = function() {};
 
 TTY.prototype = {
   setBlocking: noop,
diff --git a/test/pseudo-tty/ref_keeps_node_running.js b/test/pseudo-tty/ref_keeps_node_running.js
index 7832e9ee21..52761c140e 100644
--- a/test/pseudo-tty/ref_keeps_node_running.js
+++ b/test/pseudo-tty/ref_keeps_node_running.js
@@ -1,8 +1,10 @@
+// Flags: --expose-internals --no-warnings
 'use strict';
 
 require('../common');
 
-const { TTY, isTTY } = process.binding('tty_wrap');
+const { internalBinding } = require('internal/test/binding');
+const { TTY, isTTY } = internalBinding('tty_wrap');
 const strictEqual = require('assert').strictEqual;
 
 strictEqual(isTTY(0), true, 'fd 0 is not a TTY');
diff --git a/test/pseudo-tty/test-async-wrap-getasyncid-tty.js b/test/pseudo-tty/test-async-wrap-getasyncid-tty.js
index 030ae9fdff..80ffe9e7cc 100644
--- a/test/pseudo-tty/test-async-wrap-getasyncid-tty.js
+++ b/test/pseudo-tty/test-async-wrap-getasyncid-tty.js
@@ -5,9 +5,9 @@
 
 const common = require('../common');
 const assert = require('assert');
-const tty_wrap = process.binding('tty_wrap');
 const { internalBinding } = require('internal/test/binding');
 const { TTYWRAP } = internalBinding('async_wrap').Providers;
+const tty_wrap = internalBinding('tty_wrap');
 const providers = { TTYWRAP };
 
 // Make sure that the TTYWRAP Provider is tested.
diff --git a/test/pseudo-tty/test-handle-wrap-isrefed-tty.js b/test/pseudo-tty/test-handle-wrap-isrefed-tty.js
index 33b59b3f1a..3654d4a15f 100644
--- a/test/pseudo-tty/test-handle-wrap-isrefed-tty.js
+++ b/test/pseudo-tty/test-handle-wrap-isrefed-tty.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals --no-warnings
 'use strict';
 
 // see also test/parallel/test-handle-wrap-isrefed.js
@@ -6,7 +7,8 @@ const common = require('../common');
 const strictEqual = require('assert').strictEqual;
 const ReadStream = require('tty').ReadStream;
 const tty = new ReadStream(0);
-const isTTY = process.binding('tty_wrap').isTTY;
+const { internalBinding } = require('internal/test/binding');
+const isTTY = internalBinding('tty_wrap').isTTY;
 strictEqual(isTTY(0), true, 'tty_wrap: stdin is not a TTY');
 strictEqual(Object.getPrototypeOf(tty._handle).hasOwnProperty('hasRef'),
             true, 'tty_wrap: hasRef() missing');
diff --git a/test/pseudo-tty/test-tty-window-size.js b/test/pseudo-tty/test-tty-window-size.js
index 782b66802e..2a9891bd19 100644
--- a/test/pseudo-tty/test-tty-window-size.js
+++ b/test/pseudo-tty/test-tty-window-size.js
@@ -1,8 +1,10 @@
+// Flags: --expose-internals --no-warnings
 'use strict';
 const common = require('../common');
 const assert = require('assert');
 const { WriteStream } = require('tty');
-const { TTY } = process.binding('tty_wrap');
+const { internalBinding } = require('internal/test/binding');
+const { TTY } = internalBinding('tty_wrap');
 const getWindowSize = TTY.prototype.getWindowSize;
 
 function monkeyPatchGetWindowSize(fn) {
diff --git a/test/pseudo-tty/test-tty-wrap.js b/test/pseudo-tty/test-tty-wrap.js
index cb961d0403..917f04869a 100644
--- a/test/pseudo-tty/test-tty-wrap.js
+++ b/test/pseudo-tty/test-tty-wrap.js
@@ -3,7 +3,7 @@
 require('../common');
 
 const { internalBinding } = require('internal/test/binding');
-const { TTY } = process.binding('tty_wrap');
+const { TTY } = internalBinding('tty_wrap');
 const { WriteWrap } = internalBinding('stream_wrap');
 
 const handle = new TTY(1);