diff options
author | Robert Mustacchi <rm@joyent.com> | 2011-08-08 13:26:00 -0700 |
---|---|---|
committer | Ryan Dahl <ry@tinyclouds.org> | 2011-08-08 17:01:57 -0700 |
commit | 0df08c6a0c07a3ec0e63cd34886fafbd87dd3c3b (patch) | |
tree | c87f60360d770bf3d57c72a81e8c2c3136b56d5a /test | |
parent | f145e35a93991afb7db98ed76453b5a77b14e2f4 (diff) | |
download | node-new-0df08c6a0c07a3ec0e63cd34886fafbd87dd3c3b.tar.gz |
Endian argument should be a boolean. Signed integers shouldn't run through checks for unsigned integers. Clean up jslint. Provide unchecked uint entry points.
Diffstat (limited to 'test')
-rw-r--r-- | test/simple/test-readdouble.js | 60 | ||||
-rw-r--r-- | test/simple/test-readfloat.js | 36 | ||||
-rw-r--r-- | test/simple/test-readint.js | 72 | ||||
-rw-r--r-- | test/simple/test-readuint.js | 48 | ||||
-rw-r--r-- | test/simple/test-writedouble.js | 20 | ||||
-rw-r--r-- | test/simple/test-writefloat.js | 20 | ||||
-rw-r--r-- | test/simple/test-writeint.js | 36 | ||||
-rw-r--r-- | test/simple/test-writeuint.js | 48 |
8 files changed, 170 insertions, 170 deletions
diff --git a/test/simple/test-readdouble.js b/test/simple/test-readdouble.js index 0a41547bf2..f9a03618f7 100644 --- a/test/simple/test-readdouble.js +++ b/test/simple/test-readdouble.js @@ -16,8 +16,8 @@ function test() { buffer[5] = 0x55; buffer[6] = 0xd5; buffer[7] = 0x3f; - ASSERT.equal(1.1945305291680097e+103, buffer.readDouble(0, 'big')); - ASSERT.equal(0.3333333333333333, buffer.readDouble(0, 'little')); + ASSERT.equal(1.1945305291680097e+103, buffer.readDouble(0, true)); + ASSERT.equal(0.3333333333333333, buffer.readDouble(0, false)); buffer[0] = 1; buffer[1] = 0; @@ -27,18 +27,18 @@ function test() { buffer[5] = 0; buffer[6] = 0xf0; buffer[7] = 0x3f; - ASSERT.equal(7.291122019655968e-304, buffer.readDouble(0, 'big')); - ASSERT.equal(1.0000000000000002, buffer.readDouble(0, 'little')); + ASSERT.equal(7.291122019655968e-304, buffer.readDouble(0, true)); + ASSERT.equal(1.0000000000000002, buffer.readDouble(0, false)); buffer[0] = 2; - ASSERT.equal(4.778309726801735e-299, buffer.readDouble(0, 'big')); - ASSERT.equal(1.0000000000000004, buffer.readDouble(0, 'little')); + ASSERT.equal(4.778309726801735e-299, buffer.readDouble(0, true)); + ASSERT.equal(1.0000000000000004, buffer.readDouble(0, false)); buffer[0] = 1; buffer[6] = 0; buffer[7] = 0; - ASSERT.equal(7.291122019556398e-304, buffer.readDouble(0, 'big')); - ASSERT.equal(5e-324, buffer.readDouble(0, 'little')); + ASSERT.equal(7.291122019556398e-304, buffer.readDouble(0, true)); + ASSERT.equal(5e-324, buffer.readDouble(0, false)); buffer[0] = 0xff; buffer[1] = 0xff; @@ -48,13 +48,13 @@ function test() { buffer[5] = 0xff; buffer[6] = 0x0f; buffer[7] = 0x00; - ASSERT.ok(isNaN(buffer.readDouble(0, 'big'))); - ASSERT.equal(2.225073858507201e-308, buffer.readDouble(0, 'little')); + ASSERT.ok(isNaN(buffer.readDouble(0, true))); + ASSERT.equal(2.225073858507201e-308, buffer.readDouble(0, false)); buffer[6] = 0xef; buffer[7] = 0x7f; - ASSERT.ok(isNaN(buffer.readDouble(0, 'big'))); - ASSERT.equal(1.7976931348623157e+308, buffer.readDouble(0, 'little')); + ASSERT.ok(isNaN(buffer.readDouble(0, true))); + ASSERT.equal(1.7976931348623157e+308, buffer.readDouble(0, false)); buffer[0] = 0; buffer[1] = 0; @@ -64,42 +64,42 @@ function test() { buffer[5] = 0; buffer[6] = 0xf0; buffer[7] = 0x3f; - ASSERT.equal(3.03865e-319, buffer.readDouble(0, 'big')); - ASSERT.equal(1, buffer.readDouble(0, 'little')); + ASSERT.equal(3.03865e-319, buffer.readDouble(0, true)); + ASSERT.equal(1, buffer.readDouble(0, false)); buffer[6] = 0; buffer[7] = 0x40; - ASSERT.equal(3.16e-322, buffer.readDouble(0, 'big')); - ASSERT.equal(2, buffer.readDouble(0, 'little')); + ASSERT.equal(3.16e-322, buffer.readDouble(0, true)); + ASSERT.equal(2, buffer.readDouble(0, false)); buffer[7] = 0xc0; - ASSERT.equal(9.5e-322, buffer.readDouble(0, 'big')); - ASSERT.equal(-2, buffer.readDouble(0, 'little')); + ASSERT.equal(9.5e-322, buffer.readDouble(0, true)); + ASSERT.equal(-2, buffer.readDouble(0, false)); buffer[6] = 0x10; buffer[7] = 0; - ASSERT.equal(2.0237e-320, buffer.readDouble(0, 'big')); - ASSERT.equal(2.2250738585072014e-308, buffer.readDouble(0, 'little')); + ASSERT.equal(2.0237e-320, buffer.readDouble(0, true)); + ASSERT.equal(2.2250738585072014e-308, buffer.readDouble(0, false)); buffer[6] = 0; - ASSERT.equal(0, buffer.readDouble(0, 'big')); - ASSERT.equal(0, buffer.readDouble(0, 'little')); - ASSERT.equal(false, 1/buffer.readDouble(0, 'little')<0); + ASSERT.equal(0, buffer.readDouble(0, true)); + ASSERT.equal(0, buffer.readDouble(0, false)); + ASSERT.equal(false, 1/buffer.readDouble(0, false)<0); buffer[7] = 0x80; - ASSERT.equal(6.3e-322, buffer.readDouble(0, 'big')); - ASSERT.equal(0, buffer.readDouble(0, 'little')); - ASSERT.equal(true, 1/buffer.readDouble(0, 'little')<0); + ASSERT.equal(6.3e-322, buffer.readDouble(0, true)); + ASSERT.equal(0, buffer.readDouble(0, false)); + ASSERT.equal(true, 1/buffer.readDouble(0, false)<0); buffer[6] = 0xf0; buffer[7] = 0x7f; - ASSERT.equal(3.0418e-319, buffer.readDouble(0, 'big')); - ASSERT.equal(Infinity, buffer.readDouble(0, 'little')); + ASSERT.equal(3.0418e-319, buffer.readDouble(0, true)); + ASSERT.equal(Infinity, buffer.readDouble(0, false)); buffer[6] = 0xf0; buffer[7] = 0xff; - ASSERT.equal(3.04814e-319, buffer.readDouble(0, 'big')); - ASSERT.equal(-Infinity, buffer.readDouble(0, 'little')); + ASSERT.equal(3.04814e-319, buffer.readDouble(0, true)); + ASSERT.equal(-Infinity, buffer.readDouble(0, false)); } diff --git a/test/simple/test-readfloat.js b/test/simple/test-readfloat.js index 7127239e05..5385740d80 100644 --- a/test/simple/test-readfloat.js +++ b/test/simple/test-readfloat.js @@ -12,56 +12,56 @@ function test() { buffer[1] = 0; buffer[2] = 0x80; buffer[3] = 0x3f; - ASSERT.equal(4.600602988224807e-41, buffer.readFloat(0, 'big')); - ASSERT.equal(1, buffer.readFloat(0, 'little')); + ASSERT.equal(4.600602988224807e-41, buffer.readFloat(0, true)); + ASSERT.equal(1, buffer.readFloat(0, false)); buffer[0] = 0; buffer[1] = 0; buffer[2] = 0; buffer[3] = 0xc0; - ASSERT.equal(2.6904930515036488e-43, buffer.readFloat(0, 'big')); - ASSERT.equal(-2, buffer.readFloat(0, 'little')); + ASSERT.equal(2.6904930515036488e-43, buffer.readFloat(0, true)); + ASSERT.equal(-2, buffer.readFloat(0, false)); buffer[0] = 0xff; buffer[1] = 0xff; buffer[2] = 0x7f; buffer[3] = 0x7f; - ASSERT.ok(isNaN(buffer.readFloat(0, 'big'))); - ASSERT.equal(3.4028234663852886e+38, buffer.readFloat(0, 'little')); + ASSERT.ok(isNaN(buffer.readFloat(0, true))); + ASSERT.equal(3.4028234663852886e+38, buffer.readFloat(0, false)); buffer[0] = 0xab; buffer[1] = 0xaa; buffer[2] = 0xaa; buffer[3] = 0x3e; - ASSERT.equal(-1.2126478207002966e-12, buffer.readFloat(0, 'big')); - ASSERT.equal(0.3333333432674408, buffer.readFloat(0, 'little')); + ASSERT.equal(-1.2126478207002966e-12, buffer.readFloat(0, true)); + ASSERT.equal(0.3333333432674408, buffer.readFloat(0, false)); buffer[0] = 0; buffer[1] = 0; buffer[2] = 0; buffer[3] = 0; - ASSERT.equal(0, buffer.readFloat(0, 'big')); - ASSERT.equal(0, buffer.readFloat(0, 'little')); - ASSERT.equal(false, 1/buffer.readFloat(0, 'little')<0); + ASSERT.equal(0, buffer.readFloat(0, true)); + ASSERT.equal(0, buffer.readFloat(0, false)); + ASSERT.equal(false, 1/buffer.readFloat(0, false)<0); buffer[3] = 0x80; - ASSERT.equal(1.793662034335766e-43, buffer.readFloat(0, 'big')); - ASSERT.equal(0, buffer.readFloat(0, 'little')); - ASSERT.equal(true, 1/buffer.readFloat(0, 'little')<0); + ASSERT.equal(1.793662034335766e-43, buffer.readFloat(0, true)); + ASSERT.equal(0, buffer.readFloat(0, false)); + ASSERT.equal(true, 1/buffer.readFloat(0, false)<0); buffer[0] = 0; buffer[1] = 0; buffer[2] = 0x80; buffer[3] = 0x7f; - ASSERT.equal(4.609571298396486e-41, buffer.readFloat(0, 'big')); - ASSERT.equal(Infinity, buffer.readFloat(0, 'little')); + ASSERT.equal(4.609571298396486e-41, buffer.readFloat(0, true)); + ASSERT.equal(Infinity, buffer.readFloat(0, false)); buffer[0] = 0; buffer[1] = 0; buffer[2] = 0x80; buffer[3] = 0xff; - ASSERT.equal(4.627507918739843e-41, buffer.readFloat(0, 'big')); - ASSERT.equal(-Infinity, buffer.readFloat(0, 'little')); + ASSERT.equal(4.627507918739843e-41, buffer.readFloat(0, true)); + ASSERT.equal(-Infinity, buffer.readFloat(0, false)); } diff --git a/test/simple/test-readint.js b/test/simple/test-readint.js index d2d4feafd8..5adc797851 100644 --- a/test/simple/test-readint.js +++ b/test/simple/test-readint.js @@ -10,25 +10,25 @@ function test8() { var data = new Buffer(4); data[0] = 0x23; - ASSERT.equal(0x23, data.readInt8(0, 'big')); - ASSERT.equal(0x23, data.readInt8(0, 'little')); + ASSERT.equal(0x23, data.readInt8(0, true)); + ASSERT.equal(0x23, data.readInt8(0, false)); data[0] = 0xff; - ASSERT.equal(-1, data.readInt8(0, 'big')); - ASSERT.equal(-1, data.readInt8(0, 'little')); + ASSERT.equal(-1, data.readInt8(0, true)); + ASSERT.equal(-1, data.readInt8(0, false)); data[0] = 0x87; data[1] = 0xab; data[2] = 0x7c; data[3] = 0xef; - ASSERT.equal(-121, data.readInt8(0, 'big')); - ASSERT.equal(-85, data.readInt8(1, 'big')); - ASSERT.equal(124, data.readInt8(2, 'big')); - ASSERT.equal(-17, data.readInt8(3, 'big')); - ASSERT.equal(-121, data.readInt8(0, 'little')); - ASSERT.equal(-85, data.readInt8(1, 'little')); - ASSERT.equal(124, data.readInt8(2, 'little')); - ASSERT.equal(-17, data.readInt8(3, 'little')); + ASSERT.equal(-121, data.readInt8(0, true)); + ASSERT.equal(-85, data.readInt8(1, true)); + ASSERT.equal(124, data.readInt8(2, true)); + ASSERT.equal(-17, data.readInt8(3, true)); + ASSERT.equal(-121, data.readInt8(0, false)); + ASSERT.equal(-85, data.readInt8(1, false)); + ASSERT.equal(124, data.readInt8(2, false)); + ASSERT.equal(-17, data.readInt8(3, false)); } @@ -36,13 +36,13 @@ function test16() { var buffer = new Buffer(6); buffer[0] = 0x16; buffer[1] = 0x79; - ASSERT.equal(0x1679, buffer.readInt16(0, 'big')); - ASSERT.equal(0x7916, buffer.readInt16(0, 'little')); + ASSERT.equal(0x1679, buffer.readInt16(0, true)); + ASSERT.equal(0x7916, buffer.readInt16(0, false)); buffer[0] = 0xff; buffer[1] = 0x80; - ASSERT.equal(-128, buffer.readInt16(0, 'big')); - ASSERT.equal(-32513, buffer.readInt16(0, 'little')); + ASSERT.equal(-128, buffer.readInt16(0, true)); + ASSERT.equal(-32513, buffer.readInt16(0, false)); /* test offset with weenix */ buffer[0] = 0x77; @@ -51,16 +51,16 @@ function test16() { buffer[3] = 0x6e; buffer[4] = 0x69; buffer[5] = 0x78; - ASSERT.equal(0x7765, buffer.readInt16(0, 'big')); - ASSERT.equal(0x6565, buffer.readInt16(1, 'big')); - ASSERT.equal(0x656e, buffer.readInt16(2, 'big')); - ASSERT.equal(0x6e69, buffer.readInt16(3, 'big')); - ASSERT.equal(0x6978, buffer.readInt16(4, 'big')); - ASSERT.equal(0x6577, buffer.readInt16(0, 'little')); - ASSERT.equal(0x6565, buffer.readInt16(1, 'little')); - ASSERT.equal(0x6e65, buffer.readInt16(2, 'little')); - ASSERT.equal(0x696e, buffer.readInt16(3, 'little')); - ASSERT.equal(0x7869, buffer.readInt16(4, 'little')); + ASSERT.equal(0x7765, buffer.readInt16(0, true)); + ASSERT.equal(0x6565, buffer.readInt16(1, true)); + ASSERT.equal(0x656e, buffer.readInt16(2, true)); + ASSERT.equal(0x6e69, buffer.readInt16(3, true)); + ASSERT.equal(0x6978, buffer.readInt16(4, true)); + ASSERT.equal(0x6577, buffer.readInt16(0, false)); + ASSERT.equal(0x6565, buffer.readInt16(1, false)); + ASSERT.equal(0x6e65, buffer.readInt16(2, false)); + ASSERT.equal(0x696e, buffer.readInt16(3, false)); + ASSERT.equal(0x7869, buffer.readInt16(4, false)); } @@ -70,15 +70,15 @@ function test32() { buffer[1] = 0x53; buffer[2] = 0x16; buffer[3] = 0x79; - ASSERT.equal(0x43531679, buffer.readInt32(0, 'big')); - ASSERT.equal(0x79165343, buffer.readInt32(0, 'little')); + ASSERT.equal(0x43531679, buffer.readInt32(0, true)); + ASSERT.equal(0x79165343, buffer.readInt32(0, false)); buffer[0] = 0xff; buffer[1] = 0xfe; buffer[2] = 0xef; buffer[3] = 0xfa; - ASSERT.equal(-69638, buffer.readInt32(0, 'big')); - ASSERT.equal(-84934913, buffer.readInt32(0, 'little')); + ASSERT.equal(-69638, buffer.readInt32(0, true)); + ASSERT.equal(-84934913, buffer.readInt32(0, false)); buffer[0] = 0x42; buffer[1] = 0xc3; @@ -86,12 +86,12 @@ function test32() { buffer[3] = 0xa9; buffer[4] = 0x36; buffer[5] = 0x17; - ASSERT.equal(0x42c395a9, buffer.readInt32(0, 'big')); - ASSERT.equal(-1013601994, buffer.readInt32(1, 'big')); - ASSERT.equal(-1784072681, buffer.readInt32(2, 'big')); - ASSERT.equal(-1449802942, buffer.readInt32(0, 'little')); - ASSERT.equal(917083587, buffer.readInt32(1, 'little')); - ASSERT.equal(389458325, buffer.readInt32(2, 'little')); + ASSERT.equal(0x42c395a9, buffer.readInt32(0, true)); + ASSERT.equal(-1013601994, buffer.readInt32(1, true)); + ASSERT.equal(-1784072681, buffer.readInt32(2, true)); + ASSERT.equal(-1449802942, buffer.readInt32(0, false)); + ASSERT.equal(917083587, buffer.readInt32(1, false)); + ASSERT.equal(389458325, buffer.readInt32(2, false)); } diff --git a/test/simple/test-readuint.js b/test/simple/test-readuint.js index 98648cc936..4b041111ae 100644 --- a/test/simple/test-readuint.js +++ b/test/simple/test-readuint.js @@ -17,17 +17,17 @@ function test8() { data[1] = 23; data[2] = 23; data[3] = 23; - ASSERT.equal(23, data.readUInt8(0, 'big')); - ASSERT.equal(23, data.readUInt8(0, 'little')); - ASSERT.equal(23, data.readUInt8(1, 'big')); - ASSERT.equal(23, data.readUInt8(1, 'little')); - ASSERT.equal(23, data.readUInt8(2, 'big')); - ASSERT.equal(23, data.readUInt8(2, 'little')); - ASSERT.equal(23, data.readUInt8(3, 'big')); - ASSERT.equal(23, data.readUInt8(3, 'little')); + ASSERT.equal(23, data.readUInt8(0, true)); + ASSERT.equal(23, data.readUInt8(0, false)); + ASSERT.equal(23, data.readUInt8(1, true)); + ASSERT.equal(23, data.readUInt8(1, false)); + ASSERT.equal(23, data.readUInt8(2, true)); + ASSERT.equal(23, data.readUInt8(2, false)); + ASSERT.equal(23, data.readUInt8(3, true)); + ASSERT.equal(23, data.readUInt8(3, false)); data[0] = 255; /* If it became a signed int, would be -1 */ - ASSERT.equal(255, data.readUInt8(0, 'big')); - ASSERT.equal(255, data.readUInt8(0, 'little')); + ASSERT.equal(255, data.readUInt8(0, true)); + ASSERT.equal(255, data.readUInt8(0, false)); } @@ -47,19 +47,19 @@ function test16() { data[2] = 0x42; data[3] = 0x3f; - ASSERT.equal(0x23, data.readUInt16(0, 'big')); - ASSERT.equal(0x2342, data.readUInt16(1, 'big')); - ASSERT.equal(0x423f, data.readUInt16(2, 'big')); + ASSERT.equal(0x23, data.readUInt16(0, true)); + ASSERT.equal(0x2342, data.readUInt16(1, true)); + ASSERT.equal(0x423f, data.readUInt16(2, true)); - ASSERT.equal(0x2300, data.readUInt16(0, 'little')); - ASSERT.equal(0x4223, data.readUInt16(1, 'little')); - ASSERT.equal(0x3f42, data.readUInt16(2, 'little')); + ASSERT.equal(0x2300, data.readUInt16(0, false)); + ASSERT.equal(0x4223, data.readUInt16(1, false)); + ASSERT.equal(0x3f42, data.readUInt16(2, false)); data[0] = 0xfe; data[1] = 0xfe; - ASSERT.equal(0xfefe, data.readUInt16(0, 'big')); - ASSERT.equal(0xfefe, data.readUInt16(0, 'little')); + ASSERT.equal(0xfefe, data.readUInt16(0, true)); + ASSERT.equal(0xfefe, data.readUInt16(0, false)); } @@ -79,13 +79,13 @@ function test32() { data[4] = 0x23; data[5] = 0xff; - ASSERT.equal(0x32654256, data.readUInt32(0, 'big')); - ASSERT.equal(0x65425623, data.readUInt32(1, 'big')); - ASSERT.equal(0x425623ff, data.readUInt32(2, 'big')); + ASSERT.equal(0x32654256, data.readUInt32(0, true)); + ASSERT.equal(0x65425623, data.readUInt32(1, true)); + ASSERT.equal(0x425623ff, data.readUInt32(2, true)); - ASSERT.equal(0x56426532, data.readUInt32(0, 'little')); - ASSERT.equal(0x23564265, data.readUInt32(1, 'little')); - ASSERT.equal(0xff235642, data.readUInt32(2, 'little')); + ASSERT.equal(0x56426532, data.readUInt32(0, false)); + ASSERT.equal(0x23564265, data.readUInt32(1, false)); + ASSERT.equal(0xff235642, data.readUInt32(2, false)); } diff --git a/test/simple/test-writedouble.js b/test/simple/test-writedouble.js index a1bc438b48..a484c90c3a 100644 --- a/test/simple/test-writedouble.js +++ b/test/simple/test-writedouble.js @@ -5,8 +5,8 @@ var ASSERT = require('assert'); function test() { var buffer = new Buffer(16); - buffer.writeDouble(2.225073858507201e-308, 0, 'big'); - buffer.writeDouble(2.225073858507201e-308, 8, 'little'); + buffer.writeDouble(2.225073858507201e-308, 0, true); + buffer.writeDouble(2.225073858507201e-308, 8, false); ASSERT.equal(0x00, buffer[0]); ASSERT.equal(0x0f, buffer[1]); ASSERT.equal(0xff, buffer[2]); @@ -24,8 +24,8 @@ function test() { ASSERT.equal(0x0f, buffer[14]); ASSERT.equal(0x00, buffer[15]); - buffer.writeDouble(1.0000000000000004, 0, 'big'); - buffer.writeDouble(1.0000000000000004, 8, 'little'); + buffer.writeDouble(1.0000000000000004, 0, true); + buffer.writeDouble(1.0000000000000004, 8, false); ASSERT.equal(0x3f, buffer[0]); ASSERT.equal(0xf0, buffer[1]); ASSERT.equal(0x00, buffer[2]); @@ -43,8 +43,8 @@ function test() { ASSERT.equal(0xf0, buffer[14]); ASSERT.equal(0x3f, buffer[15]); - buffer.writeDouble(-2, 0, 'big'); - buffer.writeDouble(-2, 8, 'little'); + buffer.writeDouble(-2, 0, true); + buffer.writeDouble(-2, 8, false); ASSERT.equal(0xc0, buffer[0]); ASSERT.equal(0x00, buffer[1]); ASSERT.equal(0x00, buffer[2]); @@ -62,8 +62,8 @@ function test() { ASSERT.equal(0x00, buffer[14]); ASSERT.equal(0xc0, buffer[15]); - buffer.writeDouble(1.7976931348623157e+308, 0, 'big'); - buffer.writeDouble(1.7976931348623157e+308, 8, 'little'); + buffer.writeDouble(1.7976931348623157e+308, 0, true); + buffer.writeDouble(1.7976931348623157e+308, 8, false); ASSERT.equal(0x7f, buffer[0]); ASSERT.equal(0xef, buffer[1]); ASSERT.equal(0xff, buffer[2]); @@ -81,8 +81,8 @@ function test() { ASSERT.equal(0xef, buffer[14]); ASSERT.equal(0x7f, buffer[15]); - buffer.writeDouble(0*-1, 0, 'big'); - buffer.writeDouble(0*-1, 8, 'little'); + buffer.writeDouble(0*-1, 0, true); + buffer.writeDouble(0*-1, 8, false); ASSERT.equal(0x80, buffer[0]); ASSERT.equal(0x00, buffer[1]); ASSERT.equal(0x00, buffer[2]); diff --git a/test/simple/test-writefloat.js b/test/simple/test-writefloat.js index 85d3d6279d..cbf6e12f5a 100644 --- a/test/simple/test-writefloat.js +++ b/test/simple/test-writefloat.js @@ -5,8 +5,8 @@ var ASSERT = require('assert'); function test() { var buffer = new Buffer(8); - buffer.writeFloat(1, 0, 'big'); - buffer.writeFloat(1, 4, 'little'); + buffer.writeFloat(1, 0, true); + buffer.writeFloat(1, 4, false); ASSERT.equal(0x3f, buffer[0]); ASSERT.equal(0x80, buffer[1]); ASSERT.equal(0x00, buffer[2]); @@ -16,8 +16,8 @@ function test() { ASSERT.equal(0x80, buffer[6]); ASSERT.equal(0x3f, buffer[7]); - buffer.writeFloat(1.793662034335766e-43, 0, 'big'); - buffer.writeFloat(1.793662034335766e-43, 4, 'little'); + buffer.writeFloat(1.793662034335766e-43, 0, true); + buffer.writeFloat(1.793662034335766e-43, 4, false); ASSERT.equal(0x00, buffer[0]); ASSERT.equal(0x00, buffer[1]); ASSERT.equal(0x00, buffer[2]); @@ -27,8 +27,8 @@ function test() { ASSERT.equal(0x00, buffer[6]); ASSERT.equal(0x00, buffer[7]); - buffer.writeFloat(1/3, 0, 'big'); - buffer.writeFloat(1/3, 4, 'little'); + buffer.writeFloat(1/3, 0, true); + buffer.writeFloat(1/3, 4, false); ASSERT.equal(0x3e, buffer[0]); ASSERT.equal(0xaa, buffer[1]); ASSERT.equal(0xaa, buffer[2]); @@ -38,8 +38,8 @@ function test() { ASSERT.equal(0xaa, buffer[6]); ASSERT.equal(0x3e, buffer[7]); - buffer.writeFloat(3.4028234663852886e+38, 0, 'big'); - buffer.writeFloat(3.4028234663852886e+38, 4, 'little'); + buffer.writeFloat(3.4028234663852886e+38, 0, true); + buffer.writeFloat(3.4028234663852886e+38, 4, false); ASSERT.equal(0x7f, buffer[0]); ASSERT.equal(0x7f, buffer[1]); ASSERT.equal(0xff, buffer[2]); @@ -49,8 +49,8 @@ function test() { ASSERT.equal(0x7f, buffer[6]); ASSERT.equal(0x7f, buffer[7]); - buffer.writeFloat(0*-1, 0, 'big'); - buffer.writeFloat(0*-1, 4, 'little'); + buffer.writeFloat(0*-1, 0, true); + buffer.writeFloat(0*-1, 4, false); ASSERT.equal(0x80, buffer[0]); ASSERT.equal(0x00, buffer[1]); ASSERT.equal(0x00, buffer[2]); diff --git a/test/simple/test-writeint.js b/test/simple/test-writeint.js index 8752111031..6186831c86 100644 --- a/test/simple/test-writeint.js +++ b/test/simple/test-writeint.js @@ -5,10 +5,10 @@ var ASSERT = require('assert'); function test8() { var buffer = new Buffer(4); - buffer.writeInt8(0x23, 0, 'big'); - buffer.writeInt8(0x23, 1, 'little'); - buffer.writeInt8(-5, 2, 'big'); - buffer.writeInt8(-5, 3, 'little'); + buffer.writeInt8(0x23, 0, true); + buffer.writeInt8(0x23, 1, false); + buffer.writeInt8(-5, 2, true); + buffer.writeInt8(-5, 3, false); ASSERT.equal(0x23, buffer[0]); ASSERT.equal(0x23, buffer[1]); @@ -17,31 +17,31 @@ function test8() { /* Make sure we handle truncation correctly */ ASSERT.throws(function() { - buffer.writeInt8(0xabc, 0, 'big'); + buffer.writeInt8(0xabc, 0, true); }); ASSERT.throws(function() { - buffer.writeInt8(0xabc, 0, 'little'); + buffer.writeInt8(0xabc, 0, false); }); } function test16() { var buffer = new Buffer(6); - buffer.writeInt16(0x0023, 0, 'big'); - buffer.writeInt16(0x0023, 2, 'little'); + buffer.writeInt16(0x0023, 0, true); + buffer.writeInt16(0x0023, 2, false); ASSERT.equal(0x00, buffer[0]); ASSERT.equal(0x23, buffer[1]); ASSERT.equal(0x23, buffer[2]); ASSERT.equal(0x00, buffer[3]); - buffer.writeInt16(-5, 0, 'big'); - buffer.writeInt16(-5, 2, 'little'); + buffer.writeInt16(-5, 0, true); + buffer.writeInt16(-5, 2, false); ASSERT.equal(0xff, buffer[0]); ASSERT.equal(0xfb, buffer[1]); ASSERT.equal(0xfb, buffer[2]); ASSERT.equal(0xff, buffer[3]); - buffer.writeInt16(-1679, 1, 'big'); - buffer.writeInt16(-1679, 3, 'little'); + buffer.writeInt16(-1679, 1, true); + buffer.writeInt16(-1679, 3, false); ASSERT.equal(0xf9, buffer[1]); ASSERT.equal(0x71, buffer[2]); ASSERT.equal(0x71, buffer[3]); @@ -51,8 +51,8 @@ function test16() { function test32() { var buffer = new Buffer(8); - buffer.writeInt32(0x23, 0, 'big'); - buffer.writeInt32(0x23, 4, 'little'); + buffer.writeInt32(0x23, 0, true); + buffer.writeInt32(0x23, 4, false); ASSERT.equal(0x00, buffer[0]); ASSERT.equal(0x00, buffer[1]); ASSERT.equal(0x00, buffer[2]); @@ -62,8 +62,8 @@ function test32() { ASSERT.equal(0x00, buffer[6]); ASSERT.equal(0x00, buffer[7]); - buffer.writeInt32(-5, 0, 'big'); - buffer.writeInt32(-5, 4, 'little'); + buffer.writeInt32(-5, 0, true); + buffer.writeInt32(-5, 4, false); ASSERT.equal(0xff, buffer[0]); ASSERT.equal(0xff, buffer[1]); ASSERT.equal(0xff, buffer[2]); @@ -73,8 +73,8 @@ function test32() { ASSERT.equal(0xff, buffer[6]); ASSERT.equal(0xff, buffer[7]); - buffer.writeInt32(-805306713, 0, 'big'); - buffer.writeInt32(-805306713, 4, 'little'); + buffer.writeInt32(-805306713, 0, true); + buffer.writeInt32(-805306713, 4, false); ASSERT.equal(0xcf, buffer[0]); ASSERT.equal(0xff, buffer[1]); ASSERT.equal(0xfe, buffer[2]); diff --git a/test/simple/test-writeuint.js b/test/simple/test-writeuint.js index 7306fe931d..45f72ce405 100644 --- a/test/simple/test-writeuint.js +++ b/test/simple/test-writeuint.js @@ -12,25 +12,25 @@ var ASSERT = require('assert'); */ function test8() { var data = new Buffer(4); - data.writeUInt8(23, 0, 'big'); - data.writeUInt8(23, 1, 'big'); - data.writeUInt8(23, 2, 'big'); - data.writeUInt8(23, 3, 'big'); + data.writeUInt8(23, 0, true); + data.writeUInt8(23, 1, true); + data.writeUInt8(23, 2, true); + data.writeUInt8(23, 3, true); ASSERT.equal(23, data[0]); ASSERT.equal(23, data[1]); ASSERT.equal(23, data[2]); ASSERT.equal(23, data[3]); - data.writeUInt8(23, 0, 'little'); - data.writeUInt8(23, 1, 'little'); - data.writeUInt8(23, 2, 'little'); - data.writeUInt8(23, 3, 'little'); + data.writeUInt8(23, 0, false); + data.writeUInt8(23, 1, false); + data.writeUInt8(23, 2, false); + data.writeUInt8(23, 3, false); ASSERT.equal(23, data[0]); ASSERT.equal(23, data[1]); ASSERT.equal(23, data[2]); ASSERT.equal(23, data[3]); - data.writeUInt8(255, 0, 'big'); + data.writeUInt8(255, 0, true); ASSERT.equal(255, data[0]); - data.writeUInt8(255, 0, 'little'); + data.writeUInt8(255, 0, false); ASSERT.equal(255, data[0]); } @@ -38,34 +38,34 @@ function test8() { function test16() { var value = 0x2343; var data = new Buffer(4); - data.writeUInt16(value, 0, 'big'); + data.writeUInt16(value, 0, true); ASSERT.equal(0x23, data[0]); ASSERT.equal(0x43, data[1]); - data.writeUInt16(value, 1, 'big'); + data.writeUInt16(value, 1, true); ASSERT.equal(0x23, data[1]); ASSERT.equal(0x43, data[2]); - data.writeUInt16(value, 2, 'big'); + data.writeUInt16(value, 2, true); ASSERT.equal(0x23, data[2]); ASSERT.equal(0x43, data[3]); - data.writeUInt16(value, 0, 'little'); + data.writeUInt16(value, 0, false); ASSERT.equal(0x23, data[1]); ASSERT.equal(0x43, data[0]); - data.writeUInt16(value, 1, 'little'); + data.writeUInt16(value, 1, false); ASSERT.equal(0x23, data[2]); ASSERT.equal(0x43, data[1]); - data.writeUInt16(value, 2, 'little'); + data.writeUInt16(value, 2, false); ASSERT.equal(0x23, data[3]); ASSERT.equal(0x43, data[2]); value = 0xff80; - data.writeUInt16(value, 0, 'little'); + data.writeUInt16(value, 0, false); ASSERT.equal(0xff, data[1]); ASSERT.equal(0x80, data[0]); - data.writeUInt16(value, 0, 'big'); + data.writeUInt16(value, 0, true); ASSERT.equal(0xff, data[0]); ASSERT.equal(0x80, data[1]); } @@ -75,37 +75,37 @@ function test32() { var data = new Buffer(6); var value = 0xe7f90a6d; - data.writeUInt32(value, 0, 'big'); + data.writeUInt32(value, 0, true); ASSERT.equal(0xe7, data[0]); ASSERT.equal(0xf9, data[1]); ASSERT.equal(0x0a, data[2]); ASSERT.equal(0x6d, data[3]); - data.writeUInt32(value, 1, 'big'); + data.writeUInt32(value, 1, true); ASSERT.equal(0xe7, data[1]); ASSERT.equal(0xf9, data[2]); ASSERT.equal(0x0a, data[3]); ASSERT.equal(0x6d, data[4]); - data.writeUInt32(value, 2, 'big'); + data.writeUInt32(value, 2, true); ASSERT.equal(0xe7, data[2]); ASSERT.equal(0xf9, data[3]); ASSERT.equal(0x0a, data[4]); ASSERT.equal(0x6d, data[5]); - data.writeUInt32(value, 0, 'little'); + data.writeUInt32(value, 0, false); ASSERT.equal(0xe7, data[3]); ASSERT.equal(0xf9, data[2]); ASSERT.equal(0x0a, data[1]); ASSERT.equal(0x6d, data[0]); - data.writeUInt32(value, 1, 'little'); + data.writeUInt32(value, 1, false); ASSERT.equal(0xe7, data[4]); ASSERT.equal(0xf9, data[3]); ASSERT.equal(0x0a, data[2]); ASSERT.equal(0x6d, data[1]); - data.writeUInt32(value, 2, 'little'); + data.writeUInt32(value, 2, false); ASSERT.equal(0xe7, data[5]); ASSERT.equal(0xf9, data[4]); ASSERT.equal(0x0a, data[3]); |