diff options
author | Fedor Indutny <fedor.indutny@gmail.com> | 2013-11-29 20:09:59 +0400 |
---|---|---|
committer | Timothy J Fontaine <tjfontaine@gmail.com> | 2013-12-02 15:18:04 -0800 |
commit | 60f777d343c5aea9021f008c4fb07541ccba4ad4 (patch) | |
tree | 7ad316a50df9c12ef682337f9d5ea207c4760aed /test | |
parent | bd7fa92de421048b0eb8fb810eb66829424fc07f (diff) | |
download | node-new-60f777d343c5aea9021f008c4fb07541ccba4ad4.tar.gz |
tls: fix pool usage race
When calling `encOut` in loop, `maybeInitFinished()` may invoke
`clearOut`'s loop, leading to the writing of interleaved data
(encrypted and cleartext) into the one shared pool.
Move `maybeInitFinished()` out of the loop and add assertion for
future.
Diffstat (limited to 'test')
-rw-r--r-- | test/simple/test-tls-interleave.js | 69 |
1 files changed, 69 insertions, 0 deletions
diff --git a/test/simple/test-tls-interleave.js b/test/simple/test-tls-interleave.js new file mode 100644 index 0000000000..8bebb807e5 --- /dev/null +++ b/test/simple/test-tls-interleave.js @@ -0,0 +1,69 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var common = require('../common'); +var assert = require('assert'); + +var tls = require('tls'); +var fs = require('fs'); + +var PORT = common.PORT; +var dir = common.fixturesDir; +var options = { key: fs.readFileSync(dir + '/test_key.pem'), + cert: fs.readFileSync(dir + '/test_cert.pem'), + ca: [ fs.readFileSync(dir + '/test_ca.pem') ] }; + +var writes = [ + 'some server data', + 'and a separate packet', + 'and one more', +]; +var receivedWrites = 0; + +var server = tls.createServer(options, function(c) { + writes.forEach(function(str) { + c.write(str); + }); +}).listen(PORT, function() { + var c = tls.connect(PORT, { rejectUnauthorized: false }, function() { + c.write('some client data'); + c.on('readable', function() { + var data = c.read(); + if (data === null) + return; + + data = data.toString(); + while (data.length !== 0) { + assert.strictEqual(data.indexOf(writes[receivedWrites]), 0); + data = data.slice(writes[receivedWrites].length); + + if (++receivedWrites === writes.length) { + c.end(); + server.close(); + } + } + }); + }); +}); + +process.on('exit', function() { + assert.equal(receivedWrites, writes.length); +}); |