diff options
author | Rich Trott <rtrott@gmail.com> | 2021-04-24 21:34:48 -0700 |
---|---|---|
committer | Michaël Zasso <targos@protonmail.com> | 2021-04-29 13:45:37 +0200 |
commit | 231ef4b0ce805a862cb9d932e227c3c9fcbdd42e (patch) | |
tree | 45217e25693cc37d6a849836441baf56f2b3c8f3 /test | |
parent | 45322dfa12b90f6fa787b0df81bf664d9f24df02 (diff) | |
download | node-new-231ef4b0ce805a862cb9d932e227c3c9fcbdd42e.tar.gz |
test: move slower tests into pummel and skip on slow devices
Move slower tests to pummel and skip on Raspberry Pi devices in CI.
Refs: https://github.com/nodejs/node/pull/34289#issuecomment-823655915
PR-URL: https://github.com/nodejs/node/pull/38395
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Diffstat (limited to 'test')
-rw-r--r-- | test/pummel/test-fs-watch-system-limit.js | 12 | ||||
-rw-r--r-- | test/pummel/test-heapsnapshot-near-heap-limit-bounded.js (renamed from test/parallel/test-heapsnapshot-near-heap-limit-bounded.js) | 8 | ||||
-rw-r--r-- | test/pummel/test-heapsnapshot-near-heap-limit.js (renamed from test/parallel/test-heapsnapshot-near-heap-limit.js) | 6 | ||||
-rw-r--r-- | test/pummel/test-net-bytes-per-incoming-chunk-overhead.js (renamed from test/sequential/test-net-bytes-per-incoming-chunk-overhead.js) | 9 | ||||
-rw-r--r-- | test/pummel/test-webcrypto-derivebits-pbkdf2.js (renamed from test/parallel/test-webcrypto-derivebits-pbkdf2.js) | 8 |
5 files changed, 38 insertions, 5 deletions
diff --git a/test/pummel/test-fs-watch-system-limit.js b/test/pummel/test-fs-watch-system-limit.js index ce390dd3d0..6662986a1a 100644 --- a/test/pummel/test-fs-watch-system-limit.js +++ b/test/pummel/test-fs-watch-system-limit.js @@ -5,10 +5,18 @@ const child_process = require('child_process'); const fs = require('fs'); const stream = require('stream'); -if (!common.isLinux) +if (!common.isLinux) { common.skip('The fs watch limit is OS-dependent'); -if (!common.enoughTestCpu) +} + +if (!common.enoughTestCpu) { common.skip('This test is resource-intensive'); +} + +if ((process.config.variables.arm_version === '6') || + (process.config.variables.arm_version === '7')) { + common.skip('Too slow for armv6 and armv7 bots'); +} try { // Ensure inotify limit is low enough for the test to actually exercise the diff --git a/test/parallel/test-heapsnapshot-near-heap-limit-bounded.js b/test/pummel/test-heapsnapshot-near-heap-limit-bounded.js index a57b9a8fc4..0ad6a898d1 100644 --- a/test/parallel/test-heapsnapshot-near-heap-limit-bounded.js +++ b/test/pummel/test-heapsnapshot-near-heap-limit-bounded.js @@ -1,6 +1,12 @@ 'use strict'; -require('../common'); +const common = require('../common'); + +if ((process.config.variables.arm_version === '6') || + (process.config.variables.arm_version === '7')) { + common.skip('Too slow for armv6 and armv7 bots'); +} + const tmpdir = require('../common/tmpdir'); const assert = require('assert'); const { spawnSync } = require('child_process'); diff --git a/test/parallel/test-heapsnapshot-near-heap-limit.js b/test/pummel/test-heapsnapshot-near-heap-limit.js index 5743f71a3f..6651f2ae9f 100644 --- a/test/parallel/test-heapsnapshot-near-heap-limit.js +++ b/test/pummel/test-heapsnapshot-near-heap-limit.js @@ -1,6 +1,12 @@ 'use strict'; const common = require('../common'); + +if ((process.config.variables.arm_version === '6') || + (process.config.variables.arm_version === '7')) { + common.skip('Too slow for armv6 and armv7 bots'); +} + const tmpdir = require('../common/tmpdir'); const assert = require('assert'); const { spawnSync } = require('child_process'); diff --git a/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js b/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js index 7bcdfaa9f6..fed903c263 100644 --- a/test/sequential/test-net-bytes-per-incoming-chunk-overhead.js +++ b/test/pummel/test-net-bytes-per-incoming-chunk-overhead.js @@ -2,8 +2,15 @@ 'use strict'; const common = require('../common'); -if (process.config.variables.asan) + +if (process.config.variables.asan) { common.skip('ASAN messes with memory measurements'); +} + +if ((process.config.variables.arm_version === '6') || + (process.config.variables.arm_version === '7')) { + common.skip('Too slow for armv6 and armv7 bots'); +} const assert = require('assert'); const net = require('net'); diff --git a/test/parallel/test-webcrypto-derivebits-pbkdf2.js b/test/pummel/test-webcrypto-derivebits-pbkdf2.js index ed8279dae1..745071f345 100644 --- a/test/parallel/test-webcrypto-derivebits-pbkdf2.js +++ b/test/pummel/test-webcrypto-derivebits-pbkdf2.js @@ -2,8 +2,14 @@ const common = require('../common'); -if (!common.hasCrypto) +if (!common.hasCrypto) { common.skip('missing crypto'); +} + +if ((process.config.variables.arm_version === '6') || + (process.config.variables.arm_version === '7')) { + common.skip('Too slow for armv6 and armv7 bots'); +} const assert = require('assert'); const { subtle } = require('crypto').webcrypto; |