test: make common.js mandatory via linting rule

test/common.js contains code that detects global variable leaks.

This eslint rule checks that a module named `common` is loaded. It is
only applicable to files in the test directory. Tests that intentionally
leak variables can opt out with an eslint-disable comment.

PR-URL: https://github.com/nodejs/node/pull/3157
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

5 files changed, 6 insertions, 2 deletions

diff --git a/test/.eslintrc b/test/.eslintrc
index 2a8f61cb35..5d77a660f8 100644
--- a/test/.eslintrc
+++ b/test/.eslintrc
@@ -5,6 +5,8 @@ rules:
   no-undef: 0
   ## allow global Buffer usage
   require-buffer: 0
+  ## common module is mandatory in tests
+  required-modules: [2, "common"]
 
 globals:
   gc: false
diff --git a/test/common.js b/test/common.js
index 3ed7ce31d8..c1c488c4ea 100644
--- a/test/common.js
+++ b/test/common.js
@@ -1,3 +1,4 @@
+/* eslint-disable required-modules */
 'use strict';
 var path = require('path');
 var fs = require('fs');
diff --git a/test/parallel/test-domain-crypto.js b/test/parallel/test-domain-crypto.js
index 00de1aee27..e76e8d0879 100644
--- a/test/parallel/test-domain-crypto.js
+++ b/test/parallel/test-domain-crypto.js
@@ -1,4 +1,4 @@
-/* eslint-disable strict */
+/* eslint-disable strict, required-modules */
 try {
   var crypto = require('crypto');
 } catch (e) {
diff --git a/test/parallel/test-regression-object-prototype.js b/test/parallel/test-regression-object-prototype.js
index 040e718948..b1411bf813 100644
--- a/test/parallel/test-regression-object-prototype.js
+++ b/test/parallel/test-regression-object-prototype.js
@@ -1,5 +1,5 @@
+/* eslint-disable required-modules */
 'use strict';
-//console.log('puts before');
 
 Object.prototype.xadsadsdasasdxx = function() {
 };
diff --git a/test/parallel/test-repl-autolibs.js b/test/parallel/test-repl-autolibs.js
index 4103a19243..e37f2d036e 100644
--- a/test/parallel/test-repl-autolibs.js
+++ b/test/parallel/test-repl-autolibs.js
@@ -1,3 +1,4 @@
+/* eslint-disable required-modules */
 'use strict';
 var assert = require('assert');
 var util = require('util');