summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorTrevor Norris <trev.norris@gmail.com>2014-08-26 12:21:39 -0700
committerTrevor Norris <trev.norris@gmail.com>2014-12-05 04:52:42 -0800
commit5962dbef49ae6dccc98004b6b955c34336ccbbf5 (patch)
tree4f436c861bf0bead15d8bd623d63446803db8446 /test
parentb1e9d330aa603e40430724f1c834d15fd66a55f2 (diff)
downloadnode-new-5962dbef49ae6dccc98004b6b955c34336ccbbf5.tar.gz
src: all wrap's now use actual FunctionTemplate
Instead of simply creating a new v8::Object to contain the connection information, instantiate a new instance of a FunctionTemplate. This will allow future improvements for debugging and performance probes. Additionally, the "provider" argument in the ReqWrap constructor is no longer optional. PR-URL: https://github.com/joyent/node/pull/8110 Signed-off-by: Trevor Norris <trev.norris@gmail.com> Reviewed-by: Fedor Indutny <fedor@indutny.com> Reviewed-by: Alexis Campailla <alexis@janeasystems.com> Reviewed-by: Julien Gilli <julien.gilli@joyent.com>
Diffstat (limited to 'test')
-rw-r--r--test/internet/test-dns.js5
-rw-r--r--test/simple/test-tcp-wrap-connect.js6
-rw-r--r--test/simple/test-tcp-wrap-listen.js4
3 files changed, 10 insertions, 5 deletions
diff --git a/test/internet/test-dns.js b/test/internet/test-dns.js
index 60227df7ca..623a845c03 100644
--- a/test/internet/test-dns.js
+++ b/test/internet/test-dns.js
@@ -632,8 +632,9 @@ var getaddrinfoCallbackCalled = false;
console.log('looking up nodejs.org...');
-var req = {};
-var err = process.binding('cares_wrap').getaddrinfo(req, 'nodejs.org', 4);
+var cares = process.binding('cares_wrap');
+var req = new cares.GetAddrInfoReqWrap();
+var err = cares.getaddrinfo(req, 'nodejs.org', 4);
req.oncomplete = function(err, domains) {
assert.strictEqual(err, 0);
diff --git a/test/simple/test-tcp-wrap-connect.js b/test/simple/test-tcp-wrap-connect.js
index 43fb37ac70..9e915d243b 100644
--- a/test/simple/test-tcp-wrap-connect.js
+++ b/test/simple/test-tcp-wrap-connect.js
@@ -22,11 +22,13 @@
var common = require('../common');
var assert = require('assert');
var TCP = process.binding('tcp_wrap').TCP;
+var TCPConnectWrap = process.binding('tcp_wrap').TCPConnectWrap;
+var ShutdownWrap = process.binding('stream_wrap').ShutdownWrap;
function makeConnection() {
var client = new TCP();
- var req = {};
+ var req = new TCPConnectWrap();
var err = client.connect(req, '127.0.0.1', common.PORT);
assert.equal(err, 0);
@@ -36,7 +38,7 @@ function makeConnection() {
assert.equal(req, req_);
console.log('connected');
- var shutdownReq = {};
+ var shutdownReq = new ShutdownWrap();
var err = client.shutdown(shutdownReq);
assert.equal(err, 0);
diff --git a/test/simple/test-tcp-wrap-listen.js b/test/simple/test-tcp-wrap-listen.js
index fb3175a008..5801368ba1 100644
--- a/test/simple/test-tcp-wrap-listen.js
+++ b/test/simple/test-tcp-wrap-listen.js
@@ -23,6 +23,7 @@ var common = require('../common');
var assert = require('assert');
var TCP = process.binding('tcp_wrap').TCP;
+var WriteWrap = process.binding('stream_wrap').WriteWrap;
var server = new TCP();
@@ -55,7 +56,8 @@ server.onconnection = function(err, client) {
assert.equal(0, client.writeQueueSize);
- var req = { async: false };
+ var req = new WriteWrap();
+ req.async = false;
var err = client.writeBuffer(req, buffer);
assert.equal(err, 0);
client.pendingWrites.push(req);