summaryrefslogtreecommitdiff
path: root/tools/v8_gypfiles
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2019-07-28 21:14:57 +0200
committerMichaël Zasso <targos@protonmail.com>2019-08-02 22:24:04 +0200
commit470db47cb416decc738e6b341df1fb584772f0b8 (patch)
tree000d61533af2656e6aa91c5fa670482980e1b38b /tools/v8_gypfiles
parent3d51d3039c2d2d58dc940dbe1d4344d001655551 (diff)
downloadnode-new-470db47cb416decc738e6b341df1fb584772f0b8.tar.gz
build: remove support for s390 (but not s390x)
Upstream V8 removed support for s390 earlier this year and it's known to no longer build. Remove the support from our build scripts. Fixes: https://github.com/nodejs/node/issues/28866 PR-URL: https://github.com/nodejs/node/pull/28883 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'tools/v8_gypfiles')
-rw-r--r--tools/v8_gypfiles/broken/standalone.gypi2
-rw-r--r--tools/v8_gypfiles/toolchain.gypi14
-rw-r--r--tools/v8_gypfiles/v8.gyp6
3 files changed, 11 insertions, 11 deletions
diff --git a/tools/v8_gypfiles/broken/standalone.gypi b/tools/v8_gypfiles/broken/standalone.gypi
index 2a41237a60..f01b5975fc 100644
--- a/tools/v8_gypfiles/broken/standalone.gypi
+++ b/tools/v8_gypfiles/broken/standalone.gypi
@@ -165,7 +165,7 @@
}, {
'gomadir': '<!(/bin/echo -n ${HOME}/goma)',
}],
- ['host_arch!="ppc" and host_arch!="ppc64" and host_arch!="ppc64le" and host_arch!="s390" and host_arch!="s390x"', {
+ ['host_arch!="ppc" and host_arch!="ppc64" and host_arch!="ppc64le" and host_arch!="s390x"', {
'host_clang%': 1,
}, {
'host_clang%': 0,
diff --git a/tools/v8_gypfiles/toolchain.gypi b/tools/v8_gypfiles/toolchain.gypi
index c37c5b0c56..264b3e478e 100644
--- a/tools/v8_gypfiles/toolchain.gypi
+++ b/tools/v8_gypfiles/toolchain.gypi
@@ -140,7 +140,7 @@
'conditions': [
['host_arch=="ia32" or host_arch=="x64" or \
host_arch=="ppc" or host_arch=="ppc64" or \
- host_arch=="s390" or host_arch=="s390x" or \
+ host_arch=="s390x" or \
clang==1', {
'variables': {
'host_cxx_is_biarch%': 1,
@@ -151,7 +151,7 @@
},
}],
['target_arch=="ia32" or target_arch=="x64" or \
- target_arch=="ppc" or target_arch=="ppc64" or target_arch=="s390" or \
+ target_arch=="ppc" or target_arch=="ppc64" or \
target_arch=="s390x" or clang==1', {
'variables': {
'target_cxx_is_biarch%': 1,
@@ -302,7 +302,7 @@
'V8_TARGET_ARCH_ARM64',
],
}],
- ['v8_target_arch=="s390" or v8_target_arch=="s390x"', {
+ ['v8_target_arch=="s390x"', {
'defines': [
'V8_TARGET_ARCH_S390',
],
@@ -320,7 +320,7 @@
'cflags': [ '-march=z196' ],
}],
],
- }], # s390
+ }], # s390x
['v8_target_arch=="ppc" or v8_target_arch=="ppc64"', {
'defines': [
'V8_TARGET_ARCH_PPC',
@@ -1045,13 +1045,13 @@
or OS=="netbsd" or OS=="mac" or OS=="android" or OS=="qnx") and \
(v8_target_arch=="arm" or v8_target_arch=="ia32" or \
v8_target_arch=="mips" or v8_target_arch=="mipsel" or \
- v8_target_arch=="ppc" or v8_target_arch=="s390")', {
+ v8_target_arch=="ppc")', {
'target_conditions': [
['_toolset=="host"', {
'conditions': [
['host_cxx_is_biarch==1', {
'conditions': [
- ['host_arch=="s390" or host_arch=="s390x"', {
+ ['host_arch=="s390x"', {
'cflags': [ '-m31' ],
'ldflags': [ '-m31' ]
},{
@@ -1069,7 +1069,7 @@
'conditions': [
['target_cxx_is_biarch==1', {
'conditions': [
- ['host_arch=="s390" or host_arch=="s390x"', {
+ ['host_arch=="s390x"', {
'cflags': [ '-m31' ],
'ldflags': [ '-m31' ]
},{
diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index f0a6aeb69e..37364adc11 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -653,7 +653,7 @@
'<(V8_ROOT)/src/builtins/ppc/builtins-ppc.cc',
],
}],
- ['v8_target_arch=="s390" or v8_target_arch=="s390x"', {
+ ['v8_target_arch=="s390x"', {
'sources': [
'<(V8_ROOT)/src/builtins/s390/builtins-s390.cc',
],
@@ -2187,7 +2187,7 @@
'<(V8_ROOT)/src/wasm/baseline/ppc/liftoff-assembler-ppc.h',
],
}],
- ['v8_target_arch=="s390" or v8_target_arch=="s390x"', {
+ ['v8_target_arch=="s390x"', {
'sources': [ ### gcmole(arch:s390) ###
'<(V8_ROOT)/src/compiler/backend/s390/code-generator-s390.cc',
'<(V8_ROOT)/src/compiler/backend/s390/instruction-codes-s390.h',
@@ -2298,7 +2298,7 @@
}],
# Platforms that don't have Compare-And-Swap (CAS) support need to link atomic library
# to implement atomic memory access
- ['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390", "s390x"]', {
+ ['v8_current_cpu in ["mips", "mipsel", "mips64", "mips64el", "ppc", "ppc64", "s390x"]', {
'link_settings': {
'libraries': ['-latomic', ],
},