diff options
author | Rich Trott <rtrott@gmail.com> | 2016-10-19 14:27:02 -0700 |
---|---|---|
committer | James M Snell <jasnell@gmail.com> | 2016-10-21 07:37:10 -0700 |
commit | 3dbf900e85ea43f700c7892623740008f849a654 (patch) | |
tree | 8e779c75155c31d98011eab1bbc9169444447dcc /tools | |
parent | 31842856301cd05aa411f465bbe0e18f66e8e20f (diff) | |
download | node-new-3dbf900e85ea43f700c7892623740008f849a654.tar.gz |
tools: replace custom lint rule for getter/setter
Replace custom `no-definegetter-definesetter` lint rule with ESLint's
built-in `no-restricted-properties`.
Refs: https://github.com/nodejs/node/pull/9112#pullrequestreview-4378536
PR-URL: https://github.com/nodejs/node/pull/9194
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaƫl Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/eslint-rules/no-definegetter-definesetter.js | 32 |
1 files changed, 0 insertions, 32 deletions
diff --git a/tools/eslint-rules/no-definegetter-definesetter.js b/tools/eslint-rules/no-definegetter-definesetter.js deleted file mode 100644 index 3de010f47f..0000000000 --- a/tools/eslint-rules/no-definegetter-definesetter.js +++ /dev/null @@ -1,32 +0,0 @@ -/** - * @fileoverview Rule to flag usage of __defineGetter__ and __defineSetter__ - * @author Rich Trott - */ - -'use strict'; - -//------------------------------------------------------------------------------ -// Rule Definition -//------------------------------------------------------------------------------ - -module.exports = { - create: function(context) { - const disallowed = ['__defineGetter__', '__defineSetter__']; - - return { - MemberExpression: function(node) { - var prop; - if (node.property) { - if (node.property.type === 'Identifier' && !node.computed) { - prop = node.property.name; - } else if (node.property.type === 'Literal') { - prop = node.property.value; - } - if (disallowed.includes(prop)) { - context.report(node, `The ${prop} property is deprecated.`); - } - } - } - }; - } -}; |