diff options
author | Steven R. Loomis <srloomis@us.ibm.com> | 2018-04-02 08:09:29 -0700 |
---|---|---|
committer | Steven R. Loomis <srloomis@us.ibm.com> | 2018-04-03 08:00:04 -0700 |
commit | a820f4155b5e9a742fec750b437036dcd98d3271 (patch) | |
tree | 1cf4d36bffa4c48e98974fd8418d862ef5ea23f4 /tools | |
parent | 1a5a19d6d475578eec355a8b3079b4a96fc77489 (diff) | |
download | node-new-a820f4155b5e9a742fec750b437036dcd98d3271.tar.gz |
tools: don’t emit illegal utf-8 from icutrim/iculslocs
- argv[0] was being emitted into a utf-8 stream, but argv[0] may
not be legal utf-8
- fix by not emitting argv[0] (was only for a source comment)
- partially resolves https://github.com/nodejs/node/issues/17077
PR-URL: https://github.com/nodejs/node/pull/19756
Fixes: https://github.com/nodejs/node/issues/17077
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/icu/iculslocs.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/icu/iculslocs.cc b/tools/icu/iculslocs.cc index a6931d3a9a..f096a6a84c 100644 --- a/tools/icu/iculslocs.cc +++ b/tools/icu/iculslocs.cc @@ -271,9 +271,9 @@ int list(const char* toBundle) { if (bf != NULL) { // NOLINT (readability/null_usage) // write the HEADER fprintf(bf, - "// Warning this file is automatically generated\n" - "// Updated by %s based on %s:%s.txt\n", - PROG, + "// NOTE: This file was generated during the build process.\n" + "// Generator: tools/icu/iculslocs.cc\n" + "// Input package-tree/item: %s/%s.res\n", packageName.data(), locale); fprintf(bf, |