diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-06-08 10:23:18 -0700 |
|---|---|---|
| committer | Rod Vagg <rod@vagg.org> | 2018-08-16 11:38:50 +1000 |
| commit | 7a35e18177ba77cc03f61d31d0c2d326c48017a9 (patch) | |
| tree | 3ed22b72c0bdb0763bdbad4d0dd1c5e63ed96e1f /tools | |
| parent | 5362e2fbb37543bd98fed9124f830a5025488362 (diff) | |
| download | node-new-7a35e18177ba77cc03f61d31d0c2d326c48017a9.tar.gz | |
tools,gyp: fix regex for version matching
Tool versions can be 10 and higher. Float patch from node-gyp to
accommodate this fact of life.
PR-URL: https://github.com/nodejs/node/pull/21216
Refs: https://github.com/nodejs/node-gyp/commit/293092c362febffe19f72712467565045e08e8f1
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/gyp/pylib/gyp/xcode_emulation.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/gyp/pylib/gyp/xcode_emulation.py b/tools/gyp/pylib/gyp/xcode_emulation.py index 667c53695a..9082b9da35 100644 --- a/tools/gyp/pylib/gyp/xcode_emulation.py +++ b/tools/gyp/pylib/gyp/xcode_emulation.py @@ -1403,7 +1403,7 @@ def XcodeVersion(): except: version = CLTVersion() if version: - version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0] + version = re.match(r'(\d+\.\d+\.?\d*)', version).groups()[0] else: raise GypError("No Xcode or CLT version detected!") # The CLT has no build information, so we return an empty string. |