diff options
| author | Nikhil Komawar <nik.komawar@gmail.com> | 2017-10-12 16:47:29 -0400 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2017-10-23 17:18:14 -0400 |
| commit | 118724f88e8202df4a33656b21d753ad32e491db (patch) | |
| tree | 6c0cf66c27fa6151daff81556c9a478d64d31746 /tools | |
| parent | dacef99bfc042aa0e58e113e2d1706e57f31836b (diff) | |
| download | node-new-118724f88e8202df4a33656b21d753ad32e491db.tar.gz | |
tools: rename unused variale in more pythonic way
The 'Main' function in tools/test.py file was using a variable named
``all_outcomes`` to store a value not being used. It is a best practice
to name unused variables, often return values of functions/methods (as
in this case) as ``_`` [1]. This just helps keep the code a bit cleaner
and avoid any silly mistakes.
PR-URL: https://github.com/nodejs/node/pull/16171
Refs: [1] https://stackoverflow.com/a/5477153
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/test.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/test.py b/tools/test.py index c2e00ace50..e5b3a550dd 100755 --- a/tools/test.py +++ b/tools/test.py @@ -1661,7 +1661,7 @@ def Main(): } test_list = root.ListTests([], path, context, arch, mode) unclassified_tests += test_list - (cases, unused_rules, all_outcomes) = ( + (cases, unused_rules, _) = ( config.ClassifyTests(test_list, env)) if globally_unused_rules is None: globally_unused_rules = set(unused_rules) |