diff options
| author | Nikolai Vavilov <vvnicholas@gmail.com> | 2017-02-03 20:35:10 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-03 20:35:10 +0200 |
| commit | 7cd6a7ddcb006ff8c36bc2abe0a545167dd56dac (patch) | |
| tree | 5be8158893485b96d0c8406087da08b509e1c4f0 /vcbuild.bat | |
| parent | 907ce8dd6c297661a21a8ef5b638b76352523aa2 (diff) | |
| download | node-new-7cd6a7ddcb006ff8c36bc2abe0a545167dd56dac.tar.gz | |
build: notify about the redundancy of "nosign"
vcbuild doesn't sign by default since
92ed1ab45059e3c822dc661a4917bb5232707315, but there might be people who
haven't noticed the change. This adds a message informing them that
"nosign" is no longer necessary.
PR-URL: https://github.com/nodejs/node/pull/11119
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'vcbuild.bat')
| -rw-r--r-- | vcbuild.bat | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcbuild.bat b/vcbuild.bat index bc578c8f1d..60ad312283 100644 --- a/vcbuild.bat +++ b/vcbuild.bat @@ -51,7 +51,7 @@ if /i "%1"=="x64" set target_arch=x64&goto arg-ok if /i "%1"=="vc2015" set target_env=vc2015&goto arg-ok if /i "%1"=="noprojgen" set noprojgen=1&goto arg-ok if /i "%1"=="nobuild" set nobuild=1&goto arg-ok -if /i "%1"=="nosign" set "sign="&goto arg-ok +if /i "%1"=="nosign" set "sign="&echo Note: vcbuild no longer signs by default. "nosign" is redundant.&goto arg-ok if /i "%1"=="sign" set sign=1&goto arg-ok if /i "%1"=="nosnapshot" set nosnapshot=1&goto arg-ok if /i "%1"=="noetw" set noetw=1&goto arg-ok |