summaryrefslogtreecommitdiff
path: root/deps/v8/src/extensions/externalize-string-extension.cc
diff options
context:
space:
mode:
Diffstat (limited to 'deps/v8/src/extensions/externalize-string-extension.cc')
-rw-r--r--deps/v8/src/extensions/externalize-string-extension.cc37
1 files changed, 13 insertions, 24 deletions
diff --git a/deps/v8/src/extensions/externalize-string-extension.cc b/deps/v8/src/extensions/externalize-string-extension.cc
index 00a946b6ff..b153ebd075 100644
--- a/deps/v8/src/extensions/externalize-string-extension.cc
+++ b/deps/v8/src/extensions/externalize-string-extension.cc
@@ -59,11 +59,9 @@ ExternalizeStringExtension::GetNativeFunctionTemplate(
void ExternalizeStringExtension::Externalize(
const v8::FunctionCallbackInfo<v8::Value>& args) {
if (args.Length() < 1 || !args[0]->IsString()) {
- args.GetIsolate()->ThrowException(
- v8::String::NewFromUtf8(
- args.GetIsolate(),
- "First parameter to externalizeString() must be a string.",
- NewStringType::kNormal).ToLocalChecked());
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal(
+ args.GetIsolate(),
+ "First parameter to externalizeString() must be a string."));
return;
}
bool force_two_byte = false;
@@ -71,22 +69,17 @@ void ExternalizeStringExtension::Externalize(
if (args[1]->IsBoolean()) {
force_two_byte = args[1]->BooleanValue(args.GetIsolate());
} else {
- args.GetIsolate()->ThrowException(
- v8::String::NewFromUtf8(
- args.GetIsolate(),
- "Second parameter to externalizeString() must be a boolean.",
- NewStringType::kNormal).ToLocalChecked());
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal(
+ args.GetIsolate(),
+ "Second parameter to externalizeString() must be a boolean."));
return;
}
}
bool result = false;
Handle<String> string = Utils::OpenHandle(*args[0].As<v8::String>());
if (!string->SupportsExternalization()) {
- args.GetIsolate()->ThrowException(
- v8::String::NewFromUtf8(args.GetIsolate(),
- "string does not support externalization.",
- NewStringType::kNormal)
- .ToLocalChecked());
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal(
+ args.GetIsolate(), "string does not support externalization."));
return;
}
if (string->IsOneByteRepresentation() && !force_two_byte) {
@@ -105,10 +98,8 @@ void ExternalizeStringExtension::Externalize(
if (!result) delete resource;
}
if (!result) {
- args.GetIsolate()->ThrowException(
- v8::String::NewFromUtf8(args.GetIsolate(),
- "externalizeString() failed.",
- NewStringType::kNormal).ToLocalChecked());
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal(
+ args.GetIsolate(), "externalizeString() failed."));
return;
}
}
@@ -117,11 +108,9 @@ void ExternalizeStringExtension::Externalize(
void ExternalizeStringExtension::IsOneByte(
const v8::FunctionCallbackInfo<v8::Value>& args) {
if (args.Length() != 1 || !args[0]->IsString()) {
- args.GetIsolate()->ThrowException(
- v8::String::NewFromUtf8(
- args.GetIsolate(),
- "isOneByteString() requires a single string argument.",
- NewStringType::kNormal).ToLocalChecked());
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8Literal(
+ args.GetIsolate(),
+ "isOneByteString() requires a single string argument."));
return;
}
bool is_one_byte =