summaryrefslogtreecommitdiff
path: root/tools/eslint/lib/rules/no-useless-constructor.js
diff options
context:
space:
mode:
Diffstat (limited to 'tools/eslint/lib/rules/no-useless-constructor.js')
-rw-r--r--tools/eslint/lib/rules/no-useless-constructor.js63
1 files changed, 63 insertions, 0 deletions
diff --git a/tools/eslint/lib/rules/no-useless-constructor.js b/tools/eslint/lib/rules/no-useless-constructor.js
new file mode 100644
index 0000000000..20ca67cbe0
--- /dev/null
+++ b/tools/eslint/lib/rules/no-useless-constructor.js
@@ -0,0 +1,63 @@
+/**
+ * @fileoverview Rule to flag the use of redundant constructors in classes.
+ * @author Alberto Rodríguez
+ * @copyright 2015 Alberto Rodríguez. All rights reserved.
+ * See LICENSE file in root directory for full license.
+ */
+"use strict";
+
+//------------------------------------------------------------------------------
+// Rule Definition
+//------------------------------------------------------------------------------
+
+module.exports = function(context) {
+
+ /**
+ * Checks whether the constructor body is a redundant super call.
+ * @param {Array} body - constructor body content.
+ * @param {Array} ctorParams - The params to check against super call.
+ * @returns {boolean} true if the construtor body is redundant
+ */
+ function isRedundantSuperCall(body, ctorParams) {
+ if (body.length !== 1 ||
+ body[0].type !== "ExpressionStatement" ||
+ body[0].expression.callee.type !== "Super") {
+ return false;
+ }
+
+
+ return body[0].expression.arguments.every(function(arg, index) {
+ return (arg.type === "Identifier" && arg.name === ctorParams[index].name) ||
+ (
+ arg.type === "SpreadElement" &&
+ ctorParams[index].type === "RestElement" &&
+ arg.argument.name === ctorParams[index].argument.name
+ );
+ });
+ }
+
+ /**
+ * Checks whether a node is a redundant construtor
+ * @param {ASTNode} node - node to check
+ * @returns {void}
+ */
+ function checkForConstructor(node) {
+ if (node.kind !== "constructor") {
+ return;
+ }
+
+ var body = node.value.body.body;
+
+ if (!node.parent.parent.superClass && body.length === 0 ||
+ node.parent.parent.superClass && isRedundantSuperCall(body, node.value.params)) {
+ context.report(node, "Useless constructor.");
+ }
+ }
+
+
+ return {
+ "MethodDefinition": checkForConstructor
+ };
+};
+
+module.exports.schema = [];