summaryrefslogtreecommitdiff
path: root/.eslintrc.js
Commit message (Collapse)AuthorAgeFilesLines
* src: add initial shadow realm supportlegendecas2022-05-021-0/+1
| | | | | | | | | Add initial shadow realm support behind an off-by-default flag `--experimental-shadow-realm`. PR-URL: https://github.com/nodejs/node/pull/42869 Refs: https://github.com/nodejs/node/issues/42528 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: enable no-var ESLint rule for libRich Trott2022-04-041-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42573 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* stream: expose web streams globals, remove runtime experimental warningAntoine du Hamel2022-04-041-0/+17
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42225 Fixes: https://github.com/nodejs/node/issues/40950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: enable es2022 env in ESLint configMichaël Zasso2022-02-201-3/+3
| | | | | | | | | | | | | | This adds more globals to the set known by ESLint. PR-URL: https://github.com/nodejs/node/pull/42043 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* lib: add FormData global when fetch is enabledMichaël Zasso2022-02-181-0/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: reduce list of globals in ESLint configRich Trott2022-02-181-25/+3
| | | | | | | | | | | Remove globals already known by ESLint. PR-URL: https://github.com/nodejs/node/pull/41996 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
* crypto: expose Web Crypto API on the global scopeAntoine du Hamel2022-02-141-0/+4
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41938 Refs: https://developer.mozilla.org/en-US/docs/Web/API/crypto_property Refs: https://github.com/nodejs/node/pull/41782 Refs: https://w3c.github.io/webcrypto Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* tools: enable no-empty ESLint ruleRich Trott2022-02-051-1/+0
| | | | | | | | | Refs: https://eslint.org/docs/rules/no-empty PR-URL: https://github.com/nodejs/node/pull/41831 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools,test: enable no-prototype-builtinsRich Trott2022-02-031-1/+0
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41801 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* lib: add fetchMichaël Zasso2022-02-011-0/+4
| | | | | | | | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/19393 PR-URL: https://github.com/nodejs/node/pull/41749 Refs: https://github.com/nodejs/undici/pull/1183 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* tools: enable no-cond-assign-ESLint ruleRich Trott2022-01-221-1/+0
| | | | | | | | | no-cond-assign is one of the few ESLint recommended rules that we have turned off. This change enables the rule. PR-URL: https://github.com/nodejs/node/pull/41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* tools: increase maximum line length to 120 charactersRich Trott2022-01-211-3/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41586 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
* tools: enable ESLint recommended configurationRich Trott2022-01-131-51/+8
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: enable ESLint no-constant-condition ruleRich Trott2022-01-131-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools,lib,test: enable ESLint no-regex-spaces ruleRich Trott2022-01-131-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: enable ESLint require-yield ruleRich Trott2022-01-131-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: enable ESLint no-sparse-arrays ruleRich Trott2022-01-131-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: enable ESLint no-loss-of-precision ruleRich Trott2022-01-131-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41463 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools,benchmark,lib,test: enable no-case-declarations lint ruleRich Trott2022-01-051-0/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41385 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* tools: enable jsdoc/check-param-names lint ruleRich Trott2021-12-281-1/+0
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41311 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* worker: expose BroadcastChannel as a globalJames M Snell2021-12-241-0/+1
| | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/41271 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* buffer: expose Blob as a globalJames M Snell2021-12-241-0/+1
| | | | | | | | | | | | | `Blob` is defined as a global in the spec. We have WPT's for it, and it's graduated experimental. Time to expose it as a global. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/41270 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
* tools: enable prefer-object-has-own lint ruleRich Trott2021-12-211-0/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41245 Refs: https://eslint.org/docs/rules/prefer-object-has-own Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* tools: enable jsdoc/tag-lines ESLint ruleRich Trott2021-12-191-1/+0
| | | | | | | | This rule is part of the JSDoc ESLint plugin's recommneded rule set. It prohibits blank lines between JSDoc tags. PR-URL: https://github.com/nodejs/node/pull/41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: enable jsdoc/require-returns-type ESLint ruleRich Trott2021-12-121-1/+0
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41130 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* tools: enable JSDoc check-alignment lint ruleRich Trott2021-12-091-1/+0
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/41109 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: enable jsdoc/require-returns-check lint ruleRich Trott2021-12-071-1/+0
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41089 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* tools: enable jsdoc/require-param-name lint ruleRich Trott2021-12-041-1/+0
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* tools: use jsdoc recommended rulesRich Trott2021-12-041-1/+17
| | | | | | | | | | | | | | | Enable all recommended JSDoc linting rules and disable the ones we don't (yet?) meet. They can be enabled one by one by removing the lines that turn them off. This requires adding --max-warnings to the ESLint invocations in Makefile and vcbuild.bat because the preset enables the recommended rules as warnings and not errors. PR-URL: https://github.com/nodejs/node/pull/41057 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* tools: install and enable JSDoc linting in ESLintRich Trott2021-12-011-1/+5
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41027 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: add support for import assertions in linterAntoine du Hamel2021-10-171-0/+6
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39924 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* tools: udpate @babel/eslint-parserRich Trott2021-10-111-4/+0
| | | | | | | | | Remove unused plugins and update @babel/eslint-parser PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: remove @babel/plugin-syntax-import-assertionsRich Trott2021-10-111-2/+0
| | | | | | | | | As of ESLint 8.0.0 at least, this plugin is unnecessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: remove @bable/plugin-syntax-class-propertiesRich Trott2021-10-111-2/+0
| | | | | | | | | ESLint 8.0.0 makes the plugin unnecessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: remove @babel/plugin-syntax-top-level-awaitRich Trott2021-10-111-2/+0
| | | | | | | | | | ESLint 8.0.0 introduced support for top level await, so @babel/plugin-syntax-top-level-await is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/40394 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: add support for import assertions in linterAntoine du Hamel2021-09-031-0/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39924 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* lib: add structuredClone() globalEthan Arrowood2021-08-281-0/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39759 Fixes: https://github.com/nodejs/node/issues/39713 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* lib: expose `DOMException` as globalXadillaX2021-08-061-0/+1
| | | | | | | | | | Refs: https://github.com/nodejs/node/issues/39098 PR-URL: https://github.com/nodejs/node/pull/39176 Fixes: https://github.com/nodejs/node/issues/39098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: esm examples /w imports for process, BufferGuy Bedford2021-06-251-0/+8
| | | | | PR-URL: https://github.com/nodejs/node/pull/39043 Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
* tools,doc: forbid CJS globals in ESM code snippetsAntoine du Hamel2021-06-031-0/+23
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38889 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: remove exception for Node.js 8 and earlierRich Trott2021-05-311-4/+1
| | | | | | | | | | | | | | | Remove exception in .eslintrc.js to accommodate versions of Node.js prior to 10.x. 10.x and later all support omitting catch block arguments. PR-URL: https://github.com/nodejs/node/pull/38840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* tools: relax max-len lint rule for template stringsRich Trott2021-04-071-0/+1
| | | | | | | | | | | | Splitting template strings across multiple lines can make them harder to read. PR-URL: https://github.com/nodejs/node/pull/38097 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* perf_hooks: make performance a globalJames M Snell2021-04-011-0/+1
| | | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37970 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
* tools: improve valid-typeof lint ruleRich Trott2021-03-281-1/+1
| | | | | | | | | | | Require that `typeof` comparisons be to string literals. PR-URL: https://github.com/nodejs/node/pull/37924 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* buffer: expose btoa and atob as globalsJames M Snell2021-03-251-0/+2
| | | | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37786 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* lib: implement AbortSignal.abort()James M Snell2021-03-151-0/+1
| | | | | | | | | Refs: https://github.com/whatwg/dom/pull/960 PR-URL: https://github.com/nodejs/node/pull/37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* tools: add support for mjs and cjs JS snippet lintingAntoine du Hamel2021-03-061-8/+13
| | | | | | | | | Refs: https://github.com/nodejs/node/pull/37162 Refs: https://github.com/nodejs/remark-preset-lint-node/pull/176 PR-URL: https://github.com/nodejs/node/pull/37311 Refs: https://github.com/eslint/eslint-plugin-markdown/pull/172 Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: update eslint-plugin-markdown configurationcjihrig2021-03-031-6/+10
| | | | | | | | | | | This commit updates the linting setup to work with eslint-plugin-markdown@2.0.0. This also allows the update-eslint script to continue to function properly without changes. PR-URL: https://github.com/nodejs/node/pull/37549 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: make comma-dangle ESLint rule more stringent …Rich Trott2021-02-191-1/+7
| | | | | | | | | | We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: https://github.com/nodejs/node/pull/37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: refactor fs docs structureJames M Snell2021-02-121-0/+1
| | | | | | | | | | | | | | * Convert examples to esm to help promote that pattern with users * Make Promises APIs more prominent to help promite that pattern * Separate callback/sync apis into distinct sections to make those more consistent with the Promises api * Improve other bits and pieces Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37170 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>