summaryrefslogtreecommitdiff
path: root/.github
Commit message (Collapse)AuthorAgeFilesLines
* tools: include current release in the list of released versionsAntoine du Hamel2022-11-141-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45463 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: do not run CQ on non-fast-tracked PRs open for less than 2 daysMoshe Atlow2022-11-121-2/+12
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45407 Fixes: https://github.com/nodejs/node/issues/45405 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* tools: dynamically determine parallelism on GitHub Actions macOSRich Trott2022-11-101-2/+2
| | | | | | Refs: https://github.com/nodejs/node/pull/45340#discussion_r1014859250 PR-URL: https://github.com/nodejs/node/pull/45350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* test: add a test to ensure the correctness of timezone upgradesDarshan Sen2022-11-101-0/+3
| | | | | | | | | | | Currently, there's no way to know if a timezone upgrade PR is correct without building and testing the change locally. This change provides a solution for that. Tested in https://github.com/RaisinTen/node/pull/4. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/45299 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: add automation for updating acorn dependencyFacundo Tuesca2022-11-101-0/+20
| | | | | | | | | | | Add a Github Action that checks for new versions of the `acorn` and `acorn-walk` dependencies, and creates PRs to update them if newer versions than the ones present in the repo are found. Refs: https://github.com/nodejs/security-wg/issues/828 PR-URL: https://github.com/nodejs/node/pull/45357 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* tools: increase macOS cores to 3 on GitHub CIRich Trott2022-11-061-3/+3
| | | | | | | | | | | In efbec85f30d8d1bf0688dcf11198820b8f275d2c, we reduced the cores to 2 based on GitHub documentation. The documentation now says that there are 3 cores. Refs: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: https://github.com/nodejs/node/pull/45340 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: add automation for updating base64 dependencyFacundo Tuesca2022-11-061-0/+13
| | | | | | | | | | | Add a Github Action that checks for new versions of the `base64` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: https://github.com/nodejs/security-wg/issues/828 PR-URL: https://github.com/nodejs/node/pull/45300 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* meta: remove dont-land-on-v12 auto labelingMoshe Atlow2022-10-301-7/+7
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45233 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: use Python 3.11 in GitHub Actions workflowsLuigi Pinca2022-10-289-9/+9
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45191 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* build: workaround for node-core-utilsJiawen Geng2022-10-281-1/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45199 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* tools: update actions/setup-python to v4Yagiz Nizipli2022-10-279-13/+13
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45178 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: add GitHub token to auto-start-ci workflowRichard Lau2022-10-261-1/+1
| | | | | | | | | | | | Recent changes to node-core-utils attempt to read pull request labels when deciding whether or not to start a V8 CI. This requires a valid GitHub token with appropriate permissions to be set for node-core-utils. Refs: https://github.com/nodejs/node-core-utils/pull/652 PR-URL: https://github.com/nodejs/node/pull/45185 Fixes: https://github.com/nodejs/node/issues/45163 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* tools: fix `create-or-update-pull-request-action` hash on GHAAntoine du Hamel2022-10-256-6/+6
| | | | | | | | Refs: https://github.com/nodejs/node/pull/45022#issuecomment-1290397901 PR-URL: https://github.com/nodejs/node/pull/45166 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* tools: update gr2m/create-or-update-pull-request-actionLuigi Pinca2022-10-196-6/+6
| | | | | | | | | | | Update gr2m/create-or-update-pull-request-action to version 1.9.1. PR-URL: https://github.com/nodejs/node/pull/45022 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: do not use the set-output command in workflowsLuigi Pinca2022-10-194-9/+11
| | | | | | | | | | | | | The `set-output` command is deprecated. Use the `GITHUB_OUTPUT` environment file. Refs: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ PR-URL: https://github.com/nodejs/node/pull/45024 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add version info to timezone update PRDarshan Sen2022-10-181-2/+5
| | | | | | | | | | | Refs: https://github.com/nodejs/node/pull/44950#issuecomment-1275073089 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/45021 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: label test.js and test.md with test_runner labelMoshe Atlow2022-10-021-1/+4
| | | | | PR-URL: https://github.com/nodejs/node/pull/44863 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: update timezone-update.ymlAlex2022-09-271-0/+7
| | | | | | | | | | Signed-off-by: sashashura <93376818+sashashura@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/44717 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: add timezone update workflowLenvin Gonsalves2022-09-161-0/+48
| | | | | Fixes: https://github.com/nodejs/node/issues/43134 PR-URL: https://github.com/nodejs/node/pull/43988 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
* meta: update test_runner in label-pr-configShrujal Shah2022-09-151-0/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/44615 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* src: remove v8abbr.hTobias Nießen2022-08-301-1/+1
| | | | | | | | | | | | | The definitions in v8abbr.h, except for NODE_OFF_EXTSTR_DATA, were only used for dtrace, which has been removed. Refs: https://github.com/nodejs/node/pull/43652 PR-URL: https://github.com/nodejs/node/pull/44402 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* meta: update `web streams` in label-pr-configDaeyeon Jeong2022-08-171-0/+2
| | | | | | | Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44235 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* src: disambiguate terms used to refer to builtins and addonsJoyee Cheung2022-08-091-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The term "native module" dates back to some of the oldest code in the code base. Within the context of Node.js core it usually refers to modules that are native to Node.js (e.g. fs, http), but it can cause confusion for people who don't work on this part of the code base, as "native module" can also refer to native addons - which is even the case in some of the API docs and error messages. This patch tries to make the usage of these terms more consistent. Now within the context of Node.js core: - JavaScript scripts that are built-in to Node.js are now referred to as "built-in(s)". If they are available as modules, they can also be referred to as "built-in module(s)". - Dynamically-linked shared objects that are loaded into the Node.js processes are referred to as "addons". We will try to avoid using the term "native modules" because it could be ambiguous. Changes in this patch: File names: - node_native_module.h -> node_builtins.h, - node_native_module.cc -> node_builtins.cc C++ binding names: - `native_module` -> `builtins` `node::Environment`: - `native_modules_without_cache` -> `builtins_without_cache` - `native_modules_with_cache` -> `builtins_with_cache` - `native_modules_in_snapshot` -> `builtins_in_cache` - `native_module_require` -> `builtin_module_require` `node::EnvSerializeInfo`: - `native_modules` -> `builtins `node::native_module::NativeModuleLoader`: - `native_module` namespace -> `builtins` namespace - `NativeModuleLoader` -> `BuiltinLoader` - `NativeModuleRecordMap` -> `BuiltinSourceMap` - `NativeModuleCacheMap` -> `BuiltinCodeCacheMap` - `ModuleIds` -> `BuiltinIds` - `ModuleCategories` -> `BuiltinCategories` - `LoadBuiltinModuleSource` -> `LoadBuiltinSource` `loader.js`: - `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in `process.moduleLoadList` is kept for compatibility) And other clarifications in the documentation and comments. PR-URL: https://github.com/nodejs/node/pull/44135 Fixes: https://github.com/nodejs/node/issues/44036 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jan Krems <jan.krems@gmail.com>
* build: add workflow to label flaky-test platformRafael Gonzaga2022-08-071-0/+50
| | | | | | | | | | This workflow adds platform labels on `flaky-test` issues to make it easier and more reliable for someone to use labels to (for example) find all flaky tests on SmartOS or all flaky tests on FreeBSD. PR-URL: https://github.com/nodejs/node/pull/44042 Fixes: https://github.com/nodejs/node/issues/43854 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rich Trott <rtrott@gmail.com>
* meta: add codeowner for src/node_snapshot*Chengzhong Wu2022-08-031-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/44113 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build: allow test-internet on forks if not scheduledRich Trott2022-08-021-1/+1
| | | | | | | | Refs: https://github.com/nodejs/node/pull/44054#issuecomment-1200246681 PR-URL: https://github.com/nodejs/node/pull/44073 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com>
* build: skip test-internet run on forksRich Trott2022-07-311-0/+1
| | | | | | | | | Do not run test-internet scheduled GitHub Action on forks. PR-URL: https://github.com/nodejs/node/pull/44054 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* meta: shorten PowerShell snippet for bug-report templateNicoNekoru2022-07-301-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44011 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Feng Yu <F3n67u@outlook.com>
* tools: add more options to track flaky testsAntoine du Hamel2022-07-259-14/+14
| | | | | | | | Refs: https://github.com/nodejs/node/pull/43929#issuecomment-1193104729 PR-URL: https://github.com/nodejs/node/pull/43954 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Feng Yu <F3n67u@outlook.com>
* meta: update `node-api` in label-pr-configDaeyeon Jeong2022-07-241-2/+3
| | | | | | | Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/43794 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com>
* meta: use platform dropdown on flaky templateRafael Gonzaga2022-07-181-2/+15
| | | | | PR-URL: https://github.com/nodejs/node/pull/43855 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* meta: enable blank issuesMatteo Collina2022-07-141-1/+1
| | | | | | | | | | | | | | | | | Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/43775 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build: add GitHub token permissions for workflowsVarun Sharma2022-07-1224-0/+93
| | | | | | | Signed-off-by: Varun Sharma <varunsh@stepsecurity.io> PR-URL: https://github.com/nodejs/node/pull/43743 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: update main branch name in GH workflowFeng Yu2022-06-2311-12/+5
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43481 Refs: https://github.com/nodejs/node/issues/33864 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
* tools: fix `create-or-update-pull-request-action` hash on GHAAntoine du Hamel2022-06-113-3/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/43378 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
* tools: fix find-inactive actionsLivia Medeiros2022-06-112-2/+2
| | | | | PR-URL: https://github.com/nodejs/node/pull/43377 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: use hashes instead of tags for external actions (#43284)Antoine du Hamel2022-06-057-7/+17
| | | | | | | | | | Using tags is a security risk, as they can be updated to point to anything else. Refs: https://github.com/nodejs/corepack/pull/117#discussion_r886913592 PR-URL: https://github.com/nodejs/node/pull/43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: update `codecov/codecov-action` versionAntoine du Hamel2022-06-022-2/+2
| | | | | | | | Refs: https://github.com/codecov/codecov-action/releases PR-URL: https://github.com/nodejs/node/pull/43297 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* tools: refactor build-addons.js to ESMFeng Yu2022-05-221-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/43099 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: refactor update-authors.js to ESMFeng Yu2022-05-211-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* bootstrap: include code cache in the embedded snapshotJoyee Cheung2022-05-171-2/+0
| | | | | | | | | | | | | | | Since V8 code cache encodes indices to the read-only space it is safer to make sure that the code cache is generated in the same heap used to generate the embdded snapshot. This patch merges the code cache builder into the snapshot builder and makes the code cache part of node::SnapshotData that is deserialized into the native module loader during bootstrap. PR-URL: https://github.com/nodejs/node/pull/43023 Fixes: https://github.com/nodejs/node/issues/31074 Refs: https://github.com/nodejs/node/issues/35711 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* build: set ASAN workaroundRichard Lau2022-05-141-0/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: disable windows-2022 temporarilyJiawen Geng2022-05-142-2/+2
| | | | | | PR-URL: https://github.com/nodejs/node/pull/43093 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: refactor lint-sh.js to esm moduleFeng Yu2022-05-081-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/42942 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* build: fix format-cppDarshan Sen2022-04-201-1/+5
| | | | | | | | | | | | | | | | According to the logs in https://github.com/nodejs/node/pull/42681#issuecomment-1100856089, `make format-cpp` exits with an NZEC. This change intentionally ignores the error code because it is irrelevant. We already check if the formatter produced a diff in the next line. Refs: https://github.com/nodejs/node/pull/42681#issuecomment-1100856089 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42764 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: improve the format-cpp error messageDarshan Sen2022-04-201-1/+1
| | | | | | | | | | | | This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: run clang-format on CIDarshan Sen2022-04-131-0/+34
| | | | | | | | | | | | We already include the tool inside tools/clang-format, so we should start using it on CI. This attempts to run the linter only on the commits present in an opened PR. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42681 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: consolidate JS and md linting GitHub ActionsRich Trott2022-04-041-18/+4
| | | | | | | | | | | | | Linting markdown runs the JavaScript linting job, so consolidate them to conserve time and resources. Run JavaScript separately, but then run markdown linting so it can use the cached results of the JavaScript linting. PR-URL: https://github.com/nodejs/node/pull/42572 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* build: set stale action back to running nightlyMichael Dawson2022-04-031-7/+4
| | | | | | | | | | | | | I manually ran over the last number of weeks so that we did not mark all of the stale isssues all at once. We are not caught up so we can go to running daily. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: update GHA actions versionAntoine du Hamel2022-03-3016-34/+34
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/42498 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
View Lorry Controller Status