summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2021-04-06, Version 10.24.1 'Dubnium' (LTS)v10.24.1v10.24.1-proposalMyles Borins2021-04-063-2/+32
| | | | | | | | | | | | | | This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High) - **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High) - **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High) PR-URL: https://github.com/nodejs/node/pull/38085
* deps: upgrade npm to 6.14.12Ruy Adorno2021-04-04159-248/+268
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* deps: update archs files for OpenSSL-1.1.1kTobias Nießen2021-04-04119-297/+300
| | | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/37940 Refs: https://github.com/nodejs/node/issues/37913 Refs: https://github.com/nodejs/node/pull/37916 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* deps: upgrade openssl sources to 1.1.1kTobias Nießen2021-04-0432-66/+254
| | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1k.tar.gz $ mv openssl-1.1.1k openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/37940 Refs: https://github.com/nodejs/node/issues/37913 Refs: https://github.com/nodejs/node/pull/37916 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* Working on v10.24.1Richard Lau2021-02-231-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/255
* 2021-02-23, Version 10.24.0 'Dubnium' (LTS)v10.24.0Richard Lau2021-02-224-7/+32
| | | | | | | | | | | | | | | This is a security release. Notable changes Vulnerabilities fixed: - **CVE-2021-22883**: HTTP2 'unknownProtocol' cause Denial of Service by resource exhaustion - **CVE-2021-22884**: DNS rebinding in --inspect - **CVE-2021-23840**: OpenSSL - Integer overflow in CipherUpdate PR-URL: https://github.com/nodejs-private/node-private/pull/255
* http2: add unknownProtocol timeoutDaniel Bevenius2021-02-223-5/+85
| | | | | | | | | | | | | | | | | | This commit add a configuration options named unknownProtocolTimeout which can be specified to set a value for the timeout in milliseconds that a server should wait when an unknowProtocol is sent to it. When this happens a timer will be started and the if the socket has not been destroyed during that time the timer callback will destoy it. CVE-ID: CVE-2021-22883 Refs: https://hackerone.com/reports/1043360 PR-URL: https://github.com/nodejs-private/node-private/pull/246 Backport PR-URL: https://github.com/nodejs-private/node-private/pull/248 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* src: drop localhost6 as allowed host for inspectorMatteo Collina2021-02-221-2/+1
| | | | | | | | | | | | CVE-ID: CVE-2021-22884 Refs: https://hackerone.com/bugs?report_id=1069487 PR-URL: https://github.com/nodejs-private/node-private/pull/244 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: update archs files for OpenSSL-1.1.1jDaniel Bevenius2021-02-22185-850/+983
| | | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/37415 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* deps: upgrade openssl sources to 1.1.1jDaniel Bevenius2021-02-2290-322/+832
| | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1j.tar.gz $ mv openssl-1.1.1j openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/37415 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* Working on v10.23.4Richard Lau2021-02-091-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/37241
* 2021-02-09, Version 10.23.3 'Dubnium' (LTS)v10.23.3v10.23.3-proposalRichard Lau2021-02-093-2/+18
| | | | | | | | Notable changes: The update to npm 6.14.11 has been relanded so that npm correctly reports its version. PR-URL: https://github.com/nodejs/node/pull/37241
* deps: upgrade npm to 6.14.11Ruy Adorno2021-02-09159-372/+403
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37173 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Backport-PR-URL: https://github.com/nodejs/node/pull/37278 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com>
* Revert "deps: upgrade npm to 6.14.11"Richard Lau2021-02-09157-237/+216
| | | | | | | | This reverts commit cc6b69557aa463742b52cee4d8f3b4d918ff8c7e. PR-URL: https://github.com/nodejs/node/pull/37278 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com>
* test: add test that verifies crypto stream pipelineEvan Lucas2021-02-081-0/+21
| | | | | | | | | | | This test fails prior to 990feafcb6 being cherry-picked due to stream.pipeline with a crypto.Hash not working properly. That bug also seems to have affected md5. PR-URL: https://github.com/nodejs/node/pull/37009 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
* crypto: fix crash when calling digest after pipingTobias Nießen2021-02-082-7/+18
| | | | | | | | | | | | | | | | | | | When piping data into an SHA3 hash, EVP_DigestFinal_ex is called in hash._flush, bypassing safeguards in the JavaScript layer. Calling hash.digest causes EVP_DigestFinal_ex to be called again, resulting in a segmentation fault in the SHA3 implementation of OpenSSL. A relatively easy solution is to cache the result of calling EVP_DigestFinal_ex until the Hash object is garbage collected. PR-URL: https://github.com/nodejs/node/pull/28251 Fixes: https://github.com/nodejs/node/issues/28245 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Backport-PR-URL: https://github.com/nodejs/node/pull/37009 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
* Working on v10.23.3Richard Lau2021-01-261-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/37022
* 2021-01-26, Version 10.23.2 'Dubnium' (LTS)v10.23.2v10.23.2-proposalRichard Lau2021-01-263-2/+24
| | | | | | | | | | | | Notable changes: Release keys have been synchronized with the main branch. - deps: - upgrade npm to 6.14.11 (Darcy Clarke) https://github.com/nodejs/node/pull/36838 PR-URL: https://github.com/nodejs/node/pull/37022
* doc: update contact information for @BethGriggsBeth Griggs2021-01-223-6/+7
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35451 Reviewed-By: Stewart X Addison <sxa@uk.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: update contact information for richardlauRichard Lau2021-01-223-3/+4
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35450 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Stewart X Addison <sxa@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: update release key for Danielle AdamsDanielle Adams2021-01-191-2/+4
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36793 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: add release key for Danielle AdamsDanielle Adams2021-01-191-0/+3
| | | | | | | | | | | | Add Danielle Adams's release key. PR-URL: https://github.com/nodejs/node/pull/35545 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add release key for Ruy AdornoRuy Adorno2021-01-191-0/+3
| | | | | | | | | | | Add Ruy Adorno and his Release key. Refs: https://github.com/nodejs/Release/pull/597 PR-URL: https://github.com/nodejs/node/pull/34628 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* deps: upgrade npm to 6.14.11Darcy Clarke2021-01-14157-216/+237
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36838 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* doc: add release key for Richard LauRichard Lau2021-01-081-0/+3
| | | | | | | | | | | | | | | | | Add Richard Lau and his Release key. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/34397 Refs: https://github.com/nodejs/Release/issues/585 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* Working on v10.23.2Richard Lau2021-01-041-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/239
* 2021-01-04, Version 10.23.1 'Dubnium' (LTS)v10.23.1Richard Lau2020-12-233-2/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Notable changes: This is a security release. Vulnerabilities fixed: - CVE-2020-8265: use-after-free in TLSWrap (High) Affected Node.js versions are vulnerable to a use-after-free bug in its TLS implementation. When writing to a TLS enabled socket, node::StreamBase::Write calls node::TLSWrap::DoWrite with a freshly allocated WriteWrap object as first argument. If the DoWrite method does not return an error, this object is passed back to the caller as part of a StreamWriteResult structure. This may be exploited to corrupt memory leading to a Denial of Service or potentially other exploits - CVE-2020-8287: HTTP Request Smuggling in nodejs Affected versions of Node.js allow two copies of a header field in a http request. For example, two Transfer-Encoding header fields. In this case Node.js identifies the first header field and ignores the second. This can lead to HTTP Request Smuggling (https://cwe.mitre.org/data/definitions/444.html). - CVE-2020-1971: OpenSSL - EDIPARTYNAME NULL pointer de-reference (High) This is a vulnerability in OpenSSL which may be exploited through Node.js. You can read more about it in https://www.openssl.org/news/secadv/20201208.txt PR-URL: https://github.com/nodejs-private/node-private/pull/239
* http: add test for http transfer encoding smugglingRichard Lau2020-12-231-0/+46
| | | | | | | | Refs: https://github.com/nodejs-private/node-private/pull/228 Refs: https://hackerone.com/bugs?report_id=1002188&subject=nodejs PR-URL: https://github.com/nodejs-private/node-private/pull/235 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
* http: unset `F_CHUNKED` on new `Transfer-Encoding`Fedor Indutny2020-12-232-0/+33
| | | | | | | | | | | | | Duplicate `Transfer-Encoding` header should be a treated as a single, but with original header values concatenated with a comma separator. In the light of this, even if the past `Transfer-Encoding` ended with `chunked`, we should be not let the `F_CHUNKED` to leak into the next header, because mere presence of another header indicates that `chunked` is not the last transfer-encoding token. CVE-ID: CVE-2020-8287 PR-URL: https://github.com/nodejs-private/node-private/pull/235 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
* deps: update http-parser to http-parser@ec8b5ee63fRichard Lau2020-12-237-30/+220
| | | | | PR-URL: https://github.com/nodejs-private/node-private/pull/235 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
* test: add test-tls-use-after-free-regressionDaniel Bevenius2020-12-231-0/+58
| | | | | | | | | | This commit adds the test provided in pull request https://github.com/nodejs-private/node-private/pull/230. PR-URL: https://github.com/nodejs-private/node-private/pull/238 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com>
* src: use unique_ptr for WriteWrapDaniel Bevenius2020-12-2311-26/+28
| | | | | | | | | | | | This commit attempts to avoid a use-after-free error by using unqiue_ptr and passing a reference to it. CVE-ID: CVE-2020-8265 Fixes: https://github.com/nodejs-private/node-private/issues/227 PR-URL: https://github.com/nodejs-private/node-private/pull/238 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: upgrade npm to 6.14.10Ruy Adorno2020-12-23108-816/+820
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36571 Fixes: https://github.com/nodejs/node/issues/36445 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: update archs files for OpenSSL-1.1.1iRichard Lau2020-12-22323-1495/+2934
| | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/36541 Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: upgrade openssl sources to 1.1.1iMyles Borins2020-12-22349-4167/+4253
| | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1i.tar.gz $ mv openssl-1.1.1i openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/36541 Reviewed-By: Michael Dawson <midawson@redhat.com>
* build,win: accept Python 3 if 2 is not availableJoão Reis2020-12-142-21/+67
| | | | | | | | | If there is no Python 2 available, use Python 3. This allows to test running configure with Python 3. PR-URL: https://github.com/nodejs/node/pull/29236 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: find Python in paths with spacesJoão Reis2020-12-141-21/+27
| | | | | | | | | | | When looking for Python in the registry, as specified in PEP514, this was not able to handle installations in a path with spaces, like Program Files. This ensures the whole path is used, fixing the issue. PR-URL: https://github.com/nodejs/node/pull/29236 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: upgrade npm to 6.14.9Myles Borins2020-12-10398-6124/+11634
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36450 Fixes: https://github.com/docs Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* Working on v10.23.1Richard Lau2020-10-271-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/35544
* 2020-10-27, Version 10.23.0 'Dubnium' (LTS)v10.23.0v10.23.0-proposalRichard Lau2020-10-093-4/+34
| | | | | | | | | | | | | | | | | Notable changes: - deps: - upgrade npm to 6.14.8 (Ruy Adorno) https://github.com/nodejs/node/pull/34834 - n-api: - create N-API version 7 (Gabriel Schulhof) https://github.com/nodejs/node/pull/35199 - expose napi_build_version variable (NickNaso) https://github.com/nodejs/node/pull/27835 - tools: - add debug entitlements for macOS 10.15+ (Gabriele Greco) https://github.com/nodejs/node/pull/34378 PR-URL: https://github.com/nodejs/node/pull/35544
* test,v8: skip less and stabilize test-linux-perf.jsRefael Ackermann2020-10-092-39/+61
| | | | | | | | | Co-authored-by: Matheus Marchini <mat@mmarchini.me> PR-URL: https://github.com/nodejs/node/pull/27364 Refs: https://github.com/nodejs/build/issues/1774 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: fix test-linux-perf flakinessMatheus Marchini2020-10-091-1/+1
| | | | | | | | | | | | | The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: https://github.com/nodejs/node/pull/27615 Refs: https://github.com/v8/v8/compare/7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: upgrade npm to 6.14.8Ruy Adorno2020-10-07203-401/+537
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/34834 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* deps: upgrade npm to 6.14.7claudiahdz2020-10-07317-5515/+5226
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/34468 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: add debug entitlements for macOS 10.15+Gabriele Greco2020-10-071-0/+2
| | | | | | | | | | | | | To debug native modules node should be a debuggable process, that will require the **com.apple.security.get-task-allow** entitlement to be added to the codesign procedure. PR-URL: https://github.com/nodejs/node/pull/34378 Fixes: https://github.com/nodejs/node/issues/34340 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* http2: support non-empty DATA frame with END_STREAM flagCarlos Lopez2020-10-073-23/+111
| | | | | | | | | | | | | | Adds support for reading from a stream where the final frame is a non-empty DATA frame with the END_STREAM flag set, instead of hanging waiting for another frame. Fixes: https://github.com/nodejs/node/issues/31309 Refs: https://nghttp2.org/documentation/types.html#c.nghttp2_on_data_chunk_recv_callback PR-URL: https://github.com/nodejs/node/pull/33875 Backport-PR-URL: https://github.com/nodejs/node/pull/34857 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* http2,doc: minor fixesAlba Mendez2020-10-072-3/+4
| | | | | | | | | | | | | | | | | | | | | Some small fixes on HTTP/2 and its documentation: - Add a note that, on server streams, it's not necessary to start data flow. - Set EOF flag if we have marked all data for sending: there's no need to wait until the queue is actually empty (and send a separate, empty DATA). (Note that, even with this change, a separate DATA frame will always be sent, because the streams layer waits until data has been flushed before dispatching EOF) PR-URL: https://github.com/nodejs/node/pull/28044 Backport-PR-URL: https://github.com/nodejs/node/pull/34857 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* n-api: create N-API version 7Gabriel Schulhof2020-10-075-10/+7
| | | | | | | | | | | | | Mark `napi_detach_arraybuffer` and `napi_is_detached_arraybuffer` as stable. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/35199 Backport-PR-URL: https://github.com/nodejs/node/pull/35336 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <mdawson@devrus.com>
* build: expose napi_build_version variableNickNaso2020-10-075-1/+42
| | | | | | | | | | | | | | | | Expose `napi_build_version` to allow `node-gyp` to make it available for building native addons. Fixes: https://github.com/nodejs/node-gyp/issues/1745 Refs: https://github.com/nodejs/abi-stable-node/issues/371 PR-URL: https://github.com/nodejs/node/pull/27835 Backport-PR-URL: https://github.com/nodejs/node/pull/35266 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* src: allows escaping NODE_OPTIONS with backslashesMaël Nison2020-10-074-12/+51
| | | | | | | | | | | | | | | The characters specified within NODE_OPTIONS can now be escaped, which is handy especially in conjunction with `--require` (where the file path might happen to contain spaces that shouldn't cause the option to be split into two). Fixes: https://github.com/nodejs/node/issues/12971 PR-URL: https://github.com/nodejs/node/pull/24065 Backport-PR-URL: https://github.com/nodejs/node/pull/35342 Reviewed-By: Anna Henningsen <anna@addaleax.net> Refs: https://github.com/microsoft/vscode-js-debug/issues/769