summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* lib: fix regular expression to detect `/` and `\`Francesco Trotta2021-12-147-5/+19
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/40325 Backport-PR-URL: https://github.com/nodejs/node/pull/40565 Fixes: https://github.com/nodejs/node/issues/40305 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
* src: fix crash in AfterGetAddrInfoAnna Henningsen2021-12-141-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | Remove invalid usage of `Check()`. This addresses: FATAL ERROR: v8::FromJust Maybe value is Nothing. 1: 0x101311bf5 node::Abort() (.cold.1) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 2: 0x1000ade29 node::Abort() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 3: 0x1000adf8f node::OnFatalError(char const*, char const*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 4: 0x1001f42d0 v8::V8::FromJustIsNothing() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 5: 0x1000268e2 node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*)::$_2::operator()(bool, bool) const [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 6: 0x10002657c node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 7: 0x1009fb388 uv__work_done [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 8: 0x100a00453 uv__async_io [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 9: 0x100a140cc uv__io_poll [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 10: 0x100a009c1 uv_run [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 11: 0x10014aca0 node::worker::Worker::Run() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 12: 0x10014e56f node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node] 13: 0x7fff703d42eb _pthread_body [/usr/lib/system/libsystem_pthread.dylib] 14: 0x7fff703d7249 _pthread_start [/usr/lib/system/libsystem_pthread.dylib] 15: 0x7fff703d340d thread_start [/usr/lib/system/libsystem_pthread.dylib] PR-URL: https://github.com/nodejs/node/pull/39735 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* child_process: retain reference to data with advanced serializationAnna Henningsen2021-12-142-3/+37
| | | | | | | | | | | | | | | | | | Do the same thing we do for other streams, and retain a reference to the Buffer that was sent over IPC while the write request is active, so that it doesn’t get garbage collected while the data is still in flight. (This is a good example of why it’s a bad idea that we’re not re-using the general streams implementation for IPC and instead maintain separate usage of the low-level I/O primitives.) Fixes: https://github.com/nodejs/node/issues/34797 PR-URL: https://github.com/nodejs/node/pull/38728 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* worker: avoid potential deadlock on NearHeapLimitSantiago Gimeno2021-12-143-5/+37
| | | | | | | | | | | | | | | | | | | | | It can happen that the `NearHeapLimit` callback is called while calling the `oninit()` function on `MessagePort` construction causing a deadlock when the `Worker::Exit()` method is called, as the `mutex_` was already held on the `CreateEnvMessagePort()` method. To fix it, just use the `mutex_` to protect the `child_port_data_` variable and avoid holding it when creating the `MessagePort`. Also, return early from `Worker::Run()` if the worker message port could not be created. Fixes: https://github.com/nodejs/node/issues/38208 PR-URL: https://github.com/nodejs/node/pull/38403 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* repl: fix error message printingAnna Henningsen2021-12-142-1/+24
| | | | | | | | | | | | | | | | | | The REPL implementation would strip away the first and last character of a formatted error message if it ended with `]` (but with the obviously missing check for a starting `]`), leading to things like `Uncaught rror: foo[a` being printed for input like `Error: foo[a]`. Refs: https://github.com/nodejs/node/pull/22436 PR-URL: https://github.com/nodejs/node/pull/38209 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* crypto: update root certificatesRichard Lau2021-12-131-538/+347
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - Trustwave Global Certification Authority - Trustwave Global ECC P256 Certification Authority - Trustwave Global ECC P384 Certification Authority - NAVER Global Root Certification Authority - AC RAIZ FNMT-RCM SERVIDORES SEGUROS - GlobalSign Root R46 - GlobalSign Root E46 - GLOBALTRUST 2020 - ANF Secure Server Root CA - Certum EC-384 CA - Certum Trusted Root CA - TunTrust Root CA - HARICA TLS RSA Root CA 2021 - HARICA TLS ECC Root CA 2021 Certificates removed: - GeoTrust Global CA - GeoTrust Universal CA - GeoTrust Universal CA 2 - QuoVadis Root CA - Sonera Class 2 Root CA - Taiwan GRCA - GeoTrust Primary Certification Authority - thawte Primary Root CA - VeriSign Class 3 Public Primary Certification Authority - G5 - OISTE WISeKey Global Root GA CA - GeoTrust Primary Certification Authority - G3 - thawte Primary Root CA - G2 - thawte Primary Root CA - G3 - GeoTrust Primary Certification Authority - G2 - VeriSign Universal Root Certification Authority - VeriSign Class 3 Public Primary Certification Authority - G4 - Chambers of Commerce Root - 2008 - Global Chambersign Root - 2008 - Trustis FPS Root CA - EE Certification Centre Root CA - Staat der Nederlanden Root CA - G3 PR-URL: https://github.com/nodejs/node/pull/40280 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* tools: update certdata.txtRichard Lau2021-12-131-2656/+2754
| | | | | | | | | | | | | | | | This is the certdata.txt[0] from NSS 3.71, released on 2021-09-30. This is the version of NSS that will ship in Firefox 94 on 2021-11-02. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_71_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/40280 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* deps: add -fno-strict-aliasing flag to libuvDaniel Bevenius2021-12-131-0/+1
| | | | | | | | | | | | | | | | This commit turns on `-fno-strict-aliasing` in libuv. Fixes: https://github.com/nodejs/node/issues/40368 Refs: https://github.com/libuv/libuv/issues/1230 PR-URL: https://github.com/nodejs/node/pull/40631 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* build: pin macOS GitHub runner to macos-10.15Richard Lau2021-12-131-2/+2
| | | | | | | | | | | Node.js 12.x requires Python 2 to build. `macos-latest` GitHub hosted runners are now macOS 11 and do not have Python 2 available. PR-URL: https://github.com/nodejs/node/pull/41124 Refs: https://github.com/actions/virtual-environments/issues/4060 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: add alternative version links to the packages pageFilip Skokan2021-12-091-0/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/36915 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* deps: update c-ares to 1.18.1Richard Lau2021-12-09174-919/+98995
| | | | | | | | | Updated as described in doc/guides/maintaining-c-ares.md. PR-URL: https://github.com/nodejs/node/pull/40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* tools: add script to update c-aresRichard Lau2021-12-092-0/+122
| | | | | | | | | | Add a script to automate updating of the c-ares dependency and accompanying maintenance guide. PR-URL: https://github.com/nodejs/node/pull/40660 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* test: deflake child-process-pipe-dataflowLuigi Pinca2021-11-231-6/+6
| | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/40838 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: update to cjs-module-lexer@1.2.2Guy Bedford2021-10-127-9/+14
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39402 Backport-PR-URL: https://github.com/nodejs/node/pull/39422 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Working on v12.22.8Danielle Adams2021-10-121-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/295
* 2021-10-12, Version 12.22.7 'Erbium' (LTS)v12.22.7Danielle Adams2021-10-113-2/+22
| | | | | | | | | | | | | | | | | | | This is a security release. Notable changes: * CVE-2021-22959: HTTP Request Smuggling due to spaced in headers (Medium) * The http parser accepts requests with a space (SP) right after the header name before the colon. This can lead to HTTP Request Smuggling (HRS). More details are available at: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22959 * CVE-2021-22960: HTTP Request Smuggling when parsing the body (Medium) * The parse ignores chunk extensions when parsing the body of chunked requests. This leads to HTTP Request Smuggling (HRS) under certain conditions. More details are available at: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-22960 PR-URL: https://github.com/nodejs-private/node-private/pull/295
* http: add regression test for smuggling content lengthMatteo Collina2021-10-111-0/+31
| | | | | PR-URL: https://github.com/nodejs-private/node-private/pull/286 Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* http: add regression test for chunked smugglingMatteo Collina2021-10-111-0/+43
| | | | | PR-URL: https://github.com/nodejs-private/node-private/pull/286 Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* deps: update llhttp to 2.1.4Fedor Indutny2021-10-113-346/+518
| | | | | | | | | | | | Refs: https://hackerone.com/reports/1238099 Refs: https://hackerone.com/reports/1238709 Refs: https://github.com/nodejs-private/llhttp-private/pull/7 Refs: https://github.com/nodejs-private/llhttp-private/pull/8 CVE-ID: CVE-2021-22959 CVE-ID: CVE-2021-22960 PR-URL: https://github.com/nodejs-private/node-private/pull/286 Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* Working on v12.22.7Myles Borins2021-08-311-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/288
* 2021-08-31, Version 12.22.6 'Erbium' (LTS)v12.22.6Myles Borins2021-08-303-2/+33
| | | | | | | | | | | | | | | | | | | | | | | | This is a security release. Notable changes: These are vulnerabilities in the node-tar, arborist, and npm cli modules which are related to the initial reports and subsequent remediation of node-tar vulnerabilities CVE-2021-32803 (https://github.com/advisories/GHSA-r628-mhmh-qjhw) and CVE-2021-32804 (https://github.com/advisories/GHSA-3jfq-g458-7qm9). Subsequent internal security review of node-tar and additional external bounty reports have resulted in another 5 CVE being remediated in core npm CLI dependencies including node-tar, and npm arborist. You can read more about it in: * CVE-2021-37701: https://github.com/npm/node-tar/security/advisories/GHSA-9r2w-394v-53qc * CVE-2021-37712: https://github.com/npm/node-tar/security/advisories/GHSA-qq89-hq3f-393p * CVE-2021-37713: https://github.com/npm/node-tar/security/advisories/GHSA-5955-9wpr-37jh * CVE-2021-39134: https://github.com/npm/arborist/security/advisories/GHSA-2h3h-q99f-3fhc * CVE-2021-39135: https://github.com/npm/arborist/security/advisories/GHSA-gmw6-94gg-2rc2 PR-URL: https://github.com/nodejs-private/node-private/pull/288
* deps: update archs files for OpenSSL-1.1.1lRichard Lau2021-08-28139-297/+364
| | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/39869 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* deps: upgrade openssl sources to 1.1.1lRichard Lau2021-08-28107-525/+2009
| | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1l.tar.gz $ mv openssl-1.1.1l openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/39869 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* deps: upgrade npm to 6.14.15Darcy Clarke2021-08-28181-648/+2686
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39856 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* Working on v12.22.6Beth Griggs2021-08-111-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/278
* 2021-08-11, Version 12.22.5 'Erbium' (LTS)v12.22.5Beth Griggs2021-08-113-2/+27
| | | | | | | | | | | | | | | This is a security release. Notable Changes: - CVE-2021-3672/CVE-2021-22931: Improper handling of untypical characters in domain names (High) - CVE-2021-22930: Use after free on close http2 on stream canceling (High) - CVE-2021-22939: Incomplete validation of rejectUnauthorized parameter (Low) PR-URL: https://github.com/nodejs-private/node-private/pull/278
* deps: update c-ares to 1.17.2Beth Griggs2021-08-1139-593/+889
| | | | | | | | | | | | Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_17_2 CVE-ID: CVE-2021-3672, CVE-2021-22931 Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-3672 Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22931 PR-URL: https://github.com/nodejs/node/pull/39724 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* deps: reflect c-ares source treeBeth Griggs2021-08-0987-79/+79
| | | | | | | | | | | | | | | c-ares refactored their source tree in 1.17.0 which we did not apply in our update to 1.17.1. This commit syncs our source with their new structure for easier maintenance going forward. cares.gyp is updated accordingly. Refs: https://github.com/c-ares/c-ares/pull/349 Refs: https://github.com/nodejs/node/pull/36207 PR-URL: https://github.com/nodejs/node/pull/39653 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: apply missed updates from c-ares 1.17.1Beth Griggs2021-08-093-62/+69
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39653 Refs: https://github.com/c-ares/c-ares/pull/349 Refs: https://github.com/nodejs/node/pull/36207 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tls: validate "rejectUnauthorized: undefined"Matteo Collina2021-08-092-1/+29
| | | | | | | | | | | | | | | | | | Incomplete validation of rejectUnauthorized parameter (Low) If the Node.js https API was used incorrectly and "undefined" was passed in for the "rejectUnauthorized" parameter, no error was returned and connections to servers with an expired certificate would have been accepted. CVE-ID: CVE-2021-22939 Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22939 Refs: https://hackerone.com/reports/1278254 PR-URL: https://github.com/nodejs-private/node-private/pull/276 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Akshay K <iit.akshay@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* http2: add tests for cancel event while client is paused readingAkshay K2021-08-091-0/+36
| | | | | | | | | Backport-PR-URL: https://github.com/nodejs/node/pull/39659 PR-URL: https://github.com/nodejs/node/pull/39622 Refs: https://github.com/nodejs/node/pull/39423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* http2: update handling of rst_stream with error code NGHTTP2_CANCELAkshay K2021-08-091-9/+10
| | | | | | | | | | | | | | | | | | | | | | | | The PR updates the handling of rst_stream frames and adds all streams to the pending list on receiving rst frames with the error code NGHTTP2_CANCEL. The changes will remove dependency on the stream state that may allow bypassing the checks in certain cases. I think a better solution is to delay streams in all cases if rst_stream is received for the cancel events. The rst_stream frames can be received for protocol/connection error as well it should be handled immediately. Adding streams to the pending list in such cases may cause errors. CVE-ID: CVE-2021-22930 Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22930 Backport-PR-URL: https://github.com/nodejs/node/pull/39659 PR-URL: https://github.com/nodejs/node/pull/39622 Refs: https://github.com/nodejs/node/pull/39423 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* Working on v12.22.5Richard Lau2021-07-291-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/39500
* 2021-07-29, Version 12.22.4 'Erbium' (LTS)v12.22.4Richard Lau2021-07-293-2/+39
| | | | | | | | | | This is a security release. Notable changes: - CVE-2021-22930: Use after free on close http2 on stream canceling (High) PR-URL: https://github.com/nodejs/node/pull/39500
* module: fix legacy `node` specifier resolution to resolve `"main"` fieldAntoine du Hamel2021-07-284-6/+27
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38979 Backport-PR-URL: https://github.com/nodejs/node/pull/39497 Fixes: https://github.com/nodejs/node/issues/32103 Fixes: https://github.com/nodejs/node/issues/38739 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* deps: upgrade npm to 6.14.14Darcy Clarke2021-07-28158-261/+312
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39553 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* http2: on receiving rst_stream with cancel code add it to pending listAkshay K2021-07-272-0/+33
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39423 Backport-PR-URL: https://github.com/nodejs/node/pull/39527 Fixes: https://github.com/nodejs/node/issues/38964 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* deps: update to c-ares 1.17.1Danny Sonnenschein2021-07-2618-54/+386
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/36207 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: restore minimum ICU version to 65Richard Lau2021-07-261-0/+51
| | | | | | | | | | | | | | | | | | | | This modifies 40df0dc so that the changes it applies are only used if ICU 67 or greater is used, and restores the previous code path for versions of ICU below 67. The minimum ICU version was bumped to 67 in Node.js 14.6.0 by https://github.com/nodejs/node/pull/34356 but the referenced V8 commit[1] isn't on `v14.x-staging` and appears to have been reverted on V8 8.4[2] so this PR also restores the minimum ICU version to 65. [1] https://github.com/v8/v8/commit/611e412768a7bc87a20d0315635b0bf76a5bab46 [2] https://github.com/v8/v8/commit/eeccedee1882f1f870b37d12978cd818934b375d PR-URL: https://github.com/nodejs/node/pull/39068 Backport-PR-URL: https://github.com/nodejs/node/pull/39451 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* deps: V8: cherry-pick 035c305ce776Michaël Zasso2021-07-262-38/+19
| | | | | | | | | | | | | | | | | | | | | | Original commit message: [Intl] call new ListFormatter::createInstance The one we currently using is now marked as internal and to be removed for 68. Migrating to the style which already avaiable in ICU 67-1. Bug: v8:11031 Change-Id: I668382a2e1b8602ddca02bf231c5008a6c92bf2d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2477751 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#70638} Refs: https://github.com/v8/v8/commit/035c305ce7761f51328b45f1bd83e26aef267c9d PR-URL: https://github.com/nodejs/node/pull/38497 Backport-PR-URL: https://github.com/nodejs/node/pull/39451 Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* src: move CHECK in AddIsolateFinishedCallbackFedor Indutny2021-07-261-1/+1
| | | | | | | | | | | | `CHECK(it->second)` asserts that we have `PerIsolatePlatformData` in the `per_isolate_` map, and not just a key with empty value. When `it == per_isolate_.end()`, however, it means that we don't have the isolate and the `CHECK(it->second)` is guaranteed to fail then! PR-URL: https://github.com/nodejs/node/pull/38010 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: update cares_wrap OpenBSD definesAnna Henningsen2021-07-261-1/+5
| | | | | | | | | | | | | | | | | Move the `#define`s back into `cares_wrap.cc`, as they are part of the implementation, not the declarations used in `cares_wrap.h`, and apply the suggestion from https://github.com/nodejs/node/pull/38572#discussion_r627809407 to make the defines a bit more generic and not check for OpenBSD specifically. Refs: https://github.com/nodejs/node/pull/38572 PR-URL: https://github.com/nodejs/node/pull/38670 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: update to cjs-module-lexer@1.2.1Guy Bedford2021-07-239-107/+96
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38450 Backport-PR-URL: https://github.com/nodejs/node/pull/39422 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: update to cjs-module-lexer@1.1.1Guy Bedford2021-07-237-16/+36
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/37992 Backport-PR-URL: https://github.com/nodejs/node/pull/38003 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* deps: V8: update build dependenciesMichaël Zasso2021-07-231-8/+8
| | | | | | | | These updates are necessary to build V8 with recent GN versions. PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: backport 895949419186Michaël Zasso2021-07-232-1/+8
| | | | | | | | | | | | | | | | | | | | | Original commit message: Add -Wno-string-concatenation to test/cctest:cctest_sources v8/test/cctest/interpreter/test-bytecode-generator.cc contains lots of string arrays with intentional concatenation. Bug: chromium:1114873 Change-Id: Ie9d35c3849b5b0a6d1d01b6ce21fb80a320d8736 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2366829 Commit-Queue: Arthur Eubanks <aeubanks@google.com> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#69625} Refs: https://github.com/v8/v8/commit/8959494191869ff483927916f9f46eb419784f07 PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 0b3a4ecf7083Michaël Zasso2021-07-232-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: Fix implicit conversion loses integer precision warning The type of m is long in 64 bits build, and results implicit conversion loses integer precision, which was found by improved clang warning (-Wshorten-64-to-32) Bug: chromium:1124085 Change-Id: Ic9f22508bd817a06d5c90162b1ac3554a7171529 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391323 Commit-Queue: Zequan Wu <zequanwu@google.com> Auto-Submit: Zequan Wu <zequanwu@google.com> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#69686} Refs: https://github.com/v8/v8/commit/0b3a4ecf708334ff20dd5a978c3765e75675b40b PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 7c182bd65f42Michaël Zasso2021-07-232-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | Original commit message: Fix visiblity rules for configs enforced by the latest GN version. Prior versions of GN had a bug (gn:22) where visibility rules for configs weren't being enforced properly. This CL tweaks the visibility settings of some configs to conform to the latest version. Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#69463} Refs: https://github.com/v8/v8/commit/7c182bd65f424db19dc3e3d9aca601030af30d7e PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick cc641f6be756Michaël Zasso2021-07-232-1/+9
| | | | | | | | | | | | | | | | | | | Original commit message: Add a simple gclient_args.gni file to V8 Bug: v8:9914 Change-Id: I0bae9aadd89876e8505e1388903c86777694ee09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1890100 Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#64680} Refs: https://github.com/v8/v8/commit/cc641f6be7561c166409a04c75199746f8a43ddd PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: V8: cherry-pick 7b3332844212Michaël Zasso2021-07-233-2/+80
| | | | | | | | | | | | | | | | | | | | | | Original commit message: [build] Move split_static_library.gni from Chromium repo We'll remove the file from Chromium in a follow up after V8 has rolled + 2 days. Bug: v8:9911 Change-Id: I69fe56855f1ba83bec0d39e0fb6acb7e4182c6b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1897826 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64742} Refs: https://github.com/v8/v8/commit/7b3332844212d78ee87a9426f3a6f7f781a8fbfa PR-URL: https://github.com/nodejs/node/pull/39245 Refs: https://github.com/nodejs/build/issues/2696 Reviewed-By: Richard Lau <rlau@redhat.com>
View Lorry Controller Status