summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2021-02-09, Version 14.15.5 'Fermium' (LTS)v14.15.5v14.15.5-proposalBeth Griggs2021-02-083-2/+27
| | | | | | | | | | | | | | | Notable changes: - **deps**: - upgrade npm to 6.14.11 (Ruy Adorno) (https://github.com/nodejs/node/pull/37173) - V8: backport dfcf1e86fac0 (Michaël Zasso) (https://github.com/nodejs/node/pull/37245) - Note: Node.js is not believed to be vulnerable to CVE-2021-21148. - **stream,zlib**: do not use \_stream\_\* anymore (Matteo Collina) (https://github.com/nodejs/node/pull/36618) PR-URL: https://github.com/nodejs/node/pull/37074
* http: do not loop over prototype in AgentMichaël Zasso2021-02-081-1/+1
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/36364 PR-URL: https://github.com/nodejs/node/pull/36410 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* deps: V8: backport dfcf1e86fac0Michaël Zasso2021-02-084-1/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [wasm] PostMessage of Memory.buffer should throw PostMessage of an ArrayBuffer that is not detachable should result in a DataCloneError. Bug: chromium:1170176, chromium:961059 Change-Id: Ib89bbc10d2b58918067fd1a90365cad10a0db9ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2653810 Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#72415} Refs: https://github.com/v8/v8/commit/dfcf1e86fac0a7b067caf8fdfc13eaf3e3f445e4 PR-URL: https://github.com/nodejs/node/pull/37245 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* util: fix instanceof checks with null prototypes during inspectionRuben Bridgewater2021-02-052-1/+20
| | | | | | | | | | | | | | Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: https://github.com/nodejs/node/pull/37100 PR-URL: https://github.com/nodejs/node/pull/36178 Fixes: https://github.com/nodejs/node/issues/35730 Fixes: https://github.com/nodejs/node/issues/36151 Refs: https://github.com/nodejs/node/pull/35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* util: fix module prefixes during inspectionRuben Bridgewater2021-02-044-5/+26
| | | | | | | | | | | | | | Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> Backport-PR-URL: https://github.com/nodejs/node/pull/37100 PR-URL: https://github.com/nodejs/node/pull/36178 Fixes: https://github.com/nodejs/node/issues/35730 Fixes: https://github.com/nodejs/node/issues/36151 Refs: https://github.com/nodejs/node/pull/35754 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: upgrade npm to 6.14.11Ruy Adorno2021-02-04159-372/+403
| | | | | | PR-URL: https://github.com/nodejs/node/pull/37173 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* stream,zlib: do not use _stream_* anymoreMatteo Collina2021-01-283-3/+16
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36618 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* http: don't cork .end when not neededDimitris Halatsis2021-01-281-1/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36633 Backport-PR-URL: https://github.com/nodejs/node/pull/36940 Fixes: https://github.com/nodejs/node/issues/36620 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
* test: http complete response after socket double endDimitris Halatsis2021-01-282-0/+98
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36633 Backport-PR-URL: https://github.com/nodejs/node/pull/36940 Fixes: https://github.com/nodejs/node/issues/36620 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
* stream: accept iterable as a valid first argumentZiJian Liu2021-01-282-1/+20
| | | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/36437 PR-URL: https://github.com/nodejs/node/pull/36479 Backport-PR-URL: https://github.com/nodejs/node/pull/36831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* Working on v14.15.5Beth Griggs2021-01-041-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/242
* 2021-01-04, Version 14.15.4 'Fermium' (LTS)v14.15.4Beth Griggs2020-12-243-2/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a security release. Notable changes: Vulnerabilities fixed: - **CVE-2020-1971**: OpenSSL - EDIPARTYNAME NULL pointer de-reference (High) - This is a vulnerability in OpenSSL which may be exploited through Node.js. You can read more about it in https://www.openssl.org/news/secadv/20201208.txt - **CVE-2020-8265**: use-after-free in TLSWrap (High) - Affected Node.js versions are vulnerable to a use-after-free bug in its TLS implementation. When writing to a TLS enabled socket, node::StreamBase::Write calls node::TLSWrap::DoWrite with a freshly allocated WriteWrap object as first argument. If the DoWrite method does not return an error, this object is passed back to the caller as part of a StreamWriteResult structure. This may be exploited to corrupt memory leading to a Denial of Service or potentially other exploits. - **CVE-2020-8287**: HTTP Request Smuggling in nodejs (Low) - Affected versions of Node.js allow two copies of a header field in a http request. For example, two Transfer-Encoding header fields. In this case Node.js identifies the first header field and ignores the second. This can lead to HTTP Request Smuggling (https://cwe.mitre.org/data/definitions/444.html). PR-URL: https://github.com/nodejs-private/node-private/pull/242
* src: retain pointers to WriteWrap/ShutdownWrapJames M Snell2020-12-244-4/+68
| | | | | | | | | | | | | Avoids potential use-after-free when wrap req's are synchronously destroyed. CVE-ID: CVE-2020-8265 Fixes: https://github.com/nodejs-private/node-private/issues/227 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=988103 PR-URL: https://github.com/nodejs-private/node-private/pull/23 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* http: add test for http transfer encoding smugglingMatteo Collina2020-12-241-0/+44
| | | | | | | | | CVE-ID: CVE-2020-8287 Refs: https://github.com/nodejs-private/llhttp-private/pull/3 Refs: https://hackerone.com/bugs?report_id=1002188&subject=nodejs PR-URL: https://github.com/nodejs-private/node-private/pull/228 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* http: unset `F_CHUNKED` on new `Transfer-Encoding`Matteo Collina2020-12-241-2/+34
| | | | | | | | | | | | | | | | Duplicate `Transfer-Encoding` header should be a treated as a single, but with original header values concatenated with a comma separator. In the light of this, even if the past `Transfer-Encoding` ended with `chunked`, we should be not let the `F_CHUNKED` to leak into the next header, because mere presence of another header indicates that `chunked` is not the last transfer-encoding token. CVE-ID: CVE-2020-8287 Refs: https://github.com/nodejs-private/llhttp-private/pull/3 Refs: https://hackerone.com/bugs?report_id=1002188&subject=nodejs PR-URL: https://github.com/nodejs-private/node-private/pull/228 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: upgrade npm to 6.14.10Ruy Adorno2020-12-23108-816/+820
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36571 Fixes: https://github.com/nodejs/node/issues/36445 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: update archs files for OpenSSL-1.1.1iMyles Borins2020-12-17235-546/+2134
| | | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make gen-openssl $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/36521 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: upgrade openssl sources to 1.1.1iMyles Borins2020-12-17347-4162/+4246
| | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1i.tar.gz $ mv openssl-1.1.1i openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/36521 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* Working on v14.15.4Beth Griggs2020-12-171-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/36555
* 2020-12-17, Version 14.15.3 'Fermium' (LTS)v14.15.3v14.15.3-proposalBeth Griggs2020-12-173-2/+15
| | | | | | | | | | | | Notable Changes: Node.js v14.15.2 included a commit that has caused reported breakages when cloning request objects. This release reverts the commit that introduced the behaviour change. See https://github.com/nodejs/node/issues/36550 for more details. PR-URL: https://github.com/nodejs/node/pull/36555
* Revert "http: lazy create IncomingMessage.headers"Beth Griggs2020-12-171-56/+6
| | | | | | | | | | | | | | This reverts commit b58725c4c014ed24ed89e5452993da486df1601b. Fixes: https://github.com/nodejs/node/issues/36550 PR-URL: https://github.com/nodejs/node/pull/36553 Refs: https://github.com/nodejs/node/pull/35281 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* Working on v14.15.3Beth Griggs2020-12-151-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/36476
* 2020-12-15, Version 14.15.2 'Fermium' (LTS)v14.15.2v14.15.2-proposalBeth Griggs2020-12-153-2/+204
| | | | | | | | | | | | | | | | | | Notable Changes: - **deps**: - upgrade npm to 6.14.9 (Myles Borins) https://github.com/nodejs/node/pull/36450 - update acorn to v8.0.4 (Michaël Zasso) https://github.com/nodejs/node/pull/35791 - **doc**: add release key for Danielle Adams (Danielle Adams) https://github.com/nodejs/node/pull/35545 - **http2**: check write not scheduled in scope destructor (David Halls) https://github.com/nodejs/node/pull/36241 - **stream**: fix regression on duplex end (Momtchil Momtchev) https://github.com/nodejs/node/pull/35941 PR-URL: https://github.com/nodejs/node/pull/36476
* http2: check write not scheduled in scope destructorDavid Halls2020-12-152-1/+48
| | | | | | | | | Fixes: https://github.com/nodejs/node/issues/33156 PR-URL: https://github.com/nodejs/node/pull/36241 Backport-PR-URL: https://github.com/nodejs/node/pull/36372 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: upgrade npm to 6.14.9Myles Borins2020-12-15398-6124/+11634
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36450 Fixes: https://github.com/docs Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: remove stray comma in url.mdRich Trott2020-12-151-1/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36175 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* http: fix typo in commentHollow Man2020-12-151-1/+1
| | | | | | | | | | | | | | alredy -> already PR-URL: https://github.com/nodejs/node/pull/36193 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* doc: revise agent.destroy() textRich Trott2020-12-151-2/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36163 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* test: update comments in test-fs-read-offset-nullRich Trott2020-12-151-5/+4
| | | | | | | | | | Update comment to refer to the correct ASCII code (120 rather than 66). All other changes are cosmetic. PR-URL: https://github.com/nodejs/node/pull/36152 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* n-api: clean up binding creationGabriel Schulhof2020-12-151-183/+80
| | | | | | | | | | | | | | | | | * Remove dead code for `GetterCallbackWrapper` and `SetterCallbackWrapper`. * Factor out creation of new `v8::Function`s. * Factor out creation of new `v8::FunctionTemplate`s. * Turn `CallbackBundle` into a class, internalizing creation of new instances and garbage collection. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/36170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* n-api: fix test_async_context warningsGabriel Schulhof2020-12-151-2/+3
| | | | | | | | | | Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/36171 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
* async_hooks: refactor to use more primordialsAntoine du Hamel2020-12-153-12/+20
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36168 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* doc: add compatibility/interop technical valueGeoffrey Booth2020-12-151-1/+4
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/35323 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* win,build,tools: support VS prereleaseBaruch Odem2020-12-152-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/36033 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: bump unist-util-find@1.0.1 to unist-util-find@1.0.2Rich Trott2020-12-152-440/+8
| | | | | PR-URL: https://github.com/nodejs/node/pull/36106 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: de-emphasize wrapping in napi_define_classGabriel Schulhof2020-12-151-24/+31
| | | | | | | | | | | | | Change the documentation for `napi_define_class` in such a way that it mentions wrapping C++ class instances as a possible use for the API, rather than making the assumption that it is the use case for the API. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by: Rich Trott <rtrott@gmail.com> Fixes: https://github.com/nodejs/node/issues/36150 PR-URL: https://github.com/nodejs/node/pull/36159 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* benchmark: fix build warningsGabriel Schulhof2020-12-152-2/+6
| | | | | | | | | | | | The napi/* benchmarks were using an incorrect signature for the V8 add-on init function. This was causing a warning. Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/36157 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* tools: only use 2 cores for macos actionMyles Borins2020-12-151-2/+2
| | | | | | | | | | | | | There are only 2 cores available so we shouldn't be using -j8 Refs: https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-runners-and-hardware-resources PR-URL: https://github.com/nodejs/node/pull/36169 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me>
* build: replace which with command -vraisinten2020-12-155-12/+12
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/36118 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* fs: remove experimental from promises.rmdir recursiveAnders Kaseorg2020-12-151-2/+0
| | | | | | | | | | | | | | | | This was missed in commit 35b17d9abd123853a8e035ca7bc185f7e942d73b. Refs: https://github.com/nodejs/node/issues/34278 Refs: https://github.com/nodejs/node/pull/35171 Signed-off-by: Anders Kaseorg <andersk@mit.edu> PR-URL: https://github.com/nodejs/node/pull/36131 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: refactor using-declarations node_env_var.ccraisinten2020-12-151-7/+10
| | | | | | PR-URL: https://github.com/nodejs/node/pull/36128 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: remove bashisms from license builder scriptAntoine du Hamel2020-12-151-36/+36
| | | | | | PR-URL: https://github.com/nodejs/node/pull/36122 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* doc,url: fix url.hostname exampleRishabh Mehan2020-12-151-0/+6
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33735 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* fs: filehandle read now accepts object as argumentNikola Glavina2020-12-152-10/+34
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/34180 Fixes: https://github.com/nodejs/node/issues/34176 Refs: https://nodejs.org/api/fs.html#fs_filehandle_read_options Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* build: try “python3” as a last resort for 3.xOle André Vadla Ravnås2020-12-151-0/+1
| | | | | | | | | | | So that Xcode's Python 3 gets picked up. PR-URL: https://github.com/nodejs/node/pull/35983 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: fix typo in inspector-helper.jsLuigi Pinca2020-12-151-1/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/36127 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: deflake test-http-destroyed-socket-write2Luigi Pinca2020-12-151-10/+11
| | | | | | | | | | | Ensure that the write occurs in the same tick where the socket is destroyed by the other peer. PR-URL: https://github.com/nodejs/node/pull/36120 Fixes: https://github.com/nodejs/node/issues/36081 Fixes: https://github.com/nodejs/node/issues/4066 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* doc: clarify text about process not respondingRich Trott2020-12-151-4/+2
| | | | | | | | | | | | | The existing text about processes not responding is unclear, at least to me. Suggestions for clarification welcome, but I think the best thing might be to state that the process may stop responding and leave it at that. The explanantion (about asynchronous listeners) is not clear to me. (Why would the fact that the listeners are asynchronous matter?) If it's an unnecessary detail (as seems likely), let's remove it. PR-URL: https://github.com/nodejs/node/pull/36117 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* n-api: improve consistency of how we get contextMichael Dawson2020-12-151-3/+2
| | | | | | | | | | | | | | | | Refs: https://github.com/nodejs/node-addon-api/issues/764 Improve the consistency of how we get a context when needed. We generally used env->context() in N-API but there were are few exceptions that this PR addresses. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/36068 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* test: make test-http2-client-jsstream-destroy.js reliableRich Trott2020-12-151-4/+7
| | | | | | | | | | Use events instead of setTimeout() calls. Fixes: https://github.com/nodejs/node/issues/36078 PR-URL: https://github.com/nodejs/node/pull/36129 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
View Lorry Controller Status