summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* deps: update llhttp to 2.1.4Fedor Indutny2021-10-113-346/+518
| | | | | | | | | | | | Refs: https://hackerone.com/reports/1238099 Refs: https://hackerone.com/reports/1238709 Refs: https://github.com/nodejs-private/llhttp-private/pull/7 Refs: https://github.com/nodejs-private/llhttp-private/pull/8 CVE-ID: CVE-2021-22959 CVE-ID: CVE-2021-22960 PR-URL: https://github.com/nodejs-private/node-private/pull/285 Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* Working on v14.18.1Michaël Zasso2021-09-281-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/39990
* 2021-09-28, Version 14.18.0 'Fermium' (LTS)v14.18.0v14.18.0-proposalMichaël Zasso2021-09-0728-86/+579
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Notable changes: assert: * change status of legacy asserts (James M Snell) https://github.com/nodejs/node/pull/38113 buffer: * (SEMVER-MINOR) introduce Blob (James M Snell) https://github.com/nodejs/node/pull/36811 * (SEMVER-MINOR) add base64url encoding option (Filip Skokan) https://github.com/nodejs/node/pull/36952 child_process: * (SEMVER-MINOR) allow `options.cwd` receive a URL (Khaidi Chu) https://github.com/nodejs/node/pull/38862 * (SEMVER-MINOR) add timeout to spawn and fork (Nitzan Uziely) https://github.com/nodejs/node/pull/37256 * (SEMVER-MINOR) allow promisified exec to be cancel (Carlos Fuentes) https://github.com/nodejs/node/pull/34249 * (SEMVER-MINOR) add 'overlapped' stdio flag (Thiago Padilha) https://github.com/nodejs/node/pull/29412 cli: * (SEMVER-MINOR) add -C alias for --conditions flag (Guy Bedford) https://github.com/nodejs/node/pull/38755 * (SEMVER-MINOR) add --node-memory-debug option (Anna Henningsen) https://github.com/nodejs/node/pull/35537 dns: * (SEMVER-MINOR) add "tries" option to Resolve options (Luan Devecchi) https://github.com/nodejs/node/pull/39610 * (SEMVER-MINOR) allow `--dns-result-order` to change default dns verbatim (Ouyang Yadong) https://github.com/nodejs/node/pull/38099 doc: * (SEMVER-MINOR) add missing change to resolver ctor (Luan Devecchi) https://github.com/nodejs/node/pull/39610 * refactor fs docs structure (James M Snell) https://github.com/nodejs/node/pull/37170 errors: * (SEMVER-MINOR) remove experimental from --enable-source-maps (Benjamin Coe) https://github.com/nodejs/node/pull/37362 esm: * deprecate legacy main lookup for modules (Guy Bedford) https://github.com/nodejs/node/pull/36918 fs: * (SEMVER-MINOR) allow empty string for temp directory prefix (Voltrex) https://github.com/nodejs/node/pull/39028 * (SEMVER-MINOR) allow no-params fsPromises fileHandle read (Nitzan Uziely) https://github.com/nodejs/node/pull/38287 * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) https://github.com/nodejs/node/pull/37490 * improve fsPromises readFile performance (Nitzan Uziely) https://github.com/nodejs/node/pull/37608 * (SEMVER-MINOR) add fsPromises.watch() (James M Snell) https://github.com/nodejs/node/pull/37179 * (SEMVER-MINOR) allow `position` parameter to be a `BigInt` in read and readSync (Darshan Sen) https://github.com/nodejs/node/pull/36190 http2: * (SEMVER-MINOR) add support for sensitive headers (Anna Henningsen) https://github.com/nodejs/node/pull/34145 * (SEMVER-MINOR) allow setting the local window size of a session (Yongsheng Zhang) https://github.com/nodejs/node/pull/35978 inspector: * mark as stable (Gireesh Punathil) https://github.com/nodejs/node/pull/37748 module: * (SEMVER-MINOR) add support for `URL` to `import.meta.resolve` (Antoine du Hamel) https://github.com/nodejs/node/pull/38587 * (SEMVER-MINOR) add support for `node:`‑prefixed `require(…)` calls (ExE Boss) https://github.com/nodejs/node/pull/37246 net: * (SEMVER-MINOR) introduce net.BlockList (James M Snell) https://github.com/nodejs/node/pull/34625 node-api: * (SEMVER-MINOR) allow retrieval of add-on file name (Gabriel Schulhof) https://github.com/nodejs/node/pull/37195 os: * (SEMVER-MINOR) add os.devNull (Luigi Pinca) https://github.com/nodejs/node/pull/38569 perf_hooks: * (SEMVER-MINOR) introduce createHistogram (James M Snell) https://github.com/nodejs/node/pull/37155 process: * (SEMVER-MINOR) add api to enable source-maps programmatically (legendecas) https://github.com/nodejs/node/pull/39085 * (SEMVER-MINOR) add `'worker'` event (James M Snell) https://github.com/nodejs/node/pull/38659 * (SEMVER-MINOR) add direct access to rss without iterating pages (Adrien Maret) https://github.com/nodejs/node/pull/34291 readline: * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) https://github.com/nodejs/node/pull/37932 * (SEMVER-MINOR) add support for the AbortController to the question method (Mattias Runge-Broberg) https://github.com/nodejs/node/pull/33676 * (SEMVER-MINOR) add history event and option to set initial history (Mattias Runge-Broberg) https://github.com/nodejs/node/pull/33662 repl: * (SEMVER-MINOR) add auto‑completion for `node:`‑prefixed `require(…)` calls (ExE Boss) https://github.com/nodejs/node/pull/37246 src: * (SEMVER-MINOR) call overload ctor from the original ctor (Darshan Sen) https://github.com/nodejs/node/pull/39768 * (SEMVER-MINOR) add a constructor overload for CallbackScope (Darshan Sen) https://github.com/nodejs/node/pull/39768 * (SEMVER-MINOR) allow to negate boolean CLI flags (Michaël Zasso) https://github.com/nodejs/node/pull/39023 * (SEMVER-MINOR) add --heapsnapshot-near-heap-limit option (Joyee Cheung) https://github.com/nodejs/node/pull/33010 * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) https://github.com/nodejs/node/pull/36441 * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) https://github.com/nodejs/node/pull/36447 * (SEMVER-MINOR) add maybe versions of EmitExit and EmitBeforeExit (Anna Henningsen) https://github.com/nodejs/node/pull/35486 stream: * (SEMVER-MINOR) add readableDidRead if has been read from (Robert Nagy) https://github.com/nodejs/node/pull/39589 * (SEMVER-MINOR) pipeline accept Buffer as a valid first argument (Nitzan Uziely) https://github.com/nodejs/node/pull/37739 tls: * (SEMVER-MINOR) allow reading data into a static buffer (Andrey Pechkurov) https://github.com/nodejs/node/pull/35753 tools: * (SEMVER-MINOR) add `Worker` to type-parser (James M Snell) https://github.com/nodejs/node/pull/38659 url: * (SEMVER-MINOR) expose urlToHttpOptions utility (Yongsheng Zhang) https://github.com/nodejs/node/pull/35960 util: * (SEMVER-MINOR) expose toUSVString (Robert Nagy) https://github.com/nodejs/node/pull/39814 v8: * (SEMVER-MINOR) implement v8.stopCoverage() (Joyee Cheung) https://github.com/nodejs/node/pull/33807 * (SEMVER-MINOR) implement v8.takeCoverage() (Joyee Cheung) https://github.com/nodejs/node/pull/33807 worker: * (SEMVER-MINOR) add setEnvironmentData/getEnvironmentData (James M Snell) https://github.com/nodejs/node/pull/37486 PR-URL: https://github.com/nodejs/node/pull/39990
* fs: improve fsPromises writeFile performanceNitzan Uziely2021-09-073-9/+15
| | | | | | | | | | | | | Increase the write chunk size in fsPromises writeFile to improve performance. PR-URL: https://github.com/nodejs/node/pull/37610 Backport-PR-URL: https://github.com/nodejs/node/pull/39993 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: fix test-vm-memleak for high baseline platformsRich Trott2021-09-071-2/+4
| | | | | | | | | | | | | test-vm-memleak always fails on AIX in CI because the test checks that total memory consumption is less than 64 Mb, but AIX uses over 100 Mb just as a baseline. So instead, let's compare the memory consumption to the baseline and make sure it is within 32 Mb. PR-URL: https://github.com/nodejs/node/pull/38062 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: fix flaky test-vm-memleakRich Trott2021-09-071-1/+2
| | | | | | | | | | | | Force garbage collection so that the memory leak is more easily differentiated from ordinary not-garbage-collected memory. Refs: https://github.com/nodejs/node/pull/34289 PR-URL: https://github.com/nodejs/node/pull/38054 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: fix flaky test-child-process-exec-abortcontroller-promisifiedAntoine du Hamel2021-09-071-6/+3
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/37568 PR-URL: https://github.com/nodejs/node/pull/37572 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: make utils.SearchFiles Python2-compatibleMichaël Zasso2021-09-071-4/+8
| | | | | | PR-URL: https://github.com/nodejs/node/pull/40020 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* tools: update workflow to open a pull requestRich Trott2021-09-041-0/+11
| | | | | | | | | | Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: https://github.com/nodejs/node/pull/39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: use find-inactive-collaborators to modify README.mdRich Trott2021-09-042-2/+92
| | | | | | | | | Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: https://github.com/nodejs/node/pull/39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: fix update authors commitMestery2021-09-041-0/+1
| | | | | | | | | | | Refs: https://github.com/nodejs/node/pull/39855#issuecomment-904387651 PR-URL: https://github.com/nodejs/node/pull/39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* doc: add duplicate CVE check in sec. release docDaniel Bevenius2021-09-041-0/+3
| | | | | | | | | | | | | | | | | | This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: https://github.com/nodejs/node/pull/39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add authors.ymlTierney Cyren2021-09-041-0/+21
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* doc: improve description of the triagers teamMichaël Zasso2021-09-041-5/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39833 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: V8: cherry-pick 00bb1a77c03eDarshan Sen2021-09-043-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: https://github.com/v8/v8/commit/00bb1a77c03ec951a5def21c64bee38cd855be7b Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: update instructions for ccMichael Dawson2021-09-041-1/+6
| | | | | | | | | | | - update intructions on adding cc for email to nodejs-sec mailing list as UI does not allow it to be done directly. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/39674 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* tools: fix markdown lintingRich Trott2021-09-047-38153/+30804
| | | | | | | | | | | | | | This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: update markdown linter dependencies and move to ESMAntoine du Hamel2021-09-044-4406/+4056
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: add gyp as owner of gyp files and tools/gypmary marchini2021-09-041-0/+6
| | | | | | | | | | Co-authored-by: Jiawen Geng <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34847 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: update rollup to latest version in markdown linterRich Trott2021-09-043-24093/+4366
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39797 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* policy: canonicalize before resolving specifiersBradley Farias2021-09-0412-351/+772
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37863 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* esm: use correct URL for error decorationBradley Farias2021-09-044-3/+40
| | | | | | PR-URL: https://github.com/nodejs/node/pull/37854 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
* repl: fix tla function hoistingDon Jayamanne2021-09-042-3/+7
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39745 Fixes: https://github.com/nodejs/node/issues/39744 Reviewed-By: Guy Bedford <guybedford@gmail.com>
* build: add option to hide console windowCheng Zhao2021-09-045-1/+16
| | | | | | | | | | | | Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW property when spawning processes, which is useful for GUI programs that do not want to show console windows when running terminal commands. PR-URL: https://github.com/nodejs/node/pull/39712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fix malformed changelog entriesRich Trott2021-09-041-141/+97
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39791 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* doc: fix lint errors in packages.mdRich Trott2021-09-041-2/+2
| | | | | | | | | | | Code samples that use CJS-only syntax need to use the cjs markdown identifiers. PR-URL: https://github.com/nodejs/node/pull/39792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
* tools: update markdown lint dependenciesRich Trott2021-09-043-22182/+25097
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: add example of self-reference in scoped packagesJesús Leganés-Combarro 'piranna2021-09-041-0/+26
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37630 Fixes: https://github.com/nodejs/node/issues/37618 Refs: https://github.com/nodejs/node/issues/37618#issuecomment-791888177 Co-authored-by: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* doc: add himadriganguly as a triagerHimadri Ganguly2021-09-041-0/+2
| | | | | | | | | | | | I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: https://github.com/nodejs/node/pull/39757 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* policy: fix integrity when DEFAULT_ENCODING is setTobias Nießen2021-09-046-2/+60
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39750 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: use simplfied validatorvoltrexmaster2021-09-041-2/+2
| | | | | | | | | | The validators test should use the simplified `validateArray()` validator. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* dgram: use simplified validatorVoltrex2021-09-041-2/+2
| | | | | | | | | | The `dgram` lib module should use the simplified `validatePort()` validator. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* lib: simplify validatorsVoltrex2021-09-041-4/+3
| | | | | | | | | | | Some of the validators can be simplified by removing unnecessary object parameters and using validators in another validators to keep consistency. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* tools: bump remark-preset-lint-node to 3.0.0Rich Trott2021-09-043-3068/+38493
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* tools: update markdown linter rulesRich Trott2021-09-041-0/+5
| | | | | | | | | | | | Update remark-preset-lint-node to 2.2.0 which includes improved YAML comment linting for our markdown files. PR-URL: https://github.com/nodejs/node/pull/38384 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fix YAML comment opening tagsJayden Seric2021-09-044-8/+8
| | | | | | | | | | | | Several YAML documentation comments incorrectly started with `<!--YAML` instead of `<!-- YAML`, resulting in their content missing in the rendered documentation. PR-URL: https://github.com/nodejs/node/pull/38324 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* src: fix TextDecoder final flush size calculationJames M Snell2021-09-041-2/+15
| | | | | | | | | | | Flushing a TextDecoder with a zero-sized input and pending incomplete characters was failing when fatal: false. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* tools: update path-parse in markdown linter package-lock fileRich Trott2021-09-042-6/+6
| | | | | | | | Refs: https://github.com/advisories/GHSA-hj48-42vr-x3v9 PR-URL: https://github.com/nodejs/node/pull/39729 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* lib: cleanup validationVoltrex2021-09-041-10/+3
| | | | | | | | | | Used the `validateInteger()` validator to cleanup validation and keep consistency. PR-URL: https://github.com/nodejs/node/pull/39652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* doc: fix `fs.rmdir` `recursive` option deprecation historyAntoine du Hamel2021-09-041-0/+9
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39728 Refs: https://github.com/nodejs/node/pull/35579 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: fix more build warnings in inspector_protocolRichard Lau2021-09-042-4/+6
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: cherry-pick ffb34b6d5dbf0Darshan Sen2021-09-042-4/+6
| | | | | | | | | | | | | | | | | | | | | Original commit message: tools: fix compiler warning in inspector_protocol error: comparison of integer expressions of different signedness: ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare] 2562 | if (!success || std::numeric_limits<int32_t>::max() < | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ 2563 | token_start_internal_value_) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~ PR-URL: https://github.com/nodejs/node/pull/37573 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39725 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fixed variable names in queueMicrotask exampleashish maurya2021-09-041-2/+2
| | | | | | | | | | | | fixed variable name in queueMicrotask where url variable was used instead of key PR-URL: https://github.com/nodejs/node/pull/39634 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* lib: use validatorsVoltrex2021-09-042-8/+24
| | | | | | | | Used more validators for the sake of consistency. PR-URL: https://github.com/nodejs/node/pull/39663 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* lib: use validatorVoltrex2021-09-041-6/+7
| | | | | | | | | | Used the `validateArray()` validator for array validation for consistency. (Refs: #39536) PR-URL: https://github.com/nodejs/node/pull/39547 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* lib: use `validateObject`Voltrex2021-09-041-11/+24
| | | | | | | | | | | | Used the validateObject() validator to keep consistency instead of a custom validator which was only used to validate objects. Refs: #39595 PR-URL: https://github.com/nodejs/node/pull/39605 Refs: https://github.com/nodejs/node/pull/39595 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: consolidate AUTHORS entries for ooHmartYRich Trott2021-09-042-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: consolidate AUTHORS entries for homosaurRich Trott2021-09-042-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: consolidate AUTHORS entries for Ayase-252Rich Trott2021-09-042-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: consolidate AUTHORS entries for robin-drexlerRich Trott2021-09-042-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39705 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
View Lorry Controller Status