summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2021-04-06, Version 15.14.0 (Current)v15.14.0v15.14.0-proposalMyles Borins2021-04-068-15/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | Notable Changes: This is a security release. Vulnerabilities fixed: - **CVE-2021-3450**: OpenSSL - CA certificate check bypass with X509_V_FLAG_X509_STRICT (High) - **CVE-2021-3449**: OpenSSL - NULL pointer deref in signature_algorithms processing (High) - **CVE-2020-7774**: npm upgrade - Update y18n to fix Prototype-Pollution (High) Other Notable changes: fs: * (SEMVER-MINOR) add support for async iterators to `fsPromises.writeFile` (HiroyukiYagihashi) https://github.com/nodejs/node/pull/37490 net: * (SEMVER-MINOR) allow net.BlockList to use net.SocketAddress objects (James M Snell) https://github.com/nodejs/node/pull/37917 * (SEMVER-MINOR) add SocketAddress class (James M Snell) https://github.com/nodejs/node/pull/37917 * (SEMVER-MINOR) make net.BlockList cloneable (James M Snell) https://github.com/nodejs/node/pull/37917 net,tls: * (SEMVER-MINOR) add abort signal support to connect (Nitzan Uziely) https://github.com/nodejs/node/pull/37735 readline: * (SEMVER-MINOR) add AbortSignal support to interface (Nitzan Uziely) https://github.com/nodejs/node/pull/37932 PR-URL: https://github.com/nodejs/node/pull/38084
* src: fix typo in node_mutexTobias Nießen2021-04-051-1/+1
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38011 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* fs: add support for async iterators to `fsPromises.writeFile`HiroyukiYagihashi2021-04-054-15/+138
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/37391 PR-URL: https://github.com/nodejs/node/pull/37490 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: fix typos in crypto commentsTobias Nießen2021-04-052-2/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/38024 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm nameFilip Skokan2021-04-0510-47/+52
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/38029 Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* doc: fix asyncLocalStorage.run() descriptionDarkripper2142021-04-051-2/+6
| | | | | | | | | | | | The description that store is not available when asynchronous operation is created within the callback is not accurate Fixes: https://github.com/nodejs/node/issues/38022 PR-URL: https://github.com/nodejs/node/pull/38023 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* test: add extra space in test failure outputQingyu Deng2021-04-051-2/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37957 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* module: improve error message for invalid data URLAntoine du Hamel2021-04-053-1/+36
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/37647 PR-URL: https://github.com/nodejs/node/pull/37701 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* test: use faster variant for rssPooja D P2021-04-051-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/36839 Refs: https://github.com/nodejs/node/pull/34291 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: document how to unref stdin when using readline.InterfaceAnu Pasumarthy2021-04-051-0/+12
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/38019 Fixes: https://github.com/nodejs/node/issues/36154 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* test: fix test-tls-no-sslv3 for OpenSSL 3Richard Lau2021-04-051-1/+1
| | | | | | | | | | | | OpenSSL 3 has changed the format of the error message for an unknown option to the CLI. Update the test to allow for the older and newer message formats. PR-URL: https://github.com/nodejs/node/pull/38027 Refs: https://github.com/openssl/openssl/pull/10774 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: add buffering to randomIntTobias Nießen2021-04-052-25/+100
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35110 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: deflake test-fs-read-optional-paramsLuigi Pinca2021-04-051-4/+4
| | | | | | | | | | | | | | | If `fs.read()` is called without specifying the `position` option, data will be read from the current file position. There is another concurrent `fs.read()` call before the test for no options object which might invalidate the test expectations. Run the test for no options object first. PR-URL: https://github.com/nodejs/node/pull/37991 Fixes: https://github.com/nodejs/node/issues/37946 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: update ESLint to 7.23.0Luigi Pinca2021-04-05394-10514/+13054
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/37979 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* src: fix error handling for CryptoJob::ToResultTobias Nießen2021-04-054-10/+69
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/37076 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* fs: fix chown abortDarshan Sen2021-04-053-24/+25
| | | | | | | | | | | | | This syncs the type assertion introduced in the referenced PR in the C++ side. Since chown, lchown, and fchown can accept -1 as a value for uid and gid, we should also accept signed integers from the JS side. Fixes: https://github.com/nodejs/node/issues/37995 Refs: https://github.com/nodejs/node/pull/31694 PR-URL: https://github.com/nodejs/node/pull/38004 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: move psmarshall to collaborators emeritiPeter Marshall2021-04-051-2/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37994 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: improve clarity of ALS-enable-disable.jsDarkripper2142021-04-041-2/+2
| | | | | | | | | | | The last als.run() will reactivate the als, hence the test should test for getting the object, not undefined PR-URL: https://github.com/nodejs/node/pull/38008 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* net: allow net.BlockList to use net.SocketAddress objectsJames M Snell2021-04-048-159/+235
| | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37917 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* net: add SocketAddress classJames M Snell2021-04-0410-0/+516
| | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37917 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* net: make net.BlockList cloneableJames M Snell2021-04-049-55/+247
| | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/37917 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* doc: add distinctive color for code elements inside linksAntoine du Hamel2021-04-041-2/+6
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/37950 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* lib: change wording in lib/domain.js commentAkhil Marsonya2021-04-041-1/+1
| | | | | | | | | | | | | Change the wording to make the language more Inclusive. PR-URL: https://github.com/nodejs/node/pull/37933 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* lib: change wording in lib/internal/child_process commentAkhil Marsonya2021-04-041-1/+1
| | | | | | | | | | | | Change the wording to make the language more Inclusive. PR-URL: https://github.com/nodejs/node/pull/37903 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* readline: fix pre-aborted signal question handlingNitzan Uziely2021-04-042-0/+34
| | | | | | | | fix pre-aborted question handling PR-URL: https://github.com/nodejs/node/pull/37929 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* readline: add AbortSignal support to interfaceNitzan Uziely2021-04-043-2/+79
| | | | | | | | Add abort signal support to Interface PR-URL: https://github.com/nodejs/node/pull/37932 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* net,tls: add abort signal support to connectNitzan Uziely2021-04-047-0/+388
| | | | | | | | | Add documentation for net.connect AbortSignal, and add the support to tls.connect as well PR-URL: https://github.com/nodejs/node/pull/37735 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: add missing events.on metadataAnna Henningsen2021-04-041-0/+4
| | | | | | | | | | | | | | This was missed in the original PR. Refs: https://github.com/nodejs/node/pull/34912 PR-URL: https://github.com/nodejs/node/pull/37965 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* http2: add specific error code for custom framesAnna Henningsen2021-04-047-31/+70
| | | | | | | | | | | | As suggested in https://github.com/nodejs/node/issues/37849#issuecomment-805049586 improve the error presented when encountering a large number of invalid frames by giving this situation a specific error code (which we should have had from the beginning). PR-URL: https://github.com/nodejs/node/pull/37936 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
* tools,doc: add "legacy" badge in the TOCAntoine du Hamel2021-04-042-3/+11
| | | | | | PR-URL: https://github.com/nodejs/node/pull/37949 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: update to cjs-module-lexer@1.1.1Guy Bedford2021-04-047-15/+35
| | | | | | PR-URL: https://github.com/nodejs/node/pull/37992 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* path: refactor to use more primordialsAkhil Marsonya2021-04-041-2/+2
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37893 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* http: optimize debug function correctlyMichaël Zasso2021-04-044-4/+13
| | | | | | | | | | | | | Exporting a variable that will be mutated later doesn't work. Refs: https://github.com/nodejs/node/issues/37937 PR-URL: https://github.com/nodejs/node/pull/37966 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: improve Buffer's encoding documentationMichaël Zasso2021-04-043-16/+20
| | | | | | | | | | | | - Add a paragraph about case-insensitivity of encoding options. - Document "utf-8", "utf-16le" and "ucs-2" aliases. - Always use "utf8" in documentation for defaults and examples. PR-URL: https://github.com/nodejs/node/pull/37945 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add missing cleanup step in OpenSSL upgradeTobias Nießen2021-04-041-1/+3
| | | | | | | | | | Refs: https://github.com/nodejs/node/pull/37916 PR-URL: https://github.com/nodejs/node/pull/37927 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* deps: update archs files for OpenSSL-1.1.1kHassaan Pasha2021-04-04137-208/+211
| | | | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/37916 Fixes: https://github.com/nodejs/node/issues/37913 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* deps: upgrade openssl sources to 1.1.1k+quicHassaan Pasha2021-04-0440-208/+600
| | | | | | | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ git clone https://github.com/quictls/openssl $ cd openssl $ git checkout OpenSSL_1_1_1k+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../openssl openssl $ cd openssl && rm -rf .gitattributes .github/ .gitmodules .travis-apt-pin.preferences .travis-create-release.sh $ cd .. $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/37916 Fixes: https://github.com/nodejs/node/issues/37913 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* doc: add Windows-specific info to subprocess.kill()João Lucas Lucchetta2021-04-041-0/+6
| | | | | | | | | | | | Clarify the inner workings of .kill on Windows, since termination signals are not available there. Fixes: https://github.com/nodejs/node/issues/34858 PR-URL: https://github.com/nodejs/node/pull/34867 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* url: forbid pipe in URL hostDarshan Sen2021-04-045-12/+67
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/37862 PR-URL: https://github.com/nodejs/node/pull/37877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: add DataView test case for v8 serdesRich Trott2021-04-041-0/+1
| | | | | | | | | | | | | This completes code coverage for v8.js. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/v8.js.html#L240 PR-URL: https://github.com/nodejs/node/pull/37955 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: cjs-module-lexer: cherry-pick 22093e765fpezhmanparsaee2021-04-041-1/+1
| | | | | | | | | | | | Original commit message: fix "the the" typo in README.md file Refs: https://github.com/guybedford/cjs-module-lexer/commit/22093e765f02d1c97c1bd9baf3ea21653ba92548 PR-URL: https://github.com/nodejs/node/pull/37895 Reviewed-By: Pooja D P <Pooja.D.P@ibm.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com>
* Working on v15.13.1Ruy Adorno2021-03-311-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/37977
* 2021-03-31, Version 15.13.0 (Current)v15.13.0v15.13.0-proposalRuy Adorno2021-03-308-15/+120
| | | | | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37977 Notable changes: * buffer: * implement btoa and atob (James M Snell) https://github.com/nodejs/node/pull/37529 * deps: * upgrade npm to 7.7.6 (Ruy Adorno) https://github.com/nodejs/node/pull/37968 * doc: * add legacy status to stability index (James M Snell) https://github.com/nodejs/node/pull/37784 * add @linkgoron to collaborators (Nitzan Uziely) https://github.com/nodejs/node/pull/37817 * http: * add http.ClientRequest.getRawHeaderNames() (simov) https://github.com/nodejs/node/pull/37660
* deps: backport v8 f19142e6Guy Bedford2021-03-3017-87/+336
| | | | | | | | | | | [top-level-await] Implement the new post-order requirement for async subgraphs Refs: https://github.com/v8/v8/commit/f19142e6139979da3a177cb0b9f382e459f5ccec PR-URL: https://github.com/nodejs/node/pull/37864 Backport-PR-URL: https://github.com/nodejs/node/pull/37985 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* deps: v8 backport 9689b17687bGuy Bedford2021-03-3013-62/+109
| | | | | | | | | [top-level-await] Implement spec fix for cycle root detection Refs: http://github.com/v8/v8/commit/9689b17687b21c800c3f7400df4255c55b9c6ec0 PR-URL: https://github.com/nodejs/node/pull/37865 Backport-PR-URL: https://github.com/nodejs/node/pull/37985 Reviewed-By: Michaël Zasso <targos@protonmail.com>
* deps: upgrade npm to 7.7.6Ruy Adorno2021-03-2925-31/+131
| | | | | | PR-URL: https://github.com/nodejs/node/pull/37968 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: split promisified timers test for coverage purposesRich Trott2021-03-293-160/+198
| | | | | | | | | | | | Because of lazy loading, running promisified timers tests for setTimeout and setImmediate from the same file means that there is a piece of code that doesn't get covered. Split into separate files to cover everything. Refs: https://coverage.nodejs.org/coverage-290c158018ac0277/lib/timers.js.html#L269 PR-URL: https://github.com/nodejs/node/pull/37943 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* perf_hooks: make Performance extend EventTargetMichaël Zasso2021-03-292-4/+5
| | | | | | | | | | | | Refs: https://www.w3.org/TR/hr-time/#sec-performance PR-URL: https://github.com/nodejs/node/pull/37621 Backport-PR-URL: https://github.com/nodejs/node/pull/37832 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* util: remove unreachable inspect codeRich Trott2021-03-291-3/+1
| | | | | | | | | Convert invariant from if statement to an assertion. The condition is believed to be impossible to trigger. PR-URL: https://github.com/nodejs/node/pull/37941 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fix typos in lib/internal/bootstrap/pre_execution.jsmarsonya2021-03-291-2/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37658 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>