summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2022-06-01, Version 16.15.1 'Gallium' (LTS)v16.15.1Juan José Arboleda2022-06-013-2/+35
| | | | | | | | | | | Notable changes: - deps: upgrade npm to 8.11.0 (<npm-cli+bot@github.com>) https://github.com/nodejs/node/pull/43210 - doc: - add release key for RafaelGSS (Rafael Gonzaga) https://github.com/nodejs/node/pull/43131 - add release key for Juan Arboleda (Juan José) https://github.com/nodejs/node/pull/42961 PR-URL: https://github.com/nodejs/node/pull/43272
* doc: add release key for RafaelGSSRafael Gonzaga2022-06-011-0/+3
| | | | | PR-URL: https://github.com/nodejs/node/pull/43131 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add release key for Juan ArboledaJuan José2022-06-011-0/+3
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42961 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* test: delete test/pummel/test-repl-empty-maybelocal-crash.jsDarshan Sen2022-06-011-20/+0
| | | | | | | | | | | | | | | | | It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: https://github.com/nodejs/node/issues/42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42720 Backport-PR-URL: https://github.com/nodejs/node/pull/42967 Fixes: https://github.com/nodejs/node/issues/42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* src,inspector: fix empty MaybeLocal crashDarshan Sen2022-06-012-4/+24
| | | | | | | | | | | | | | | | | | Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: https://github.com/nodejs/node/issues/42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42409 Backport-PR-URL: https://github.com/nodejs/node/pull/42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: V8: cherry-pick 3ebf2052a1b2Liu Yu2022-05-312-2/+1
| | | | | | | | | | | | | | | | | | | | Original commit message: [mips64] Remove a useless declaration of Operand. Change-Id: I5144d8315b5c1aca751d138e4d87240b703dc9e3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3650359 Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Yu Liu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80585} Refs: https://github.com/v8/v8/commit/3ebf2052a1b270393eafb093a98ceca844ad237a PR-URL: https://github.com/nodejs/node/pull/43147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* tools: disable trap handler for Windows cross-compilerMichaël Zasso2022-05-311-3/+6
| | | | | | | | | | `handler-outside-simulator.cc` uses inline assembly, which is not supported by MSVC. PR-URL: https://github.com/nodejs/node/pull/40488 Backport-PR-URL: https://github.com/nodejs/node/pull/43247 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: update V8 gypfiles for 9.6Michaël Zasso2022-05-311-132/+66
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/40488 Backport-PR-URL: https://github.com/nodejs/node/pull/43247 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: upgrade npm to 8.11.0npm-cli+bot@github.com2022-05-31120-2237/+2044
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43210 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: upgrade npm to 8.10.0npm-cli+bot@github.com2022-05-31102-2146/+2072
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/43061 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
* deps: upgrade npm to 8.9.0npm-robot2022-05-31127-364/+666
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42968 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* deps: update archs files for OpenSSL-1.1.1oRafaelGSS2022-05-11133-324/+308
| | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/42957 Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-May/000223.html Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* deps: upgrade openssl sources to OpenSSL_1_1_1oRafaelGSS2022-05-1139-116/+687
| | | | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ git clone https://github.com/quictls/openssl $ cd openssl $ git checkout OpenSSL_1_1_1o+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../openssl openssl $ rm -rf openssl/.git* openssl/.travis* $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/42957 Refs: https://mta.openssl.org/pipermail/openssl-announce/2022-May/000223.html Reviewed-By: Beth Griggs <bgriggs@redhat.com>
* deps: upgrade npm to 8.8.0npm-robot2022-05-02174-2200/+7767
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* deps: upgrade npm to 8.7.0ops+robot@npmjs.com2022-05-02340-6011/+4868
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42744 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* deps: upgrade npm to 8.6.0npm team2022-05-02203-3135/+4389
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42550 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* Working on v16.15.1Danielle Adams2022-04-261-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/42847
* 2022-04-26, Version 16.15.0 'Gallium' (LTS)v16.15.0Danielle Adams2022-04-2616-46/+345
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Notable changes: Add fetch API Adds experimental support to the fetch API. This adds the `--experimental-fetch` flag that installs the `fetch`, `Request`, `Response`, `Headers`, and `FormData` globals. * (SEMVER-MINOR) add fetch (Michaël Zasso) https://github.com/nodejs/node/pull/41749 * (SEMVER-MINOR) add FormData global when fetch is enabled (Michaël Zasso) https://github.com/nodejs/node/pull/41956 Other notable changes * build: * remove broken x32 arch support (Ben Noordhuis) https://github.com/nodejs/node/pull/41905 * crypto: * (SEMVER-MINOR) add KeyObject.prototype.equals method (Filip Skokan) https://github.com/nodejs/node/pull/42093 * doc: * add @ShogunPanda to collaborators (Paolo Insogna) https://github.com/nodejs/node/pull/42362 * add JakobJingleheimer to collaborators list (Jacob Smith) https://github.com/nodejs/node/pull/42185 * add joesepi to collaborators (Joe Sepi) https://github.com/nodejs/node/pull/41914 * add marsonya to collaborators (Akhil Marsonya) https://github.com/nodejs/node/pull/41991 * deprecate string coercion in `fs.write`, `fs.writeFileSync` (Livia Medeiros) https://github.com/nodejs/node/pull/42149 * deprecate notice for process methods (Yash Ladha) https://github.com/nodejs/node/pull/41587 * esm: * (SEMVER-MINOR) support https remotely and http locally under flag (Bradley Farias) https://github.com/nodejs/node/pull/36328 * module: * (SEMVER-MINOR) unflag esm json modules (Geoffrey Booth) https://github.com/nodejs/node/pull/41736 * node-api: * (SEMVER-MINOR) add node_api_symbol_for() (Darshan Sen) https://github.com/nodejs/node/pull/41329 * process: * deprecate multipleResolves (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/41872 * stream: * (SEMVER-MINOR) support some and every (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/41573 * (SEMVER-MINOR) add toArray (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/41553 * (SEMVER-MINOR) add forEach method (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/41445 PR-URL: https://github.com/nodejs/node/pull/42847
* esm: fix base URL for network importsBradley Farias2022-04-237-16/+79
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/42131 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* esm: fix relative imports for httpsBradley Farias2022-04-232-1/+13
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42119 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* meta: update AUTHORSNode.js GitHub Bot2022-04-231-0/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42404 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: update lint-md-dependencies to rollup@2.70.1Node.js GitHub Bot2022-04-233-37/+49
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42403 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* crypto: fix auth tag length error when mode != GCMTobias Nießen2022-04-232-2/+17
| | | | | PR-URL: https://github.com/nodejs/node/pull/42383 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: improve README.md usabilityRich Trott2022-04-231-10/+2
| | | | | | | | | | | | | | | | * The logo takes a lot of room doesn't add information. * Make Node.js a top-level header and Table of Contents a second-level header. This looks better, improve semantics, makes the README.md more usable in its raw form, and aligns us with README.md practices in other projects like TypeScript and Deno. PR-URL: https://github.com/nodejs/node/pull/42378 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* test,crypto: add and update empty passphrase regression testsDarshan Sen2022-04-231-33/+54
| | | | | | | | | Refs: https://github.com/openssl/openssl/pull/17507 Refs: https://github.com/nodejs/node/issues/41428 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* deps: upgrade npm to 8.5.5npm team2022-04-23191-4013/+4340
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42382 Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: add that chacha20-poly1305 is IETF versionTobias Nießen2022-04-231-2/+4
| | | | | PR-URL: https://github.com/nodejs/node/pull/42370 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* test: give slow tests more time on Rasberry PIsMichael Dawson2022-04-231-1/+1
| | | | | | | | | | | | | | | Refs: https://github.com/nodejs/node/issues/42379 A number of tests have been failing internmittently on the Rasberry PIs with timeouts since the update to OpenSSL 3.0. Give them more time. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42380 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* src: convert hex2bin() into a regular functionDarshan Sen2022-04-231-2/+1
| | | | | | | | | | | No need to write hex2bin() as a function template because it's only called with a char parameter. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42321 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: document goal to have examplesMichael Dawson2022-04-231-0/+2
| | | | | | | | | | | | | | | | As discussed in next-10 mini-summit on documentation see minutes where next steps were discussed - https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md and minutes from summit - https://github.com/nodejs/next-10/blob/main/meetings/2022-02-16.md Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42274 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* http: trace http client by perf_hookstheanarkh2022-04-235-9/+66
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42345 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* worker: do not send message if port is closingRich Trott2022-04-232-1/+9
| | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/42296 PR-URL: https://github.com/nodejs/node/pull/42357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: improve https_renew_cert.sh scriptTobias Nießen2022-04-232-15/+22
| | | | | | | | | | | | | | | | | | | | | | - To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: https://github.com/nodejs/node/pull/42342 Refs: https://github.com/nodejs/node/pull/37990 PR-URL: https://github.com/nodejs/node/pull/42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* doc: fix Embedder's Guide link to V8 official docsAroyan2022-04-231-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42373 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* doc: remove unneeded lint disable commentRich Trott2022-04-231-2/+0
| | | | | PR-URL: https://github.com/nodejs/node/pull/42374 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: revise async_hooks docsRich Trott2022-04-231-10/+10
| | | | | | | | | | The only significant change is to replace AsyncHooks with `AsyncHook`. PR-URL: https://github.com/nodejs/node/pull/42337 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* doc: add @ShogunPanda to collaboratorsShogun2022-04-231-0/+2
| | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42362 Fixes: https://github.com/nodejs/node/issues/42245 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* doc: update base branch name for `nodejs/nodejs.org`Danielle Adams2022-04-231-2/+3
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42355 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* esm: make extension-less errors in type:module actionableBradley Farias2022-04-235-14/+36
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42301 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* lib: refactor to use primordials in `lib/assert.js`akhil marsonya2022-04-231-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41702 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* doc: fix async iterable pipeline signal examplesRandall Leeds2022-04-231-2/+2
| | | | | | | | | Fix the pipeline examples to show that async generators receive an AbortSignal wrapped in an object. PR-URL: https://github.com/nodejs/node/pull/42258 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: clarify path search in `child_process.spawn`Damjan Cvetko2022-04-231-2/+5
| | | | | | | | | | | | | | The documentation about command lookup could be more clear and note differences between Windows and Linux/OSX. Current text gives the impression that if one passes `options.env` without `PATH`, the path search will fall back on `process.env.PATH`. In reality, passing environment without `PATH` to `execvp` causes it to look for the binary only in `/usr/bin:/bin`. Also Windows behaves different and more in line with the current documentation text. PR-URL: https://github.com/nodejs/node/pull/41418 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: improve _http_incoming.js coverageYoshiki Kurihara2022-04-231-0/+27
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42211 Refs: https://coverage.nodejs.org/coverage-010cb714161102de/lib/_http_incoming.js.html Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: improve _http_outgoing coverageYoshiki Kurihara2022-04-231-0/+10
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42213 Refs: https://coverage.nodejs.org/coverage-29bb2bb57d2a993e/lib/_http_outgoing.js.html Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* src: fix coverity warnings in node_file.ccMichael Dawson2022-04-231-2/+2
| | | | | | | | | | | | | | | | Fix two warnings about a useless call and not checking a return value. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42272 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* src: check EC_POINT_get_affine_coordinates resultTobias Nießen2022-04-231-1/+5
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/42304 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: update doc to highlight.js@11.5.0 unified@10.1.2Node.js GitHub Bot2022-04-232-40/+40
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42315 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com>
* tools: update lint-md-dependencies to rollup@2.70.0 unified@10.1.2Node.js GitHub Bot2022-04-233-17/+17
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42316 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com>
* src: simplify bound check in ParseArrayIndexTobias Nießen2022-04-231-2/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: avoid returning invalid value from hex2binTobias Nießen2022-04-231-1/+1
| | | | | | | | | | | | If the input is not a valid hexadecimal digit, hex2bin should not return an invalid value, which is not handled correctly by the caller, which is the PercentDecode function. However, PercentDecode only ever calls the hex2bin function with valid hexadecimal digits, so mark the code path that previously returned an invalid value for non-digits as UNREACHABLE. PR-URL: https://github.com/nodejs/node/pull/42307 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
View Lorry Controller Status