summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* process: inspect error in case of a fatal exceptionRuben Bridgewater2019-05-1611-9/+76
| | | | | | | | | | | | | This makes sure that errors that shut down the application are inspected with `util.inspect()`. That makes sure that all extra properties on the error will be visible and also that the stack trace is highlighted (Node.js internal frames will be grey and node modules are underlined). PR-URL: https://github.com/nodejs/node/pull/27243 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: update dmn to 2.2.2Rich Trott2019-05-162-2/+2
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27686 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* child_process: refactor stdioStringToArray functionzero1five2019-05-162-23/+23
| | | | | | | | | reduce the function in both files to one. PR-URL: https://github.com/nodejs/node/pull/27657 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: DRY isRequireCall() in lint rulescjihrig2019-05-154-24/+12
| | | | | | | | | | | This commit makes isRequireCall() a reusable utility function for core's custom ESLint rules. PR-URL: https://github.com/nodejs/node/pull/27680 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
* tls: expose keylog event on TLSSocketAlba Mendez2019-05-158-1/+143
| | | | | | | | | | | | | | | Exposes SSL_CTX_set_keylog_callback in the form of a `keylog` event that is emitted on clients and servers. This enables easy debugging of TLS connections with i.e. Wireshark, which is a long-requested feature. PR-URL: https://github.com/nodejs/node/pull/27654 Refs: https://github.com/nodejs/node/issues/2363 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* inspector: added NodeRuntime domainAleksei Koziatinskii2019-05-147-5/+175
| | | | | | | | | | | | | | | | | | | | | | | | | Historically Node process sends Runtime.executionContextDestroyed with main context as argument when it is finished. This approach has some disadvantages. V8 prevents running some protocol command on destroyed contexts, e.g. Runtime.evaluate will return an error or Debugger.enable won't return a list of scripts. Both command might be useful for different tools, e.g. tool runs Profiler.startPreciseCoverage and at the end of node process it would like to get list of all scripts to match data to source code. Or some tooling frontend would like to provide capabilities to run commands in console when node process is finished to allow user to inspect state of the program at exit. This PR adds new domain: NodeRuntime. After NodeRuntime.notifyWhenWaitingForDisconnect is enabled by at least one client, node will send NodeRuntime.waitingForDebuggerToDisconnect event instead of Runtime.executionContextDestroyed. Based on this signal any protocol client can capture all required information and then disconnect its session. PR-URL: https://github.com/nodejs/node/pull/27600 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* fs: extract path conversion and validation to getValidatedPathZYSzys2019-05-145-153/+85
| | | | | | | | | | | | | | | | | Almost all path validations within our file system are combined with: ```js path = toPathIfFileURL(path); validatePath(path); ``` So simply extracted them out into `getValidatedPath` function to `internal/fs/utils.js` to DRY up the code and reduce duplicating them. PR-URL: https://github.com/nodejs/node/pull/27656 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc,tools: updates for 6.x End-of-LifeRichard Lau2019-05-142-50/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27658 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
* tools: add `12.x` to alternative docs versionsRichard Lau2019-05-141-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27658 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
* deps: update OpenSSL configs' timestampsJon Kunkee2019-05-14116-122/+122
| | | | | | | | | | | | | | | This change contains the results of running `make` in `deps/openssl/config` (based on information in deps/openssl/config/README.md) and not reverting anything. This is not necessary, but it does indicate to the curious developer that all architectures were automatically generated at the same time. PR-URL: https://github.com/nodejs/node/pull/27544 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: regenerate OpenSSL configs with fixed toolingJon Kunkee2019-05-143-10/+7
| | | | | | | | | | | | | | | | This change contains the results of running `make` in `deps/openssl/config` (based on information in deps/openssl/config/README.md) then reverting changes not in the VC-WIN64-ARM directory. This leverages a preceding change that fixes a cross-configuration file reuse bug that only impacts VC-WIN64-ARM. PR-URL: https://github.com/nodejs/node/pull/27544 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: clearing require cache crashes esm loaderAntoine du HAMEL2019-05-141-0/+11
| | | | | | | | | | | This test shows the regression introduced in v11.4.0: clearing out the require.cache crashes node when using the `--experimental-modules` flag. Refs: https://github.com/nodejs/node/issues/25482 PR-URL: https://github.com/nodejs/node/pull/25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* esm: fix esm load bugZYSzys2019-05-141-3/+5
| | | | | | | | | Fixes: https://github.com/nodejs/node/issues/25482 PR-URL: https://github.com/nodejs/node/pull/25491 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: format correction for experimental loader hooksDaniel Nalborczyk2019-05-141-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/27537 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: make VC-WIN config generation deterministicJon Kunkee2019-05-134-4/+11
| | | | | | | | | | | This change adds a clean target to the VC-WIN* Makefiles, then adjusts the config generation script to call it before config file generation as well as after. This prevents files from previous configurations from causing make to incorrectly assume the files are up to date. PR-URL: https://github.com/nodejs/node/pull/27543 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: dns.lookup() documentation error codejvelezpo2019-05-131-2/+2
| | | | | | | | | | | | dns.lookup() will always return ENOTFOUND on a empty lookup or when the host not found. https://github.com/nodejs/node/blob/master/lib/internal/errors.js#L503 Fixes: https://github.com/nodejs/node/issues/27604 PR-URL: https://github.com/nodejs/node/pull/27625 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* vm: mark global proxy as side-effect-freeAnna Henningsen2019-05-143-8/+76
| | | | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/27518 PR-URL: https://github.com/nodejs/node/pull/27523 Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: pass null params to napi_xxx_property()Octavian Soldea2019-05-132-0/+215
| | | | | | | | | | | | | | | | | | | | | | | | | | For napi_set_property(), each one of the following arguments is checked: napi_env env, napi_value object, napi_value key, napi_value* value. For napi_has_property(), each one of the following arguments is checked: napi_env env, napi_value object, napi_value key, bool* result For napi_get_property, each one of the following arguments is checked: napi_env env, napi_value object, napi_value key, napi_value* result PR-URL: https://github.com/nodejs/node/pull/27628 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc,meta: codify security release commit messageRichard Lau2019-05-131-0/+15
| | | | | | | | | | | | | | | | | | | | | The release commit message for security releases have conventionally started with the phrase `This is a security release.`. Codify this as part of the release process so that the distribution indexer can use this to detect and mark releases as security releases. Fixes: https://github.com/nodejs/Release/issues/437 Refs: https://github.com/nodejs/node/pull/27612#issuecomment-490698922 Refs: https://github.com/nodejs/nodejs-dist-indexer/pull/9 PR-URL: https://github.com/nodejs/node/pull/27643 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* lib: fix typo in pre_execution.jsgengjiawen2019-05-131-1/+1
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27649 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* assert: loose deep equal should not compare symbol propertiesRuben Bridgewater2019-05-132-6/+16
| | | | | | | | | | | | | This is the way it's currently documented and that seems appropriate for loose equal assertions. The change was not intentional. Fixes: https://github.com/nodejs/node/issues/27652 PR-URL: https://github.com/nodejs/node/pull/27653 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
* test: use common.PORT instead of an extraneous variableBenjamin Ki2019-05-131-5/+3
| | | | | | | | | | | | | This test is not parallelized and so we can use the test commons PORT variable. Refs: https://github.com/nodejs/node/pull/27565#discussion_r281000162 PR-URL: https://github.com/nodejs/node/pull/27565 Fixes: https://github.com/nodejs/node/issues/27341 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: move dgram invalid host test to internet testsBenjamin Ki2019-05-132-12/+23
| | | | | | | | | | | | | | This moves a dgram test from `parallel` to `internet` because it relies on a DNS request. In certain cases, ISPs hijack invalid IETF-reserved invalid names which causes a false negative failure. Fixes: https://github.com/nodejs/node/issues/27341 PR-URL: https://github.com/nodejs/node/pull/27565 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* src: remove util-inl.h from header filesSam Roberts2019-05-1361-28/+67
| | | | | | | | | | | | Its intended that *-inl.h header files are only included into the src files that call the inline methods. Explicitly include it into the files that need it. PR-URL: https://github.com/nodejs/node/pull/27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* src: declare unused priv argumentSam Roberts2019-05-132-2/+4
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* src: fix warnings about redefined BSWAP macrosSam Roberts2019-05-131-0/+12
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27631 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* tools: allow RegExp in required-modules eslint ruleRichard Lau2019-05-133-23/+39
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/27647 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* module: fix createRequireFromPath() slash logiccjihrig2019-05-131-1/+1
| | | | | | | | | | | The trailing slash detection logic in createRequireFromPath() seemed slightly incorrect. This commit reworks the logic. PR-URL: https://github.com/nodejs/node/pull/27634 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: add call-once note to napi_queue_async_workGabriel Schulhof2019-05-131-1/+2
| | | | | | | | | | | | | Add note to `napi_queue_async_work()` indicating that, upon successful return, it must not be called again with the same work item. Fixes: https://github.com/nodejs/node/issues/27217 PR-URL: https://github.com/nodejs/node/pull/27582 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* module: add missing space in error messagecjihrig2019-05-132-2/+4
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27627 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: force common be required before any other modulesZYSzys2019-05-1352-66/+194
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/27650 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* async_hooks: only disable promise hook if wantedAnna Henningsen2019-05-133-11/+36
| | | | | | | | | | | | | | | | | | The promise hook has been disabled asynchronously in order to solve issues when an async hook is disabled during a microtask. This means that after scheduling the disable-promise-hook call, attempts to enable it synchronously will later be unintentionally overridden. In order to solve this, make sure that the promise hooks are still no longer desired at the time at which we would disable them. Fixes: https://github.com/nodejs/node/issues/27585 PR-URL: https://github.com/nodejs/node/pull/27590 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* http2: do not override the allowHalfOpen optionLuigi Pinca2019-05-131-1/+0
| | | | | | | | | | The constructors of `tls.Server` and `Http2Server` call the super constructors without options so the `allowHalfOpen` option is never used regardless of its value. PR-URL: https://github.com/nodejs/node/pull/27623 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* module: simplify createRequire() validationcjihrig2019-05-131-4/+3
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27629 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: restore `global.module` after --eval code is runAnna Henningsen2019-05-121-0/+4
| | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27587 Fixes: https://github.com/nodejs/node/issues/27575 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* repl: do not run --eval code if there is noneAnna Henningsen2019-05-122-3/+24
| | | | | | | | | | | | | | | | | | `getOptionValue('--eval')` always returns a string, so it is never loose-equal to `null`. Running eval makes some modifications to the global object, including setting `module` to a different value, which we want to avoid if possible. Refs: https://github.com/nodejs/node/pull/27278 PR-URL: https://github.com/nodejs/node/pull/27587 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* src: remove extra semicolons after macrosgengjiawen2019-05-121-7/+10
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27579 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
* test: better assertion for async hook testsAli Ijaz Sheikh2019-05-121-1/+2
| | | | | | | | | | | | The existing assertion was misleading to whether there were too few or too many events of a particular type. Improve the assertion message. PR-URL: https://github.com/nodejs/node/pull/27601 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: simplify test/README.mdRich Trott2019-05-111-6/+6
| | | | | | | | | | | Simplify phrasing in test/README.md. PR-URL: https://github.com/nodejs/node/pull/27630 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* meta: move firedfox to Collaborator Emeriti listRich Trott2019-05-111-2/+2
| | | | | | | | | | | | | They confirmed in email that they were fine with being moved to Collaborator Emeritus and hope to be back contributing again soon. PR-URL: https://github.com/nodejs/node/pull/27618 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: test error when breakOnSigint is not a boolean for evaluateRuwan Geeganage2019-05-111-0/+15
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27503 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* src: extract common macro to util.hgengjiawen2019-05-116-45/+19
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27512 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: simplify About This Documentation textRich Trott2019-05-111-7/+7
| | | | | | | | | | | Remove some unnecessary words and simplify some phrases in documentation.md. PR-URL: https://github.com/nodejs/node/pull/27619 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: add tests for hasItems method in FreeListRuwan Geeganage2019-05-101-0/+10
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27588 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* module: improve resolve paths validationcjihrig2019-05-102-16/+30
| | | | | | | | | | | | | | This commit adds input validation to require.resolve()'s paths option. Prior to this change, passing in a non-array value lead to a misleading 'module not found' error. Refs: https://github.com/nodejs/node/issues/27583 PR-URL: https://github.com/nodejs/node/pull/27613 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tls: fix createSecureContext() cipher list filterSam Roberts2019-05-102-1/+12
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27614 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* tls: add missing 'new'cjihrig2019-05-101-1/+1
| | | | | | | | | | | | ERR_INVALID_OPT_VALUE cannot be constructed without new. PR-URL: https://github.com/nodejs/node/pull/27614 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* deps: patch V8 to 7.4.288.27Matheus Marchini2019-05-1024-102/+349
| | | | | | | | | | Refs: https://github.com/v8/v8/compare/7.4.288.21...7.4.288.27 PR-URL: https://github.com/nodejs/node/pull/27615 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: fix test-linux-perf flakinessMatheus Marchini2019-05-101-1/+1
| | | | | | | | | | | | | The new V8 seems to be optimizing the functions we use in this test faster than before. Increasing the sampling frequency for Linux perf fixes the issue. PR-URL: https://github.com/nodejs/node/pull/27615 Refs: https://github.com/v8/v8/compare/7.4.288.21...7.4.288.27 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: remove unneeded `--expose-internals`Rich Trott2019-05-101-2/+0
| | | | | | | | | | | | | test/wpt/test-timers.js does not appear to need the `--expose-internals` flag. Remove it. PR-URL: https://github.com/nodejs/node/pull/27608 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
View Lorry Controller Status