summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2021-08-25, Version 16.8.0 (Current)v16.8.0v16.8.0-proposalMichaël Zasso2021-08-256-9/+56
| | | | | | | | | | | | | | Notable changes: doc: * deprecate type coercion for `dns.lookup` options (Antoine du Hamel) https://github.com/nodejs/node/pull/38906 stream: * (SEMVER-MINOR) add `stream.Duplex.from` utility (Robert Nagy) https://github.com/nodejs/node/pull/39519 * (SEMVER-MINOR) add `isDisturbed` helper (Robert Nagy) https://github.com/nodejs/node/pull/39628 util: * (SEMVER-MINOR) expose `toUSVString` (Robert Nagy) https://github.com/nodejs/node/pull/39814 PR-URL: https://github.com/nodejs/node/pull/39875
* tools: update workflow to open a pull requestRich Trott2021-08-251-0/+11
| | | | | | | | | | Now that find-inactive-collaborators.mjs automates the README.md changes to move the inactive collaborators to the emeriti section, update the GitHub Actions workflow to open a pull request. PR-URL: https://github.com/nodejs/node/pull/39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: use find-inactive-collaborators to modify README.mdRich Trott2021-08-252-2/+92
| | | | | | | | | Update find-inactive-collaborators to move inactive collaborators to the emeriti section of README.md. PR-URL: https://github.com/nodejs/node/pull/39825 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: fix update authors commitMestery2021-08-241-0/+1
| | | | | | | | | | | Refs: https://github.com/nodejs/node/pull/39855#issuecomment-904387651 PR-URL: https://github.com/nodejs/node/pull/39858 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* doc: add duplicate CVE check in sec. release docDaniel Bevenius2021-08-241-0/+3
| | | | | | | | | | | | | | | | | | This commit adds a note about only creating a CVE for Node.js vulnerabilities. The motivation for this is a recent HackerOne report where I created a CVE for a c-ares issue. This CVE should have been created by the c-ares project, and it was later, but we never updated our HackerOne report to use their CVE number. Hopefully this extra note in the release doc will help us check for this situaion and avoid this in the future. PR-URL: https://github.com/nodejs/node/pull/39845 Refs: https://hackerone.com/reports/1178337 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add authors.ymlTierney Cyren2021-08-241-0/+21
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/35831 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* doc: improve description of the triagers teamMichaël Zasso2021-08-241-5/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39833 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: V8: cherry-pick 00bb1a77c03eDarshan Sen2021-08-243-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [date] Fix Date#getMinutes() test failures After building V8 using Clang (./out/x64.release/v8_build_config.json says that "is_clang" is true), I could reproduce the referenced bug report locally. Replacing the getMinutes() calls with getUTCMinutes() calls fixed the test failure. Signed-off-by: Darshan Sen <raisinten@gmail.com> Bug: v8:11200 Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362 Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#76367} Refs: https://github.com/v8/v8/commit/00bb1a77c03ec951a5def21c64bee38cd855be7b Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39829 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: update instructions for ccMichael Dawson2021-08-241-1/+6
| | | | | | | | | | | - update intructions on adding cc for email to nodejs-sec mailing list as UI does not allow it to be done directly. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/39674 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* deps: upgrade npm to 7.21.0Myles Borins2021-08-23470-5448/+8339
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39813 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
* stream: duplexifyRobert Nagy2021-08-239-17/+655
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39519 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <ckbenjamingr@gmail.com> Backport-PR-URL: https://github.com/nodejs/node/pull/39820
* stream: add isDisturbed helperRobert Nagy2021-08-238-11/+171
| | | | | | | | | | | | Adds a helper util used to determine whether a stream has been disturbed (read or cancelled). Refs: https://github.com/nodejs/node/issues/39627 PR-URL: https://github.com/nodejs/node/pull/39628 Backport-PR-URL: https://github.com/nodejs/node/pull/39819 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* src: return Maybe<bool> from InitializeContextRuntime()Darshan Sen2021-08-234-36/+95
| | | | | | | | | Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39695 Backport-PR-URL: https://github.com/nodejs/node/pull/39834 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: update gyp-next to v0.9.5Jiawen Geng2021-08-236-34/+67
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39818 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: move util.toUSVString() outside of deprecated groupLuigi Pinca2021-08-231-12/+11
| | | | | | | | | Refs: https://github.com/nodejs/node/pull/39814/files#r693445849 PR-URL: https://github.com/nodejs/node/pull/39840 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* util: expose toUSVStringRobert Nagy2021-08-225-16/+41
| | | | | | | | | Expose toUSVString so it can be used by user libraries. PR-URL: https://github.com/nodejs/node/pull/39814 Refs: https://github.com/nodejs/undici/pull/986 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: fix markdown lintingRich Trott2021-08-227-38153/+30804
| | | | | | | | | | | | | | This updates remark-preset-lint-node to 3.0.1, which actually works unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually linting!) It also updates rollup and the rollup config. So this uses the latest everything as of this writing. PR-URL: https://github.com/nodejs/node/pull/39832 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* fs: combine require() and destructurecjihrig2021-08-221-4/+2
| | | | | | | | | | | | This commit combines two require() calls and subsequent destructuring operations. PR-URL: https://github.com/nodejs/node/pull/39806 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: update markdown linter dependencies and move to ESMAntoine du Hamel2021-08-224-4406/+4056
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39801 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: call overload ctor from the original ctorDarshan Sen2021-08-221-7/+2
| | | | | | | | | | | | Call the new constructor overload from the original constructor to reduce code duplication. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39768 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* src: add a constructor overload for CallbackScopeDarshan Sen2021-08-224-4/+15
| | | | | | | | | | | | | | This overload accepts the current Environment* as an argument, unlike the other constructor, which accepts an Isolate*. This is useful because we can pass the current Environment* directly instead of recomputing it from the Isolate* inside the constructor. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/39768 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* meta: add gyp as owner of gyp files and tools/gypmary marchini2021-08-221-0/+6
| | | | | | | | | | Co-authored-by: Jiawen Geng <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34847 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: update rollup to latest version in markdown linterRich Trott2021-08-223-24093/+4366
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39797 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* policy: canonicalize before resolving specifiersBradley Farias2021-08-2212-351/+772
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37863 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* repl: fix tla function hoistingDon Jayamanne2021-08-222-3/+7
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39745 Fixes: https://github.com/nodejs/node/issues/39744 Reviewed-By: Guy Bedford <guybedford@gmail.com>
* doc: deprecate type coercion for `dns.lookup` optionsAntoine du Hamel2021-08-221-3/+5
| | | | | | PR-URL: https://github.com/nodejs/node/pull/38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* doc: deprecate using non-boolean values in the `verbatim` optionAntoine du Hamel2021-08-221-0/+15
| | | | | | PR-URL: https://github.com/nodejs/node/pull/38906 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* build: add option to hide console windowCheng Zhao2021-08-225-1/+16
| | | | | | | | | | | | Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW property when spawning processes, which is useful for GUI programs that do not want to show console windows when running terminal commands. PR-URL: https://github.com/nodejs/node/pull/39712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fix malformed changelog entriesRich Trott2021-08-221-141/+97
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39791 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* doc: fix lint errors in packages.mdRich Trott2021-08-221-2/+2
| | | | | | | | | | | Code samples that use CJS-only syntax need to use the cjs markdown identifiers. PR-URL: https://github.com/nodejs/node/pull/39792 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
* tools: update markdown lint dependenciesRich Trott2021-08-223-22182/+25097
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/39770 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: add example of self-reference in scoped packagesJesús Leganés-Combarro 'piranna2021-08-221-0/+26
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/37630 Fixes: https://github.com/nodejs/node/issues/37618 Refs: https://github.com/nodejs/node/issues/37618#issuecomment-791888177 Co-authored-by: Michaël Zasso <targos@protonmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
* doc: add himadriganguly as a triagerHimadri Ganguly2021-08-221-0/+2
| | | | | | | | | | | | I would like to apply for the role of a triager in this project. My motivation to become a triager is to help manage issues, as well as learn deeper concepts of Node.js, and eventually become a collaborator! I hereby declare that I have read and understood the Code of Conduct and will adhere to that. PR-URL: https://github.com/nodejs/node/pull/39757 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* Working on v16.7.1Danielle Adams2021-08-171-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/39782
* 2021-08-17, Version 16.7.0 (Current)v16.7.0Danielle Adams2021-08-1614-40/+171
| | | | | | | | | Notable changes: * fs: * experimental: add recursive cp method (Benjamin Coe) https://github.com/nodejs/node/pull/39372 PR-URL: https://github.com/nodejs/node/pull/39782
* worker: add brand checks for detached properties/methodsJames M Snell2021-08-162-1/+56
| | | | | | | | | | | | | Add proper brand-checking for detached property and method accesses. Also adds a note about non-standard APIs and makes the standard accessors enumerable. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39763 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* doc: correct cjs code to match mjs codeRaz Luvaton2021-08-161-2/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39509 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
* doc: fix typo in hmac.paramNames defaultJustin2021-08-161-1/+1
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/39766 Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* policy: fix integrity when DEFAULT_ENCODING is setTobias Nießen2021-08-166-2/+60
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39750 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: use simplfied validatorvoltrexmaster2021-08-161-2/+2
| | | | | | | | | | The validators test should use the simplified `validateArray()` validator. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* dgram: use simplified validatorVoltrex2021-08-161-2/+2
| | | | | | | | | | The `dgram` lib module should use the simplified `validatePort()` validator. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* lib: simplify validatorsVoltrex2021-08-161-4/+3
| | | | | | | | | | | Some of the validators can be simplified by removing unnecessary object parameters and using validators in another validators to keep consistency. PR-URL: https://github.com/nodejs/node/pull/39753 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* tools: bump remark-preset-lint-node to 3.0.0Rich Trott2021-08-163-3068/+38493
| | | | | | PR-URL: https://github.com/nodejs/node/pull/39755 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
* buffer: add endings option, remove Node.js specific encoding optionJames M Snell2021-08-163-24/+64
| | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39708 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* stream: ensure text() stream consumer flushes correctlyJames M Snell2021-08-162-0/+17
| | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* src: fix TextDecoder final flush size calculationJames M Snell2021-08-161-2/+15
| | | | | | | | | | | Flushing a TextDecoder with a zero-sized input and pending incomplete characters was failing when fatal: false. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39737 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* tools: update path-parse in markdown linter package-lock fileRich Trott2021-08-162-6/+6
| | | | | | | | Refs: https://github.com/advisories/GHSA-hj48-42vr-x3v9 PR-URL: https://github.com/nodejs/node/pull/39729 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* lib: cleanup validationVoltrex2021-08-161-10/+3
| | | | | | | | | | Used the `validateInteger()` validator to cleanup validation and keep consistency. PR-URL: https://github.com/nodejs/node/pull/39652 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* lib: cleanup instance validationVoltrex2021-08-161-24/+23
| | | | | | | | | Cleaned up the `URLSearchParams`'s `this` validation to increase readability by moving them to an extra helper function. PR-URL: https://github.com/nodejs/node/pull/39656 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* lib: use helper for readabilityVoltrex2021-08-161-24/+13
| | | | | | | | | | Used an extra `checkReusedHandle()` helper function to increase readability. PR-URL: https://github.com/nodejs/node/pull/39649 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>
View Lorry Controller Status