summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* test: allow SIGBUS in signal-handler abort testv16.x-stagingMichaël Zasso2023-05-051-3/+6
| | | | | | | | | | | FreeBSD uses SIGBUS after update to v12.4. Refs: https://github.com/nodejs/build/issues/3134 PR-URL: https://github.com/nodejs/node/pull/47851 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* Working on v16.20.1v16.xBeth Griggs2023-03-291-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/47272
* 2023-03-29, Version 16.20.0 'Gallium' (LTS)v16.20.0Beth Griggs2023-03-273-4/+44
| | | | | | | | | | | | | | | | | | Notable changes: - deps: - update undici to 5.20.0 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/46711 - update c-ares to 1.19.0 (Michaël Zasso) https://github.com/nodejs/node/pull/46415 - upgrade npm to 8.19.4 (npm team) https://github.com/nodejs/node/pull/46677 - update corepack to 0.17.0 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/46842 - (SEMVER-MINOR) src: add support for externally shared js builtins (Michael Dawson) [https://github.com/nodejs/node/pull/44376] PR-URL: https://github.com/nodejs/node/pull/47272
* test: fix test-net-connect-reset-until-connectedVita Batrla2023-03-272-5/+10
| | | | | | | Fixes: https://github.com/nodejs/node/issues/43446 PR-URL: https://github.com/nodejs/node/pull/46781 Reviewed-By: theanarkh <theratliter@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* Revert "src: let http2 streams end after session close"Rich Trott2023-03-272-13/+7
| | | | | | | | | | | | | This reverts commit dee882e94f4caa4e1cd608013f90f6a14629403f. Moved the test that demonstrated what this commit was fixing to the `known_issues` folder. Fixes: https://github.com/nodejs/node/issues/46234 PR-URL: https://github.com/nodejs/node/pull/46721 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: update undici to 5.20.0Node.js GitHub Bot2023-03-2717-59/+94
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/46711 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
* deps: V8: cherry-pick 90be99fab31cMichaël Zasso2023-03-275-1/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [intl] Revert date formatting behavior change from ICU 72 Replace U+202F with U+0020 after formatting date. This lets websites continue to work without any changes. This matches Firefox behavior, according to https://bugzilla.mozilla.org/show_bug.cgi?id=1806042#c17. Bug: chromium:1414292, chromium:1401829, chromium:1392814 Change-Id: I7c2b58414d0890f8705e737f903403dc54e5fe57 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4237675 Commit-Queue: Adam Klein <adamk@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#85757} Refs: https://github.com/v8/v8/commit/90be99fab31c8299568e4114be1f0abd3741d615 PR-URL: https://github.com/nodejs/node/pull/46646 Refs: https://github.com/nodejs/node/issues/46123 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* deps: update c-ares to 1.19.0Michaël Zasso2023-03-2791-3659/+4381
| | | | | | | | | | Refs: https://c-ares.org/changelog.html#1_19_0 PR-URL: https://github.com/nodejs/node/pull/46415 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* crypto: avoid hang when no algorithm availableRichard Lau2023-03-273-0/+64
| | | | | | | | | | Avoid an endless loop if no algorithm is available to seed the cryptographically secure pseudorandom number generator (CSPRNG). Co-authored-by: Anna Henningsen <anna@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/46237 Fixes: https://github.com/nodejs/node/issues/46200 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* crypto: ensure auth tag set for chacha20-poly1305Ben Noordhuis2023-03-272-0/+39
| | | | | | | | | | | Because OpenSSL v1.x doesn't do that by itself (OpenSSL v3.x does.) Fixes: https://github.com/nodejs/node/issues/45874 PR-URL: https://github.com/nodejs/node/pull/46185 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* module: require.resolve.paths returns null with node schemaMURAKAMI Masahiko2023-03-272-2/+11
| | | | | | | | | | | require.resolve.paths should returns null with builtin module. when builtin module without `node:` schema, `paths` returns null. But, it don't return null when builtin module with `node:` schema. Fixes: https://github.com/nodejs/node/issues/45001 PR-URL: https://github.com/nodejs/node/pull/45147 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* test: skip test depending on `overlapped-checker` when not availableAntoine du Hamel2023-03-271-0/+4
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45015 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* tools: make `utils.SearchFiles` deterministicBruno Pitrus2023-03-271-1/+1
| | | | | | | | | | | | | | | `glob.glob` on Linux returns files in the order returned by the filesystem driver, and the output from this function is stuffed by the Electron build process straight into the `config.gypi` header, causing non-reproducible builds. See this log for an example of the nondeterminism: https://rb.zq1.de/compare.factory-20220901/diffs/nodejs-electron-compare.out PR-URL: https://github.com/nodejs/node/pull/44496 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com>
* deps: V8: cherry-pick c2792e58035fJiawen Geng2023-03-274-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [base] Fix build with gcc-13 See https://gcc.gnu.org/gcc-13/porting_to.html#header-dep-changes. Also see Gentoo Linux bug report: https://bugs.gentoo.org/865981 Change-Id: I421f396b02ba37e12ee70048ee33e034f8113566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3934140 Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Simon Zünd <szuend@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#83587} Refs: https://github.com/v8/v8/commit/c2792e58035fcbaa16d0cb70998852fbeb5df4cc PR-URL: https://github.com/nodejs/node/pull/44961 Fixes: https://github.com/nodejs/node/issues/43642 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: remove cjs loader from stack tracesGeoffrey Booth2023-03-2747-216/+50
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44197 Backport-PR-URL: https://github.com/nodejs/node/pull/46535 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* test: fix WPT title when no META title is presentFilip Skokan2023-03-231-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46804 Backport-PR-URL: https://github.com/nodejs/node/pull/46768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* test: fix default WPT titlesFilip Skokan2023-03-232-2/+5
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46778 Backport-PR-URL: https://github.com/nodejs/node/pull/46768 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* test: add WPTRunner support for variants and generating WPT reportsFilip Skokan2023-03-232-57/+207
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46498 Backport-PR-URL: https://github.com/nodejs/node/pull/46768 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* deps: upgrade npm to 8.19.4npm CLI robot2023-03-2394-107/+101
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/46677 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
* src: add support for externally shared js builtinsMichael Dawson2023-03-236-3/+229
| | | | | | | | | | | | | | | | | | Refs: https://github.com/nodejs/node/issues/44000 - add infra to support externally shared js builtins in support of distos that want to externalize deps that include JS/WASM instead of native code - add support for externalizing - cjs_module_lexer/lexer - cjs_module_lexer/dist/lexer - undici/undici Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/44376 Backport-PR-URL: https://github.com/nodejs/node/pull/45867 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* deps: update corepack to 0.17.0Node.js GitHub Bot2023-03-233-4/+23
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46842 Backport-PR-URL: https://github.com/nodejs/node/pull/45644 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* deps: update corepack to 0.16.0Node.js GitHub Bot2023-03-235-57840/+43838
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46710 Backport-PR-URL: https://github.com/nodejs/node/pull/45644 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
* deps: update corepack to 0.15.3Node.js GitHub Bot2023-03-233-3/+10
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/46037 Backport-PR-URL: https://github.com/nodejs/node/pull/45644 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* deps: update corepack to 0.15.2Node.js GitHub Bot2023-03-233-3/+10
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45635 Backport-PR-URL: https://github.com/nodejs/node/pull/45644 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: mark test-crypto-key-objects flaky on LinuxRichard Lau2023-02-181-0/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/46684 Refs: https://github.com/nodejs/node/issues/46683 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
* Working on v16.19.2Richard Lau2023-02-161-2/+2
| | | | PR-URL: https://github.com/nodejs-private/node-private/pull/390
* 2023-02-16, Version 16.19.1 'Gallium' (LTS)v16.19.1Richard Lau2023-02-153-2/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a security release. Notable changes: The following CVEs are fixed in this release: - CVE-2023-23918: Node.js Permissions policies can be bypassed via process.mainModule (High) - CVE-2023-23919: Node.js OpenSSL error handling issues in nodejs crypto library (Medium) - CVE-2023-23936: Fetch API in Node.js did not protect against CRLF injection in host headers (Medium) - CVE-2023-24807: Regular Expression Denial of Service in Headers in Node.js fetch API (Low) - CVE-2023-23920: Node.js insecure loading of ICU data through ICU_DATA environment variable (Low) Fixed by an update to undici: - CVE-2023-23936: Fetch API in Node.js did not protect against CRLF injection in host headers (Medium) See https://github.com/nodejs/undici/security/advisories/GHSA-5r9g-qh6m-jxff for more information. - CVE-2023-24807: Regular Expression Denial of Service in Headers in Node.js fetch API (Low) See https://github.com/nodejs/undici/security/advisories/GHSA-r6ch-mqf9-qc9w for more information. - OpenSSL 1.1.1t PR-URL: https://github.com/nodejs-private/node-private/pull/390
* lib: makeRequireFunction patch when experimental policyRafaelGSS2023-02-159-18/+38
| | | | | | | | | | Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/372 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1747642 CVE-ID: CVE-2023-23918 PR-URL: https://github.com/nodejs-private/node-private/pull/358 Reviewed-by: Bradley Farias <bradley.meck@gmail.com> Reviewed-by: Michael Dawson <midawson@redhat.com>
* policy: makeRequireFunction on mainModule.requireRafaelGSS2023-02-1517-49/+151
| | | | | | | | | | Co-authored-by: Bradley Farias <bradley.meck@gmail.com> Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/372 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1747642 CVE-ID: CVE-2023-23918 PR-URL: https://github.com/nodejs-private/node-private/pull/358 Reviewed-by: Bradley Farias <bradley.meck@gmail.com> Reviewed-by: Michael Dawson <midawson@redhat.com>
* deps: update undici to v5.19.1Matteo Collina2023-02-1577-5225/+5925
| | | | | | | | | | | | Signed-off-by: Matteo Collina <hello@matteocollina.com> CVE-ID: CVE-2023-23936, CVE-2023-24807 PR-URL: https://github.com/nodejs-private/node-private/pull/388 Refs: https://github.com/nodejs/undici/security/advisories/GHSA-5r9g-qh6m-jxff Refs: https://github.com/nodejs/undici/security/advisories/GHSA-r6ch-mqf9-qc9w Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1820955 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1784449 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* crypto: clear OpenSSL error on invalid ca certRafaelGSS2023-02-142-1/+49
| | | | | | | | | Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> CVE-ID: CVE-2023-23919 PR-URL: https://github.com/nodejs-private/node-private/pull/375 Refs: https://hackerone.com/bugs?report_id=1808596 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Richard Lau <rlau@redhat.com>
* crypto: clear OpenSSL error queue after calling X509_check_private_key()Filip Skokan2023-02-142-4/+15
| | | | | | | | | | Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375 CVE-ID: CVE-2023-23919 Fixes: https://github.com/nodejs/node/issues/45485 PR-URL: https://github.com/nodejs/node/pull/45495 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* crypto: clear OpenSSL error queue after calling X509_verify()Takuro Sato2023-02-142-0/+7
| | | | | | | | | | | | | Prior to this commit, functions accessing the OpenSSL error queue did not work properly after x509.verify() returned false. Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/375 CVE-ID: CVE-2023-23919 PR-URL: https://github.com/nodejs/node/pull/45377 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1808596 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
* build: build ICU with ICU_NO_USER_DATA_OVERRIDERafaelGSS2023-02-141-0/+3
| | | | | | | | | | Backport-PR-URL: https://github.com/nodejs-private/node-private/pull/378 CVE-ID: CVE-2023-23920 PR-URL: https://github.com/nodejs-private/node-private/pull/374 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* deps: cherry-pick Windows ARM64 fix for opensslRichard Lau2023-02-131-1/+23
| | | | | | | | | | | | | | | | Original commit message: rsa: add msvc intrinsic for non x64 platforms _umul128() is x86_64 (x64) only, while __umulh() works everywhere, but doesn't generate optimal code on x64 PR-URL: https://github.com/nodejs/node/pull/46568 Refs: https://github.com/openssl/openssl/pull/20244 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* deps: update archs files for quictls/openssl-1.1.1t+quicRafaelGSS2023-02-13283-267/+1090
| | | | | | | | | | | | | | | After an OpenSSL source update, all the config files need to be regenerated and committed by: $ make -C deps/openssl/config $ git add deps/openssl/config/archs $ git add deps/openssl/openssl $ git commit PR-URL: https://github.com/nodejs/node/pull/46568 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* deps: upgrade openssl sources to OpenSSL_1_1_1t+quicRafaelGSS2023-02-1353-49387/+1547
| | | | | | | | | | | | | | | | | | | This updates all sources in deps/openssl/openssl by: $ git clone https://github.com/quictls/openssl $ cd openssl $ git checkout OpenSSL_1_1_1t+quic $ cd ../node/deps/openssl $ rm -rf openssl $ cp -R ../openssl openssl $ rm -rf openssl/.git* openssl/.travis* $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/46568 Refs: https://mta.openssl.org/pipermail/openssl-announce/2023-February/000251.html Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* test: avoid left behind child processesRichard Lau2023-01-221-3/+3
| | | | | | | | | | | | | | | | | Extend the Linux logic to all POSIX platforms in test-child-process-exec-abortcontroller-promisified. PR-URL: https://github.com/nodejs/node/pull/46276 Fixes: https://github.com/nodejs/build/issues/3154 Refs: https://github.com/nodejs/node/issues/37518 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: clarify release notes for Node.js 16.19.0Richard Lau2022-12-211-8/+7
| | | | | | | | Refs: https://github.com/nodejs/node/pull/45791 PR-URL: https://github.com/nodejs/node/pull/45846 Refs: https://github.com/nodejs/nodejs.org/pull/4972 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Working on v16.19.1Richard Lau2022-12-131-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/45791
* 2022-12-13, Version 16.19.0 'Gallium' (LTS)v16.19.0Richard Lau2022-12-087-11/+123
| | | | | | | | | | | | | | Notable changes: - OpenSSL 1.1.1s - Root certificates updated to NSS 3.85 - Time zone update to 2022f - add dgram send queue info - upgrade npm to 8.19.3 - add `--watch` - add default value option to parsearg PR-URL: https://github.com/nodejs/node/pull/45791
* src: disambiguate terms used to refer to builtins and addonsJoyee Cheung2022-12-0848-295/+297
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The term "native module" dates back to some of the oldest code in the code base. Within the context of Node.js core it usually refers to modules that are native to Node.js (e.g. fs, http), but it can cause confusion for people who don't work on this part of the code base, as "native module" can also refer to native addons - which is even the case in some of the API docs and error messages. This patch tries to make the usage of these terms more consistent. Now within the context of Node.js core: - JavaScript scripts that are built-in to Node.js are now referred to as "built-in(s)". If they are available as modules, they can also be referred to as "built-in module(s)". - Dynamically-linked shared objects that are loaded into the Node.js processes are referred to as "addons". We will try to avoid using the term "native modules" because it could be ambiguous. Changes in this patch: File names: - node_native_module.h -> node_builtins.h, - node_native_module.cc -> node_builtins.cc C++ binding names: - `native_module` -> `builtins` `node::Environment`: - `native_modules_without_cache` -> `builtins_without_cache` - `native_modules_with_cache` -> `builtins_with_cache` - `native_modules_in_snapshot` -> `builtins_in_cache` - `native_module_require` -> `builtin_module_require` `node::EnvSerializeInfo`: - `native_modules` -> `builtins `node::native_module::NativeModuleLoader`: - `native_module` namespace -> `builtins` namespace - `NativeModuleLoader` -> `BuiltinLoader` - `NativeModuleRecordMap` -> `BuiltinSourceMap` - `NativeModuleCacheMap` -> `BuiltinCodeCacheMap` - `ModuleIds` -> `BuiltinIds` - `ModuleCategories` -> `BuiltinCategories` - `LoadBuiltinModuleSource` -> `LoadBuiltinSource` `loader.js`: - `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in `process.moduleLoadList` is kept for compatibility) And other clarifications in the documentation and comments. PR-URL: https://github.com/nodejs/node/pull/44135 Backport-PR-URL: https://github.com/nodejs/node/pull/45663 Fixes: https://github.com/nodejs/node/issues/44036 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Jan Krems <jan.krems@gmail.com>
* src: let http2 streams end after session closeSantiago Gimeno2022-12-082-0/+60
| | | | | | | | | | | | | | | After the stream has been marked as closed by the nghttp2 stack, there might be still pending data to be sent: trailing headers is an example of this. In that case, avoid reentering the nghttp2 stack synchronously to allow the data to be written before actually closing the stream. Fixes: https://github.com/nodejs/node/issues/42713 PR-URL: https://github.com/nodejs/node/pull/45153 Backport-PR-URL: https://github.com/nodejs/node/pull/45660 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* test: add test to validate changelogs for releasesRichard Lau2022-12-071-0/+89
| | | | | | | | Add a new test to check that the changelog files have been correctly updated for releases. PR-URL: https://github.com/nodejs/node/pull/45325 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
* crypto: update root certificatesLuigi Pinca2022-12-071-189/+474
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update the list of root certificates in src/node_root_certs.h with tools/mk-ca-bundle.pl. Certificates added: - Autoridad de Certificacion Firmaprofesional CIF A62634068 - Certainly Root E1 - Certainly Root R1 - D-TRUST BR Root CA 1 2020 - D-TRUST EV Root CA 1 2020 - DigiCert TLS ECC P384 Root G5 - DigiCert TLS RSA4096 Root G5 - E-Tugra Global Root CA ECC v3 - E-Tugra Global Root CA RSA v3 - HiPKI Root CA - G1 - ISRG Root X2 - Security Communication ECC RootCA1 - Security Communication RootCA3 - Telia Root CA v2 - vTrus ECC Root CA - vTrus Root CA Certificates removed: - Cybertrust Global Root - DST Root CA X3 - GlobalSign Root CA - R2 - Hellenic Academic and Research Institutions RootCA 2011 PR-URL: https://github.com/nodejs/node/pull/45490 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* tools: update certdata.txtLuigi Pinca2022-12-071-1861/+3682
| | | | | | | | | | | | | | | | This is the certdata.txt[0] from NSS 3.85, released on 2022-11-10. This is the version of NSS that will ship in Firefox 108 on 2022-12-13. [0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_85_RTM/lib/ckfw/builtins/certdata.txt PR-URL: https://github.com/nodejs/node/pull/45490 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* test: mark test-watch-mode* as flaky on all platformsPierrick Bouvier2022-12-071-0/+3
| | | | | | | | | | | | | | | | | | | This was confirmed flaky on those platforms: - Windows x64 - Windows on Arm - Linux - Freebsd Tests randomly fail because of bad order in messages expected, which seems related to threads scheduling at execution. PR-URL: https://github.com/nodejs/node/pull/45049 Backport-PR-URL: https://github.com/nodejs/node/pull/44873 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* cluster: use inspector utilsMoshe Atlow2022-12-072-36/+20
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44592 Backport-PR-URL: https://github.com/nodejs/node/pull/44873 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: fix test-runner-inspectMoshe Atlow2022-12-071-28/+13
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/44620 Backport-PR-URL: https://github.com/nodejs/node/pull/44873 Fixes: https://github.com/nodejs/node/issues/44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test_runner: support using `--inspect` with `--test`Moshe Atlow2022-12-0713-23/+391
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/44520 Backport-PR-URL: https://github.com/nodejs/node/pull/44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
View Lorry Controller Status