summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* test: fix test-watch-modeStefan Stojanovic2023-01-041-4/+16
| | | | | | | Refs: https://github.com/nodejs/node/issues/44898 PR-URL: https://github.com/nodejs/node/pull/45585 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: fix test-watch-mode-inspectStefan Stojanovic2023-01-041-14/+22
| | | | | | | Refs: https://github.com/nodejs/node/issues/44898 PR-URL: https://github.com/nodejs/node/pull/45586 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* lib: add missing type of removeEventListener in questionDeokjin Kim2023-01-042-1/+19
| | | | | | | | removeEventListener of signal is not working because event type is missed. PR-URL: https://github.com/nodejs/node/pull/45676 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: move streaming instruc to doc/contributingMichael Dawson2023-01-045-0/+117
| | | | | | | | | | | - make streaming instructions more discoverable by moving them from the TSC repo to doc/contributing - upate the instructions to reflect current practice Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/45582 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* meta: update AUTHORS info for nstepienNicolas Stepien2023-01-042-1/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45692 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: add Rafael to the tscMichael Dawson2023-01-041-0/+2
| | | | | | | | | | Refs: https://github.com/nodejs/TSC/issues/1308 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/45691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* deps: update undici to 5.13.0Node.js GitHub Bot2023-01-0442-1341/+1080
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45634 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
* doc: add missing line in debuggerDeokjin Kim2023-01-041-1/+4
| | | | | | | | Output of "node inspect" missed "connecting to..." line from time to time. So added it. PR-URL: https://github.com/nodejs/node/pull/45632 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: use `enum class` instead of `enum` in node_i18nDeokjin Kim2023-01-042-10/+10
| | | | | | | | | | "enum class" has more advantages than "enum" because it's strongly typed and scoped. Refs: https://isocpp.org/wiki/faq/cpp11-language-types#enum-class PR-URL: https://github.com/nodejs/node/pull/45646 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* diagnostics_channel: fix diagnostics channel memory leaktheanarkh2023-01-044-0/+37
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45633 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* doc: fix actual result of example is different in streamDeokjin Kim2023-01-041-1/+1
| | | | | | | | | Error message of JSON.parse may be changed with current node version. For reference, actual result is same with previous node version(v16.18.1). PR-URL: https://github.com/nodejs/node/pull/45619 Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
* doc: add `options` parameter to eventTarget.removeEventListenerDeokjin Kim2023-01-041-1/+1
| | | | | | | | options parameter is available for eventTarget.removeEventListener, but it's not described. PR-URL: https://github.com/nodejs/node/pull/45667 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: update lint-md-dependencies to rollup@3.4.0Node.js GitHub Bot2023-01-043-48/+52
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45638 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* tools: update doc to highlight.js@11.7.0Node.js GitHub Bot2023-01-042-116/+90
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45636 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* doc: define "react-native" community conditionAlex Hunt2023-01-041-0/+3
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45367 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: fix typos in test/parallelDeokjin Kim2023-01-042-2/+2
| | | | | | | | | | | | | Fix typos in parallel tests. PR-URL: https://github.com/nodejs/node/pull/45583 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
* test_runner: add getter and setter to MockTrackerMURAKAMI Masahiko2023-01-043-0/+160
| | | | | | | | | | | | | This commit allows tests in test runner to use the `getter` and `setter` methods as "syntax sugar" for `MockTracker.method` with the `options.getter` or `options.setter` set to true in the options. Refs: https://github.com/nodejs/node/pull/45326#discussion_r1014727289 PR-URL: https://github.com/nodejs/node/pull/45506 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* doc: move os.machine() docs to sorted positionColin Ihrig2023-01-041-16/+16
| | | | | | | | | | This commit moves the os.machine() docs so that the API list is sorted. PR-URL: https://github.com/nodejs/node/pull/45647 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* crypto: refactor ArrayBuffer to bigint conversion utilsAntoine du Hamel2023-01-043-4/+35
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45567 Refs: https://github.com/nodejs/performance/issues/16 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: update corepack to 0.15.2Node.js GitHub Bot2023-01-043-3/+10
| | | | | PR-URL: https://github.com/nodejs/node/pull/45635 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* buffer: make decodeUTF8 params looseYagiz Nizipli2023-01-041-1/+2
| | | | | PR-URL: https://github.com/nodejs/node/pull/45610 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* meta: update AUTHORSNode.js GitHub Bot2023-01-041-0/+6
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45637 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* stream: use structuredClone instead of v8Yagiz Nizipli2023-01-041-7/+5
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: use console.error for error case in fs, https, net and processDeokjin Kim2023-01-044-15/+15
| | | | | | | | | | | | console.error is more suitable than console.log for error case. PR-URL: https://github.com/nodejs/node/pull/45606 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>
* crypto: refactor verify acceptable key usage functionsFilip Skokan2023-01-043-66/+37
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: fix ECDH webcrypto public CryptoKey usagesFilip Skokan2023-01-044-17/+24
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: validate CFRG webcrypto JWK import "d" and "x" are a pairFilip Skokan2023-01-042-41/+17
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: use DataError for CFRG webcrypto raw and jwk import key checksFilip Skokan2023-01-042-39/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: use DataError for webcrypto keyData import failuresFilip Skokan2023-01-044-71/+67
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: fix X25519 and X448 webcrypto public CryptoKey usagesFilip Skokan2023-01-045-33/+24
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: ensure "x" is present when importing private CFRG webcrypto keysFilip Skokan2023-01-042-24/+4
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* test,crypto: update WebCryptoAPI WPTFilip Skokan2023-01-0413-30/+847
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45569 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* repl: do not define `wasi` on global with no flagKohei Ueno2023-01-042-1/+17
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/45595 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add link to doc with social processesMichael Dawson2023-01-041-0/+5
| | | | | | | | Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/45584 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* deps: update nghttp2 to 1.51.0Yagiz Nizipli2023-01-0427-101/+2190
| | | | | PR-URL: https://github.com/nodejs/node/pull/45537 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* test_runner: remove stdout and stderr from errorColin Ihrig2023-01-041-8/+1
| | | | | | | | | | The CLI test runner parses the TAP output from child processes now and displays it. This commit removes a previous workaround for displaying child process stdout and stderr when tests failures occurred. PR-URL: https://github.com/nodejs/node/pull/45592 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
* src: address coverity warning in node_file.ccMichael Dawson2023-01-041-1/+1
| | | | | | | | | | | | | | Address coverity warning that looks like it identifies a potential crash due to using a value after it's been passed into std::move Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/45565 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
* node-api: address coverity warningMichael Dawson2023-01-041-1/+1
| | | | | | | | | | | | | | - address coverity unitialized variable warning Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/45563 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: deprecate use of invalid ports in `url.parse`Antoine du Hamel2023-01-041-0/+16
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45576 Refs: https://github.com/nodejs/node/pull/45526 Co-authored-by: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* doc: clarify changes in readableFlowingKohei Ueno2023-01-041-0/+2
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45554 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* src: use qualified `std::move` call in node_http2Michaël Zasso2023-01-041-1/+5
| | | | | | | | | | | | | | | | | Also iwyu in that file. Closes: https://github.com/nodejs/node/issues/45543 PR-URL: https://github.com/nodejs/node/pull/45555 Fixes: https://github.com/nodejs/node/issues/45543 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
* doc: use console.error for error case in http2Deokjin Kim2023-01-041-3/+3
| | | | | | | | | console.error is more suitable than console.log for error case. PR-URL: https://github.com/nodejs/node/pull/45577 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
* test: add trailing commas in event testsRich Trott2023-01-0410-47/+47
| | | | | | | | | | | As much as I would like to do this everywhere and then modify the lint rule to enforce it, the churn would be too big. However if we're going to have relatively frequent nits for this sort of thing (as we do), I'd prefer we migrate a few files at a time to never actually getting around to doing it. Ref: https://github.com/nodejs/node/pull/45448#pullrequestreview-1179370442 PR-URL: https://github.com/nodejs/node/pull/45466 Reviewed-By: James M Snell <jasnell@gmail.com>
* build: avoid redefined macroMichaël Zasso2023-01-041-1/+0
| | | | | | | | | | | | | | | It's already defined in `common.gypi`. PR-URL: https://github.com/nodejs/node/pull/45544 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* src: avoid unused variables and functionsMichaël Zasso2023-01-043-4/+6
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45542 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
* src: add missing include for `std::all_of`Michaël Zasso2023-01-041-0/+1
| | | | | | | | | | | | This fixes compilation of src/inspector_socket.cc with clang-cl. PR-URL: https://github.com/nodejs/node/pull/45541 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build,deps,src: fix Intel VTune profiling supportShi Lei2023-01-0448-2/+16636
| | | | | | PR-URL: https://github.com/nodejs/node/pull/45248 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* src,node-api: update `napi_is_detached_arraybuffer`Daeyeon Jeong2023-01-041-1/+1
| | | | | | | | | | This gets `napi_is_detached_arraybuffer(..)` to use the new API, `ArrayBuffer::WasDetached`, that looks more straightforward. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/45538 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* tools: update eslint to 8.28.0Node.js GitHub Bot2023-01-0417-284/+123
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45532 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* doc: add version description about fsPromise.constantschlorine2023-01-041-0/+6
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/45556 Refs: https://github.com/nodejs/node/pull/43177 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
View Lorry Controller Status