summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2018-01-13, Version 6.13.0 'Boron' (LTS)v6.13.0v6.13.0-proposalMyles Borins2018-02-1311-22/+182
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 30 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) https://github.com/nodejs/node/pull/12678 * crypto: - expose ECDH class (Bryan English) https://github.com/nodejs/node/pull/8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) https://github.com/nodejs/node/pull/10209 - warn on invalid authentication tag length (Tobias Nießen) https://github.com/nodejs/node/pull/17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) https://github.com/nodejs/node/pull/16835 * dgram: - added socket.setMulticastInterface() (Will Young) https://github.com/nodejs/node/pull/7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) https://github.com/nodejs/node/pull/13005 * lib: - return this from net.Socket.end() (Sam Roberts) https://github.com/nodejs/node/pull/13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) https://github.com/nodejs/node/pull/16386 * net: - return this from getConnections() (Sam Roberts) https://github.com/nodejs/node/pull/13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) https://github.com/nodejs/node/pull/13784 * repl: - improve require() autocompletion (Alexey Orlenko) https://github.com/nodejs/node/pull/14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) https://github.com/nodejs/node/pull/16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) https://github.com/nodejs/node/pull/12087 - add process.ppid (cjihrig) https://github.com/nodejs/node/pull/16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) https://github.com/nodejs/node/pull/12839 * tools, build: - a new macOS installer! (JP Wesselink) https://github.com/nodejs/node/pull/15179 * url: - WHATWG URL api support (James M Snell) https://github.com/nodejs/node/pull/7448 * util: - add %i and %f formatting specifiers (Roman Reiss) https://github.com/nodejs/node/pull/10308 PR-URL: https://github.com/nodejs/node/pull/18342
* test: make test-cli-syntax engine agnosticRich Trott2018-02-131-1/+3
| | | | | | | | | | | | | | | | Do not check the error message if it is generated by the JavaScript engine (V8, ChakraCore, etc.). Do confirm that it is a `SyntaxError`. PR-URL: https://github.com/nodejs/node/pull/16272 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* test: decrease duration of test-cli-syntaxEvan Lucas2018-02-131-20/+27
| | | | | | | | | | | | | | Previously, test/parallel/test-cli-syntax.js was spawning a lot of child processes, but using spawnSync, which made the test run each child process serially. This switches most of the test cases to use exec so that they are asynchronous. Locally, the test went from > 5 seconds to under 2 seconds. PR-URL: https://github.com/nodejs/node/pull/14187 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* crypto: warn on invalid authentication tag lengthTobias Nießen2018-02-122-1/+28
| | | | | | | | | Backport-PR-URL: https://github.com/nodejs/node/pull/18347 PR-URL: https://github.com/nodejs/node/pull/17566 Refs: https://github.com/nodejs/node/issues/17523 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: use valid authentication tag lengthTobias Nießen2018-02-121-1/+1
| | | | | | | | | | | | Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: https://github.com/nodejs/node/pull/18347 PR-URL: https://github.com/nodejs/node/pull/17566 Refs: https://github.com/nodejs/node/issues/17523 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: mark test-inspector-stop-profile-after-done flakyMyles Borins2018-02-121-0/+1
| | | | | | | | | This test is consistently failing and making CI red. PR-URL: https://github.com/nodejs/node/pull/18491 Refs: https://github.com/nodejs/node/issues/16772 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: improve flaky test-listen-fd-ebadf.jsRich Trott2018-02-121-1/+13
| | | | | | | | | | | | Find an invalid file descriptor rather than assuming 42 will be invalid. PR-URL: https://github.com/nodejs/node/pull/17797 Fixes: https://github.com/nodejs/node/issues/17762 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: fix test-tls-server-verify.js on Windows CIRich Trott2018-02-121-3/+2
| | | | | | | | | | | | | The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: https://github.com/nodejs/node/issues/18269 PR-URL: https://github.com/nodejs/node/pull/18382 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* src: dumb down code by removing std::moveAnna Henningsen2018-02-121-6/+8
| | | | | | | | This would require C++11 features that would otherwise not be available on clang + OS X on Node 6.x. PR-URL: https://github.com/nodejs/node/pull/18324 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
* src: use correct OOB check for IPv6 parsingAnna Henningsen2018-02-121-5/+5
| | | | | | | | | | | | | | | `last_piece` pointed to the end of the 8×16 bit array, so `piece_pointer == last_piece` already means that the pointer is not writable any longer. Previously, this still worked most of the time but could result in an out-of-bounds-write. Also, rename `last_piece` to `buffer_end` to avoid this pitfall. Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* src: make url host a proper C++ classAnna Henningsen2018-02-121-122/+147
| | | | | | | | | | | | | | | | - Gives `URLHost` a proper destructor that clears memory depending on the type of the host (This fixes a memory leak) - Hide the host type enums and class layout as implementation details - Make the `Parse` methods members of `URLHost` - Turn `WriteHost` into a `ToString()` method on the `URLHost` class - Verify that at the beginning of a parse attempt, the type is set to “failed” - Remove a lot of `goto`s from the source code 🐢🚀 Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Fixes: https://github.com/nodejs/node/issues/17448 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* src: move url internals into anonymous namespaceAnna Henningsen2018-02-121-59/+58
| | | | | | | | | | This helps because `static` doesn’t work for C++ classes, but refactoring `url_host` into a proper C++ class seems the most reasonable soluation for the memory leak fixed by the next commit. Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* src: minor cleanups to node_url.ccAnna Henningsen2018-02-121-32/+29
| | | | | | | | | | | | | | | | | - Remove pointless pointers - Make `WriteHost` take a const argument so that it’s functionality is clear from the signature - Make `FindLongestZeroSequence` templated to accommodate the constness in `WriteHost` and because using `uint16_t` is an articifial, unnecessary restriction - Remove string copying when no copies are needed - Make `PercentDecode` just return its return value - Make `ParseHost` (string-only version) take its constant argument as a constant reference Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* doc: remove x86 from os.arch() optionsGibson Fahnestock2018-02-122-6/+7
| | | | | | | | | | | | | | | | It is not possible for `process.arch` (which comes from V8's `target_arch`) to be `x86`. Also updates `process.arch` to have the same information. PR-URL: https://github.com/nodejs/node/pull/17899 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* tools: do not override V8's gitignoreYang Guo2018-02-121-0/+3
| | | | | | | | | | | | | The root .gitignore contains "node", which causes all of deps/v8/tools/node to be ignored. That is somewhat inconvenient when updating V8. PR-URL: https://github.com/nodejs/node/pull/18010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* doc: move matthewloring to emeritiRich Trott2018-02-121-2/+2
| | | | | | | | | | | | | | | Matt is not an active collaborator at this time. Moved to the Collaborator Emeriti section. PR-URL: https://github.com/nodejs/node/pull/17998 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matthew Loring <mattloring@google.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* test: fix flaky test-http-pipeline-floodAnatoli Papirovski2018-02-121-2/+2
| | | | | | PR-URL: https://github.com/nodejs/node/pull/17955 Refs: https://github.com/nodejs/node/issues/16317 Reviewed-By: James M Snell <jasnell@gmail.com>
* test: rename regression testsTobias Nießen2018-02-126-8/+34
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17948 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: fix flaky test-pipe-unrefAnatoli Papirovski2018-02-121-2/+2
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17950 Fixes: https://github.com/nodejs/node/issues/16875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: fix crypto test case to use correct encodingTobias Nießen2018-02-121-1/+1
| | | | | | | | | | The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: https://github.com/nodejs/node/pull/17956 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: simplify test-buffer-slice.jsWeijia Wang2018-02-121-69/+44
| | | | | | | | | | | | | Use forEach loop to reduce some redundant codes. PR-URL: https://github.com/nodejs/node/pull/17962 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* benchmark: fix timeout in write-stream-throughputAnatoli Papirovski2018-02-121-4/+4
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17958 Fixes: https://github.com/nodejs/node/issues/17901 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: move joshgav to TSC emeriti listRich Trott2018-02-121-2/+2
| | | | | | | | | | | | | | | | | | Josh is focusing on other technologies these days and has moved to the TSC Emeritus role. He already opened a pull request in the TSC repository to make this change. This makes the same change in the main repository. PR-URL: https://github.com/nodejs/node/pull/17953 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* doc: improve security section of README.mdRich Trott2018-02-121-9/+8
| | | | | | | | | | | | | | | | | | | * Remove fluff text and get to the point: Report security flaws to security@nodejs.org. Please do not disclose security flaws publicly until they have been handled by the security team. * Fix somewhat confusing paragraph that says there are no "hard and fast rules" but then uses _must_ in the context of a "general rule". Easiest solution seems to be to change _must_ to _should_. * Minor style change (_you will_ instead of _you'll_) PR-URL: https://github.com/nodejs/node/pull/17929 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* doc: copy-edit COLLABORATOR_GUIDE.mdRich Trott2018-02-121-17/+16
| | | | | | | | | | | | | | | Apply various style and punctuation fixes. PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: improve alt textRich Trott2018-02-121-1/+1
| | | | | | | | | | | | | | | | | | Current alt text results in "GitHub badge badge". Change to intended use of alt text so that it reads "GitHub First-time contributor badge". (The alt text is supposed to replace the image in the event that the image cannot be rendered.) PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: fix spelling of contributorsRich Trott2018-02-121-2/+2
| | | | | | | | | | | | | | | Change instances of "contributiors" to "contributors". PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: add references to PR communication articlesSalame William2018-02-121-0/+5
| | | | | | | | | | | | | Added some references to PR communication articles in Helpful Ressources inside COLLABORATOR_GUIDE.md PR-URL: https://github.com/nodejs/node/pull/17902 Fixes: https://github.com/nodejs/node/issues/16359 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com>
* gitignore: ignore *.VC.db filesTobias Nießen2018-02-121-0/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17898 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* test: improve to use template stringsreepurnajasti2018-02-121-10/+10
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17895 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: fix typoTobias Nießen2018-02-121-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/17900 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: use my legal name in READMETimothy Gu2018-02-121-1/+1
| | | | | | | | | | Just so that it's documented. Feel free to call me anything you want though: Timothy, Tim, 顾天骋. PR-URL: https://github.com/nodejs/node/pull/17894 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* test: make test-tls-invoke-queued use public APIAnna Henningsen2018-02-121-3/+3
| | | | | | | | | | | | | | `parallel/test-tls-invoke-queued` previously used the internal `_write()` API to hook into the internals more directly, but this invalidates the general assumption made by streams APIs that only a single write is active at a time, and which is enforced through the public API. PR-URL: https://github.com/nodejs/node/pull/17864 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* crypto: add ocsp_request ClientHelloParser::ResetDaniel Bevenius2018-02-121-0/+1
| | | | | | | | | | | I noticed that ocsp_request is not being reset in ClientHelloParser::Reset. I've not been able to figure out the the reason for this and wanted to bring this up just in case this was overlooked and should be reset. PR-URL: https://github.com/nodejs/node/pull/17753 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: refactor test-tls-securepair-fifthargAnna Henningsen2018-02-121-7/+2
| | | | | | | | | | | | | | Assert the server name directly in the `SNICallback`, since `common.mustCall()` already guarantees that the callback is called exactly once, making `process.on('exit')` unnecessary. PR-URL: https://github.com/nodejs/node/pull/17836 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: fix AttributeError: __exit__ on Python 2.6Dmitriy Kasyanov2018-02-121-1/+1
| | | | | | | | | | Error occurs while dealing with Tar archives PR-URL: https://github.com/nodejs/node/pull/17663 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: use dashes instead of asterisksRuben Bridgewater2018-02-122-7/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17722 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* doc: update AUTHORS listRuben Bridgewater2018-02-122-3/+34
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17805 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* tools: autofixer for lowercase-name-for-primitiveShobhit Chittora2018-02-122-12/+31
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/17715 Refs: https://github.com/nodejs/node/issues/16636 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Weijia Wang <starkwang@126.com>
* test: remove undefined functionRich Trott2018-02-121-1/+3
| | | | | | | | | | | | | | | `common.fail()` no longer exists as its functionality is now in `assert.fail()`. Replace only two instances in the code base with `assert.fail()`. PR-URL: https://github.com/nodejs/node/pull/17845 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
* doc: add starkwang to collaboratorsWeijia Wang2018-02-121-0/+2
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17847 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* test: use common module API in test-child-process-exec-stdout-stderr-data-stringsreepurnajasti2018-02-121-14/+4
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17751 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: improve fs api descriptionsEvan Lucas2018-02-121-9/+27
| | | | | | | | | | | | | This improves the api descriptions for fs.chown, fs.chmod, and fs.mkdir along with their *Sync counterparts. PR-URL: https://github.com/nodejs/node/pull/17679 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: instructions on how to make membership publicMichael Dawson2018-02-121-0/+4
| | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17688 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* test: refactor test-repl-definecommandRich Trott2018-02-121-4/+10
| | | | | | | | | The test was writing to both REPL input and output but only checking output. Sending output to both streams seems like it was an error. PR-URL: https://github.com/nodejs/node/pull/17795 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com>
* tls: comment about old-style errorsxortiz2018-02-121-0/+2
| | | | | | | | | | | | | | | Old style errors are being migrated to internal/errors.js, however, due to depreciation of _tls_legacy.js, it isn't worth the effort to migrate and potentially force users to update their code for this error change. This comment clarifies the reason why this error is not migrated. PR-URL: https://github.com/nodejs/node/pull/17759 Refs: https://github.com/nodejs/node/issues/17709 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
* doc: removed extra explanation in api/buffer.mdWaleed Ashraf2018-02-121-7/+5
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17796 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: use american spelling as per style guidesreepurnajasti2018-02-121-1/+1
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/17818 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* doc: require CI status indicator in PRsNikolai Vavilov2018-02-121-0/+1
| | | | | | | | | | | | | Commits are often landed despite failing on one or more CI platforms. Having a CI status indicator in the PR should make this less likely to happen. PR-URL: https://github.com/nodejs/node/pull/17151 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* net: remove ADDRCONFIG DNS hint on WindowsBartosz Sosnowski2018-02-121-1/+4
| | | | | | | | | | | | | On Windows setting ADDRCONFIG causes localhost resolution to fail if there are no network connections. This removes that flag on Windows. Fixes: https://github.com/nodejs/node/issues/17641 PR-URL: https://github.com/nodejs/node/pull/17662 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
View Lorry Controller Status