summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* 2017-11-07 Node.js v8.9.1 'Carbon' (LTS) Releasev8.9.1-proposalGibson Fahnestock2017-11-073-3/+31
| | | | PR-URL: https://github.com/nodejs/node/pull/16783
* deps: V8: cherry-pick 32141e9 from upstreamAli Ijaz Sheikh2017-11-072-2/+2
| | | | | | | | | | | | | | | | | | | | Original commit message: Disable --turbo-inline-array-builtins by default. Current chrome stable has a high number of crashes due to bugs in this feature. These bugs are already fixed but the fixes are hard to merge back. Therefore we decided to disable the feature in stable. This CL is intended to be merged to stable and then reverted in tot. Bug: chromium:762020 Change-Id: Ibd5a08e3b303a204fb84a408271a1c0f97cc5b7b Reviewed-on: https://chromium-review.googlesource.com/738176 Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#48931} Refs: https://github.com/v8/v8/commit/32141e93ff094f6df691cb89b10d2d6e1af4e983 PR-URL: https://github.com/nodejs/node/pull/16704
* deps: cherry-pick e7f4e9e from upstream libuvBartosz Sosnowski2017-11-033-7/+42
| | | | | | | | | | | | | | | | | | Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: https://github.com/nodejs/node/issues/16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: https://github.com/nodejs/node/pull/16724 Fixes: https://github.com/https://github.com/nodejs/node/issues/16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* doc: add 9.x to version picker and mark 8.x as LTSChris Young2017-11-031-1/+2
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/16672 Fixes: https://github.com/node/issues/16671 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* Revert "https: refactor to use http internals"Myles Borins2017-11-031-27/+17
| | | | | | | | | | | | | | | | | | | | | This reverts commit 5118f3146643dc55e7e7bd3082d1de4d0e7d5426. It is breaking code in the wild that depends on the original behavior to do tracing. I don't think we need to necessarily fix this in 8.x but we might want to reclassify the original commit as Semver Major PR-URL: https://github.com/nodejs/node/pull/16660 Refs: https://github.com/nodejs/node/pull/16395 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jan Krems <jan.krems@gmail.com>
* deps: update openssl asm and asm_obsolete filesShigeki Ohtsu2017-11-0312-48/+150
| | | | | | | | | | | | | | | | | | Regenerate asm files with Makefile and CC=gcc and ASM=nasm where gcc version was 5.4.0 and nasm version was 2.11.08. Also asm files in asm_obsolete dir to support old compiler and assembler are regenerated without CC and ASM envs. PR-URL: https://github.com/nodejs/node/pull/16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: add -no_rand_screen to openssl s_clientShigeki Ohtsu2017-11-032-2/+20
| | | | | | | | | | | | | In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. Fixes: https://github.com/nodejs/io.js/issues/1461 PR-URL: https://github.com/nodejs/io.js/pull/1836 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* openssl: fix keypress requirement in apps on win32Shigeki Ohtsu2017-11-031-7/+13
| | | | | | | | | Reapply b910613792dac946b295855963869933a9089044 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* deps: fix asm build error of openssl in x86_win32Shigeki Ohtsu2017-11-031-6/+6
| | | | | | | | | | | | See https://mta.openssl.org/pipermail/openssl-dev/2015-February/000651.html iojs needs to stop using masm and move to nasm or yasm on Win32. Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* deps: fix openssl assembly error on ia32 win32Fedor Indutny2017-11-031-1/+1
| | | | | | | | | | | `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . Fixes: https://github.com/iojs/io.js/issues/589 PR-URL: https://github.com/iojs/io.js/pull/1389 Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
* deps: copy all openssl header files to include dirShigeki Ohtsu2017-11-0376-265/+38519
| | | | | | | | | | | | | | | | | All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: https://github.com/nodejs/node/pull/16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* deps: upgrade openssl sources to 1.0.2mShigeki Ohtsu2017-11-03218-38827/+1846
| | | | | | | | | | | | | | | This replaces all sources of openssl-1.0.2m.tar.gz into deps/openssl/openssl PR-URL: https://github.com/nodejs/node/pull/16691 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: update process-release for Node 8 CarbonJeremiah Senkpiel2017-11-021-3/+7
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
* src: add 'dynamic' process.release.lts propertyRod Vagg2017-11-023-1/+26
| | | | | | | | | | | | | | | | This makes the process.release.lts property configurable by a constant. This ref is the original PR to v6.x. Refs: https://github.com/nodejs/node/pull/3212 Conflicts: doc/api/process.md PR-URL: https://github.com/nodejs/node/pull/16656 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
* Working on v8.9.1Gibson Fahnestock2017-10-311-2/+2
| | | | PR-URL: https://github.com/nodejs/node/pull/16630
* 2017-10-31, Version 8.9.0 'Carbon' (LTS) Releasev8.9.0v8.9.0-proposalGibson Fahnestock2017-10-314-9/+137
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This LTS release comes with 87 commits. This includes 30 that are updates to lib/ or src/, 20 that are test related, 13 that are doc related, 19 which are build / tools related, and 4 commits which are updates to dependencies. Notable Changes: * doc: - add Gibson Fahnestock to Release team (Gibson Fahnestock) https://github.com/nodejs/node/pull/16620 * deps: - update npm to 5.5.1 (Myles Borins) https://github.com/nodejs/node/pull/16509 * http2: - The exposed http2 socket is no longer manipulatable (Anatoli Papirovski) https://github.com/nodejs/node/pull/16330 * module: - support custom paths to require.resolve() (cjihrig) https://github.com/nodejs/node/pull/16397 * util: - util.TextEncoder and util.TextDecoder are no longer experimental. There will no longer be a warning when they are used (James M Snell) https://github.com/nodejs/node/pull/15743 PR-URL: https://github.com/nodejs/node/pull/16630
* doc: add license information for remark-cliMyles Borins2017-10-313-0/+50
| | | | | | | | | | | | | | | | The LICENSE file was not originally included when remark-cli was vendored. This Commit adds the LICENSE file back to tools/remark-cli and updates the top level license in the project PR-URL: https://github.com/nodejs/node/pull/16637 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: add Gibson Fahnestock to Release teamGibson Fahnestock2017-10-301-0/+3
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/16620 Refs: https://github.com/nodejs/TSC/issues/350 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
* http2: make sessions garbage-collectibleAnna Henningsen2017-10-304-11/+24
| | | | | | | | | | Use weak handles to track the lifetime of an `Http2Session` instance. Refs: https://github.com/nodejs/http2/issues/140 PR-URL: https://github.com/nodejs/node/pull/16461 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* http2: remove unused assignmentAnna Henningsen2017-10-301-1/+0
| | | | | | | | | When assigning to a union twice, the first assignment is a no-op. PR-URL: https://github.com/nodejs/node/pull/16461 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* http2: track async state for sendingAnna Henningsen2017-10-301-0/+6
| | | | | | | | | | Sending pending data may involve running arbitrary JavaScript code. Therefore, it should involve a callback scope. PR-URL: https://github.com/nodejs/node/pull/16461 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* src: add `InternalCallbackScope` util constructorAnna Henningsen2017-10-302-0/+8
| | | | | | | | | | Add an utility constructor for `AsyncWrap` classes that wish to leverage `InternalCallbackScope`s. PR-URL: https://github.com/nodejs/node/pull/16461 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* http2: move uv_prepare handle to `Http2Session`Anna Henningsen2017-10-304-51/+55
| | | | | | | | | | As far as I understand it, `Nghttp2Session` should not be concerned about how its consumers handle I/O. PR-URL: https://github.com/nodejs/node/pull/16461 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
* test: remove empty comments in http2 testsGibson Fahnestock2017-10-3063-63/+0
| | | | | | | | | | I assume they aren't meant to be there. PR-URL: https://github.com/nodejs/node/pull/16631 Refs: https://github.com/nodejs/node/pull/15685 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* inspector: track async stacks when necessaryAli Ijaz Sheikh2017-10-306-69/+142
| | | | | | | | | | | | | | | With this change, we do async stack tracking only when explicitly requested by the inspector client. This avoids unnecessary overhead for clients that might not be interested in async stack traces. Backport-PR-URL: https://github.com/nodejs/node/pull/16590 PR-URL: https://github.com/nodejs/node/pull/16308 Fixes: https://github.com/nodejs/node/issues/16180 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* deps: V8: backport b1cd96e from upstreamAli Ijaz Sheikh2017-10-308-1/+53
| | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [inspector] added V8InspectorClient::maxAsyncCallStackDepthChanged R=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0fa10978266feb3c3907ce1f3386ae7a34a33582 Reviewed-on: https://chromium-review.googlesource.com/726490 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#48705} Backport-PR-URL: https://github.com/nodejs/node/pull/16590 PR-URL: https://github.com/nodejs/node/pull/16308 Refs: https://github.com/v8/v8/commit/b1cd96ec4b836348bcffba357cd29076ab3ae48b Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
* lib: refactor wrap_js_stream for ES6/readabilityAnna Henningsen2017-10-313-187/+183
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/16158 Backport-PR-URL: https://github.com/nodejs/node/pull/16626 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* lib: move _stream_wrap into internalsAnna Henningsen2017-10-313-225/+229
| | | | | | | | | | This makes a subsequent possible deprecation easier. PR-URL: https://github.com/nodejs/node/pull/16158 Backport-PR-URL: https://github.com/nodejs/node/pull/16626 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* child_process: fix memory leak in .fork()Ben Noordhuis2017-10-313-0/+6
| | | | | | | | | | | | Entries in the `net.Server#_slaves` array that is used to track handles sent from the master to workers were not deleted when a worker exited, resulting in a slow but inexorable memory leak. PR-URL: https://github.com/nodejs/node/pull/15679 Backport-PR-URL: https://github.com/nodejs/node/pull/16586 Fixes: https://github.com/nodejs/node/issues/15651 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* deps: cherry-pick e0d64dc from upstream V8Michaël Zasso2017-10-314-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [heap] Print the number of chunks in unmapper queue in --trace-gc-nvp Bug: chromium:771966 Change-Id: I146b279c4713b7dd716c6d55ca5e6c6e23a3ad7e Reviewed-on: https://chromium-review.googlesource.com/704740 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48338} Refs: https://github.com/v8/v8/commit/e0d64dc67c6abf36a37efdc6e8e6903bb114ebd3 Refs: https://github.com/nodejs/help/issues/917#issuecomment-339292642 Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=771966 PR-URL: https://github.com/nodejs/node/pull/16490 Backport-PR-URL: https://github.com/nodejs/node/pull/16569 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* deps: cherry-pick 676c413 from upstream V8Michaël Zasso2017-10-312-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [heap] Fix threshold for delayed chunks after 2c7561. Bug: chromium:771966 Change-Id: Iac5ee55c0d31de477f21f091f4be015a1ca8d00c Reviewed-on: https://chromium-review.googlesource.com/702382 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48316} Refs: https://github.com/v8/v8/commit/676c41321a948c08d6a43de43fe9b1d60ae81c00 Refs: https://github.com/nodejs/help/issues/917#issuecomment-339292642 Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=771966 PR-URL: https://github.com/nodejs/node/pull/16490 Backport-PR-URL: https://github.com/nodejs/node/pull/16569 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* deps: cherry-pick 2c75616 from upstream V8Michaël Zasso2017-10-313-1/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Original commit message: [heap] Ensure progress in unmapping memory chunks. If sweeping is not making progress and there are many young generation GCs happening, then this can lead to accumulation of memory chunks in the unmapper queue. Bug: chromium:771966 Change-Id: Ief73ada0d17198a80b668850c6d2e7ea413113e7 Reviewed-on: https://chromium-review.googlesource.com/702479 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48312} Refs: https://github.com/v8/v8/commit/2c75616028e75883e28df2c6d8dd2a6bfe47f718 Refs: https://github.com/nodejs/help/issues/917#issuecomment-339292642 Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=771966 PR-URL: https://github.com/nodejs/node/pull/16490 Backport-PR-URL: https://github.com/nodejs/node/pull/16569 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* doc: document missing error codesGeorge Bezerra2017-10-311-17/+129
| | | | | | | | | | | | | There are discrepancies between the errors defined in `lib/internal/errors.js` and those documented in `doc/api/errors.md`. Some of the errors recently defined are not documented, while others were removed, but still have entries in the docs. This commit fills in those gaps in the documentation. PR-URL: https://github.com/nodejs/node/pull/15160 Backport-PR-URL: https://github.com/nodejs/node/pull/16556 Fixes: https://github.com/nodejs/node/issues/15038 Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: use destructuring for some constantsWeijia Wang2017-10-3134-134/+131
| | | | | | | | | | | | | | This change is to unify the declaration for constants into using destructuring on the top-level-module scope, reducing some redundant code. PR-URL: https://github.com/nodejs/node/pull/16063 Backport-PR-URL: https://github.com/nodejs/node/pull/16494 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* doc: fix inconsistent server.listen documentationMartin Michaelis2017-10-313-119/+23
| | | | | | | | | | | | | | | The `net`, `tls`, `http` and `https` module have the same `server.listen()` method, but have a different documenation. Changed to a consistent link to the documentation of the `net` module. PR-URL: https://github.com/nodejs/node/pull/16020 Backport-PR-URL: https://github.com/nodejs/node/pull/16435 Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* lib: move duplicate spliceOne into internal/utilWeijia Wang2017-10-313-16/+15
| | | | | | | | | | | | | | | | lib/url.js and lib/events.js are using the same spliceOne function. This change is to move it into the internal/util for avoiding duplicate code. PR-URL: https://github.com/nodejs/node/pull/16221 Backport-PR-URL: https://github.com/nodejs/node/pull/16433 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* util: expand test coverage for util.deprecateAshish Kaila2017-10-311-0/+11
| | | | | | | | | | | | Test for invalid argument types passed to code on util.deprecate. PR-URL: https://github.com/nodejs/node/pull/16305 Backport-PR-URL: https://github.com/nodejs/node/pull/16430 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: more accurate zlib windowBits informationAnna Henningsen2017-10-312-7/+7
| | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/14847 PR-URL: https://github.com/nodejs/node/pull/16511 Backport-PR-URL: https://github.com/nodejs/node/pull/16623 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* doc: make default values and periods consistentMatej Krajčovič2017-10-316-69/+68
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/16563 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: make test-doc and lint addon docsJoyee Cheung2017-10-312-15/+43
| | | | | | | | | | | | | | - Implements the make test-doc target that build, verify and lint docs - Lint the C++ snippets in addon docs - When generating addons and running the JS linter, use the global node executable if it is not built. Therefore one does not have to build node in order to run make test-doc. PR-URL: https://github.com/nodejs/node/pull/16377 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* build: make doc target quietDaniel Bevenius2017-10-313-7/+5
| | | | | | | | | | | | | Currently it can be a little difficult to detect errors in the output from the doc target. This commit suggests reducing the output to make it easier to identify errors. PR-URL: https://github.com/nodejs/node/pull/16516 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* http2: fix stream reading resumptionAnatoli Papirovski2017-10-317-19/+79
| | | | | | | | | | | | | | | _read should always resume the underlying code that is attempting to push data to a readable stream. Adjust http2 core code to resume its reading appropriately. Some other general cleanup around reading, resuming & draining. PR-URL: https://github.com/nodejs/node/pull/16580 Fixes: https://github.com/nodejs/node/issues/16578 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* build: ignore empty folders in test-addons-napiAnna Henningsen2017-10-311-1/+6
| | | | | | | | | | | | | | | The same as https://github.com/nodejs/node/pull/16031 except for N-API addons. PR-URL: https://github.com/nodejs/node/pull/16380 Fixes: https://github.com/nodejs/node/issues/13521 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* test: add block scoping to test-assert-deepRich Trott2017-10-311-35/+41
| | | | | | | | | | | | | Add block scoping to test-assert-deep.js to reduce likelihood of one test case having side effects that affect another test case. PR-URL: https://github.com/nodejs/node/pull/16532 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
* lib: setup IPC channel before consoleNikolai Vavilov2017-10-312-6/+24
| | | | | | | | | | | | | | Initializing IOCP on the same fd twice can fail on Windows. Consequently, if the IPC channel uses fd 1 or 2 and the console is setup first, writing to the IPC channel will fail. PR-URL: https://github.com/nodejs/node/pull/16562 Fixes: https://github.com/nodejs/node/issues/16141 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
* tools: modernize license2rtfTobias Nießen2017-10-311-154/+142
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/16220 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* tools: replace loop with padStartTobias Nießen2017-10-311-4/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/16220 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: slightly relax 50 character ruleJames M Snell2017-10-311-2/+2
| | | | | | | | | | | | | | Allow commit message first line to exceed 50 chars if necessary PR-URL: https://github.com/nodejs/node/pull/16523 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* http2: simplify mapToHeaders, stricter validationAnatoli Papirovski2017-10-314-22/+38
| | | | | | | | | | | | | | | | | No longer check whether key is a symbol as Object.keys does not return symbols. No longer convert key to string as it is always a string. Validate that only one value is passed for each pseudo-header. Extend illegal connection header message to include the name of the problematic header. Extend tests to cover this behaviour. PR-URL: https://github.com/nodejs/node/pull/16575 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* http2: fix several timeout related issuesAnatoli Papirovski2017-10-316-6/+274
| | | | | | | | | | | | | | | | | * correctly reset write timers: currently reset timers on both session & stream when write starts and when it ends. * prevent large writes from timing out: when writing a large chunk of data in http2, once the data is handed off to C++, the JS session & stream lose all track of the write and will timeout if the write doesn't complete within the timeout window Fix this issue by tracking whether a write request is ongoing and also tracking how many chunks have been sent since the most recent write started. (Since each write call resets the timer.) PR-URL: https://github.com/nodejs/node/pull/16525 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
View Lorry Controller Status