summaryrefslogtreecommitdiff
path: root/doc/api
Commit message (Collapse)AuthorAgeFilesLines
* cli: add `--trace-atomics-wait` flagAnna Henningsen2020-05-151-0/+30
| | | | | | | | | | | | | Adds a flag that helps with debugging deadlocks due to incorrectly implemented `Atomics.wait()` calls. PR-URL: https://github.com/nodejs/node/pull/33292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* fs: forbid concurrent operations on Dir handleAnna Henningsen2020-05-151-0/+9
| | | | | | | | | | | | | | | | | | | | | libuv does not expect concurrent operations on `uv_dir_t` instances, and will gladly create memory leaks, corrupt data, or crash the process. This patch forbids that, and: - Makes sure that concurrent async operations are run sequentially - Throws an exception if sync operations are attempted during an async operation The assumption here is that a thrown exception is preferable to a potential hard crash. This fully fixes flakiness from `parallel/test-fs-opendir` when run under ASAN. PR-URL: https://github.com/nodejs/node/pull/33274 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* Revert "vm: add importModuleDynamically option to compileFunction"Matteo Collina2020-05-151-11/+4
| | | | | | | | | | | | | | This reverts commit 74c393dd93cc0e461e3796fbcc09545fcacdecaf. Fixes: https://github.com/nodejs/node/issues/33166 PR-URL: https://github.com/nodejs/node/pull/33364 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* doc: add examples for implementing ESMunknown2020-05-141-0/+21
| | | | | | | | Fixes: https://github.com/nodejs/node/issues/28060 PR-URL: https://github.com/nodejs/node/pull/33168 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
* src: add support for TLAGus Caplan2020-05-143-25/+53
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/30370 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* tls: fix --tls-keylog optionAlba Mendez2020-05-141-1/+1
| | | | | | | | | | | | | | | | | There's a typo that causes only the first socket to be logged (i.e. when the warning is emitted). In addition, server sockets aren't logged because `keylog` events are not emitted on tls.Server, not the socket. This behaviour is counterintuitive and has caused more bugs in the past, so make all sockets (server or client) emit 'keylog'. tls.Server will just re-emit these events. Refs: https://github.com/nodejs/node/pull/30055 PR-URL: https://github.com/nodejs/node/pull/33366 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* doc: add note about clientError writable handlingPaolo Insogna2020-05-121-0/+15
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33308 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: fix typo in n-api.mdDaniel Bevenius2020-05-121-1/+1
| | | | | | | | | | | | | This commit fixes what I think is a typo, even though the section in question does talk about a environment (env). PR-URL: https://github.com/nodejs/node/pull/33319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
* http: emit 'error' on aborted server requestRobert Nagy2020-05-101-3/+8
| | | | | | | | | | | | | | | | | | Server requests aka. IncomingMessage emits 'aborted' instead of 'error' which causes confusion when the object is used as a regular stream, i.e. if functions working on streams are passed a server request object they might not work properly unless they take this into account. Refs: https://github.com/nodejs/web-server-frameworks/issues/41 PR-URL: https://github.com/nodejs/node/pull/33172 Fixes: https://github.com/nodejs/node/issues/28172 Refs: https://github.com/nodejs/node/pull/28677 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* http: return this from ClientRequest#destroy()cjihrig2020-05-091-0/+5
| | | | | | | | | | | This commit updates ClientRequest#destroy() to return `this` for consistency with other writable streams. PR-URL: https://github.com/nodejs/node/pull/32789 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* http: return this from IncomingMessage#destroy()cjihrig2020-05-091-0/+6
| | | | | | | | | | | | This commit updates IncomingMessage#destroy() to return `this` for consistency with other readable streams. PR-URL: https://github.com/nodejs/node/pull/32789 Fixes: https://github.com/nodejs/node/issues/32772 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* fs: add .ref() and .unref() methods to watcher classesrickyes2020-05-091-0/+67
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/33134 Fixes: https://github.com/nodejs/node/issues/33096 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* http: expose http.validate-header-name/valueosher2020-05-091-0/+70
| | | | | | | | | | | | The use-case is for any framework that provides user mw a response replacement, that collects the desired response state, and applies them only on conclusion. As such a framework, I'd want to validate the header names and values as soon as the user-code provides them. This - to eliminate errors on response-send time, and provide developer stack trace that contains the line that submits the offending values. PR-URL: https://github.com/nodejs/node/pull/33119 Reviewed-By: Anna Henningsen <anna@addaleax.net>
* async_hooks: move PromiseHook handler to JSStephen Belanger2020-05-091-5/+0
| | | | | | | | | | | | | | | This avoids the need to wrap every promise in an AsyncWrap and also makes it easier to skip the machinery to track destroy events when there's no destroy listener. Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32891 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* doc: add warning for socket.connect reuseRobert Nagy2020-05-081-0/+4
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/33204 Refs: https://github.com/nodejs/node/issues/25969 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* doc: correct description of `decipher.setAuthTag` in crypto.mdJonathan Buhacoff2020-05-081-2/+3
| | | | | | | | | | Calling `decipher.setAuthTag` after `decipher.update` will result in an error like `Unsupported state or unable to authenticate data`. The example code in [CCM mode](https://nodejs.org/docs/latest-v14.x/api/crypto.html#crypto_ccm_mode) is correct, but to demonstrate the mistake in the documentation you can take the same example and move the `setAuthTag` call to in between `update` and `final` you will see the error.
* doc: removed unnecessary util imports from vm examplesKarol Walasek2020-05-081-5/+0
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33179 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: update Buffer(size) documentationNikolai Vavilov2020-05-081-3/+1
| | | | | | | | It returns zero-filled memory since v8.0.0. PR-URL: https://github.com/nodejs/node/pull/33198 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* doc: add Uint8Array to `end` and `write`Pranshu Srivastava2020-05-081-2/+2
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/33217 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
* doc: specify unit of time passed to `fs.utimes`Simen Bekkhus2020-05-081-2/+2
| | | | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/33230 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* wasi: prevent syscalls before startTobias Nießen2020-05-081-0/+5
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/33235 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* doc: add troubleshooting guide for AsyncLocalStorageAndrey Pechkurov2020-05-081-0/+16
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/33248 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* doc: remove AsyncWrap mentions from async_hooks.mdAndrey Pechkurov2020-05-081-2/+2
| | | | | | | | | | | | | AsyncWrap is a private API and should not be mentioned in the documentation. PR-URL: https://github.com/nodejs/node/pull/33249 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: add warnings about transferring Buffers and ArrayBufferJames M Snell2020-05-081-0/+46
| | | | | | | | | | | | Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/33252 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Mathias Buus <mathiasbuus@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: update napi_async_init documentationMichael Dawson2020-05-061-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/33153 Change documentation to make async_resource required as opposed to optional in napi-async_init. Changes over time mean this parameter is required for proper operation of async hooks (which are still experimental). This changes the documentation to document what callers should do. We are doing this only in the doc in order to avoid a breaking change in N-API. We could create a new version of the method for which the parametrer is enforced as mandatory but we should only do that once async hooks is no longer experimental. In that case we could deprecate (but not remove this version of the method). Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33181 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
* doc: doc and test URLSearchParams discrepancyJames M Snell2020-05-061-3/+21
| | | | | | | | | | | | | | | The WHATWG URL spec is not going to change this behavior so let's document it Signed-off-by: James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/33037 PR-URL: https://github.com/nodejs/node/pull/33236 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
* 2020-05-05, Version 14.2.0 (Current)Michaël Zasso2020-05-052-6/+6
| | | | | | | | | | | Notable changes: * Track function calls with `assert.CallTracker` (experimental). https://github.com/nodejs/node/pull/31982 * Added a `groupIndentation` option to the `Console` constructor. https://github.com/nodejs/node/pull/32964 PR-URL: https://github.com/nodejs/node/pull/33232
* doc: explicitly doc package.exports is breakingMyles Borins2020-05-051-15/+66
| | | | | | | | | | | | | | | | If package authors don't explicitly include all previously supported entry points introducing package.exports will be a Semver-Major change. Add a warning about this behavior and offer two potential solutions for module authors. Refs: https://github.com/then/is-promise/issues/20 PR-URL: https://github.com/nodejs/node/pull/33074 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* doc: fix style and grammer in buffer.mdNikolai Vavilov2020-05-041-6/+7
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33194 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: mark assert.CallTracker experimentalRuben Bridgewater2020-05-041-0/+7
| | | | | | | | | | | | | Some details might still change and it would be good to get feedback from users before we mark this as stable. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33124 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
* doc: add missing deprecation notRobert Nagy2020-05-041-0/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/33203 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* doc: fix a typo in crypto.generateKeyPairSync()himself652020-05-031-2/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* doc: add util.types.isArrayBufferView()Kevin Locke2020-05-021-0/+19
| | | | | | | | | | | | | This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
* doc: fix the spelling error in stream.md白一梓2020-04-301-3/+3
| | | | | | | | | Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* vm: fix vm.measureMemory() and introduce execution optionJoyee Cheung2020-04-301-18/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://github.com/nodejs/node-v8/pull/147 broke the `vm.measureMemory()` API. It only created a `MeasureMemoryDelegate` and without actually calling `v8::Isolate::MeasureMemory()` so the returned promise will never resolve. This was not caught by the tests because the promise resolvers were not wrapped with `common.mustCall()`. This patch migrates the API properly and also introduce the newly added execution option to the API. It also removes support for specifying contexts to measure - instead we'll just return the measurements for all contexts in the detailed mode, which is what the `performance.measureMemory()` prototype in V8 currently does. We can consider implementing our own `v8::MeasureMemoryDelegate` to select the target context in `ShouldMeasure()` in the future, but then we'll also need to implement `MeasurementComplete()` to assemble the result. For now it's probably too early to do that. Since this API is still experimental (and guarded with a warning), such breakage should be acceptable. Refs: https://github.com/nodejs/node-v8/pull/147 PR-URL: https://github.com/nodejs/node/pull/32988 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* module: no type module resolver side effectsGuy Bedford2020-04-291-7/+0
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33086 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
* 2020-04-29, Version 13.14.0 (Current)Ruben Bridgewater2020-04-306-7/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | Notable Changes: * async_hooks**: * Merge `run` and `exit` methods (Andrey Pechkurov) https://github.com/nodejs/node/pull/31950 * Prevent sync methods of async storage exiting outer context (Stephen Belanger) https://github.com/nodejs/node/pull/31950 * vm: * Add `importModuleDynamically` option to compileFunction (Gus Caplan) https://github.com/nodejs/node/pull/32985 New core collaborators: With this release, we welcome two new Node.js core collaborators: * Juan José Arboleda @juanarbol https://github.com/nodejs/node/pull/32906 * Andrey Pechkurov @puzpuzpuz https://github.com/nodejs/node/pull/32817 PR-URL: https://github.com/nodejs/node/pull/33122
* 2020-04-29, Version 14.1.0 (Current)Beth Griggs2020-04-296-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Notable changes: - deps: upgrade openssl sources to 1.1.1g (Hassaan Pasha) [#32971](https://github.com/nodejs/node/pull/32971) - doc: add juanarbol as collaborator (Juan José Arboleda) [#32906](https://github.com/nodejs/node/pull/32906) - http: doc deprecate abort and improve docs (Robert Nagy) [#32807](https://github.com/nodejs/node/pull/32807) - module: do not warn when accessing `__esModule` of unfinished exports (Anna Henningsen) [#33048](https://github.com/nodejs/node/pull/33048) - n-api: detect deadlocks in thread-safe function (Gabriel Schulhof) [#32860](https://github.com/nodejs/node/pull/32860) - src: deprecate embedder APIs with replacements (Anna Henningsen) [#32858](https://github.com/nodejs/node/pull/32858) - stream: - don't emit end after close (Robert Nagy) [#33076](https://github.com/nodejs/node/pull/33076) - don't wait for close on legacy streams (Robert Nagy) [#33058](https://github.com/nodejs/node/pull/33058) - pipeline should only destroy un-finished streams (Robert Nagy) [#32968](https://github.com/nodejs/node/pull/32968) - vm: add importModuleDynamically option to compileFunction (Gus Caplan) [#32985](https://github.com/nodejs/node/pull/32985) PR-URL: https://github.com/nodejs/node/pull/33103
* stream: add null check in Readable.fromPranshu Srivastava2020-04-291-1/+2
| | | | | | | | | | | | | Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By: 扩散性百万甜面包 <himself65@outlook.com> Fixes: https://github.com/nodejs/node/issues/32845 PR-URL: https://github.com/nodejs/node/pull/32873 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* worker: add stack size resource limit optionAnna Henningsen2020-04-291-0/+4
| | | | | | | | | | | Add `stackSizeMb` to the `resourceLimit` option group. Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820 PR-URL: https://github.com/nodejs/node/pull/33085 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* doc: improve worker pool exampleRanjan Purbey2020-04-291-0/+1
| | | | | | | | | | | | | | In the worker pool example, the 'kWorkerFreedEvent' should be emitted in case of error as well. After adding new worker in the error handler, the pending tasks should be notified of an available worker. PR-URL: https://github.com/nodejs/node/pull/33082 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
* doc: fix markdown parsing on doc/api/os.mdJuan José Arboleda2020-04-291-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/33067 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
* console: support console constructor groupIndentation optionrickyes2020-04-291-8/+15
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/32964 Fixes: https://github.com/nodejs/node/issues/32947 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* http2,doc: minor fixesAlba Mendez2020-04-281-2/+3
| | | | | | | | | | | | | | | | | | | | Some small fixes on HTTP/2 and its documentation: - Add a note that, on server streams, it's not necessary to start data flow. - Set EOF flag if we have marked all data for sending: there's no need to wait until the queue is actually empty (and send a separate, empty DATA). (Note that, even with this change, a separate DATA frame will always be sent, because the streams layer waits until data has been flushed before dispatching EOF) PR-URL: https://github.com/nodejs/node/pull/28044 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* wasi: update start() behavior to match speccjihrig2020-04-281-4/+5
| | | | | | | | | | | _start() and _initialize() shouldn't be called from the same function, as they have different behavior. Furthermore, Node should throw if both are provided. This commit updates the implementation, docs, and tests accordingly. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host>
* wasi: rename __wasi_unstable_reactor_start()cjihrig2020-04-281-2/+2
| | | | | | | | | | Upstream WASI has renamed __wasi_unstable_reactor_start() to _initialize(). This commit updates Node's WASI implementation to reflect that change. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host>
* 2020-04-28, Version 12.16.3 'Erbium' (LTS)Michaël Zasso2020-04-281-1/+3
| | | | | | | | | | | | | | | | | | Notable changes: Dependencies: * Updated OpenSSL to 1.1.1g. https://github.com/nodejs/node/pull/32971 * Updated c-ares to 1.16.0. https://github.com/nodejs/node/pull/32246 * Updated experimental uvwasi to 0.0.6. https://github.com/nodejs/node/pull/32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. https://github.com/nodejs/node/pull/31845 PR-URL: https://github.com/nodejs/node/pull/33009
* doc: fix LTS replaceme tagsAnna Henningsen2020-04-2827-127/+363
| | | | | | | | | | | | | | | | | | | When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: https://github.com/nodejs/node/issues/33001 PR-URL: https://github.com/nodejs/node/pull/33041 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com>
* doc: assign missing deprecation codeRichard Lau2020-04-281-2/+2
| | | | | | | | | Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/33109 Refs: https://github.com/nodejs/node/pull/32807 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
* doc: improve WHATWG url constructor code exampleLiran Tal2020-04-281-0/+7
| | | | | | | | | Currently, the URL docs for the WHATWG URL spec support are somewhat lacking in their code example of how to access the new URL constructor that lives inside the core url package. PR-URL: https://github.com/nodejs/node/pull/32782 Reviewed-By: Anna Henningsen <anna@addaleax.net>
View Lorry Controller Status