| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
The refactor in 3ae0b17c broke the multiline input's visual appearence.
While actually switching to this mode, the `...` prefix is not
displayed.
Additionally, account only SyntaxErrors that are happening at the parse
time, everything else should not be switching repl to the multiline
mode.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The [Stream documentation for .push](http://nodejs.org/api/stream.html#stream_readable_push_chunk_encoding)
explicitly states multiple times that null is a special cased value
that indicates the end of a stream. It is confusing and undocumented
that undefined *also* ends the stream, even though in object mode
there is a distinct and important difference.
The docs for Object-Mode also explicitly mention null as the *only*
special cased value, making no mention of undefined.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
| |
fix #7769
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
| |
Creating a new buffer from the toJSON() output of another
buffer does not currently work. This commit adds that
support. Closes #7849.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
| |
Uses getnameinfo to resolve an address an port into a hostname and
service.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
| |
Add `honorCipherOrder` argument to `crypto.createCredentials`.
fix #7249
|
|
|
|
|
|
|
|
|
|
|
| |
Calling dns.lookup with arguments that generate an error from c-ares
previously sent those errors back to the callback. This commit restores
the ca9eb71 behavior.
Fixes #7731.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently child_process.exec() assumes that cmd.exe is on the PATH,
and fails with a spawn ENOENT error if it is not.
The Windows 'comspec' environment variable contains the full filepath
to the default command interpreter, eg "C:\Windows\System32\cmd.exe".
Should it not be set, we fall-back to using 'cmd.exe' from PATH, as
before.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
|
|
|
| |
This features comes from the need of adding extra options when displaying
the object using console.dir().
console.dir() accepts now a second parameter that is passed to util.inspect()
in order to provide extra options to the output. These options are: depth, color
and showHidden. More information about these options in util.inspect() documentation.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
| |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In v0.10.x, process.argv and process.execArgv would only be
evaluated and copied into cluster.settings on the first call to
cluster.setupMaster() (either directly or via cluster.fork()),
allowing them to be modified as needed before initializing the
settings.
In 41b75ca the behaviour was changed so that these values are
initialized at the time of the first require('cluster').
Fixes #7670.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
AUTHORS
ChangeLog
deps/v8/src/api.cc
deps/v8/src/unicode-inl.h
deps/v8/src/unicode.h
lib/_stream_readable.js
lib/http.js
src/cares_wrap.cc
src/node.cc
src/node_crypto.cc
src/node_dtrace.cc
src/node_file.cc
src/node_stat_watcher.cc
src/node_version.h
src/process_wrap.cc
src/string_bytes.cc
src/string_bytes.h
src/udp_wrap.cc
src/util.h
test/simple/test-buffer.js
test/simple/test-stream2-compatibility.js
|
| |
| |
| |
| | |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| | |
|
| |
| |
| |
| |
| |
| | |
This patch simplifies the implementation of StringDecoder, fixes the
failures from the new test cases, and also no longer relies on v8's
WriteUtf8 function to encode individual surrogates.
|
| |
| |
| |
| |
| |
| |
| | |
Calling `.read()` in the same tick with `.on('data', ...)` may cause
users missing `error` events, because no `error` listeners were set yet.
fix #7618
|
| |
| |
| |
| | |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| | |
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
ChangeLog
lib/events.js
lib/tls.js
src/node_constants.cc
src/node_crypto.cc
src/node_crypto.h
src/node_version.h
|
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, if fstat() fails in readFile(), the callback
is invoked without closing the file. This commit closes
the file before calling back.
Closes #7697
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See https://github.com/orangemocha/node-connection-drop
I have pinpointed the performance degradation to
https://github.com/joyent/node/commit/ac2263b77f3f346458d06fc019de27e24c63cee0
This change brings performance back to the orginal levels.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
No point in setting args and options if TypeError
is being thrown.
fix #7456
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Ensure TypeError is thrown, fix a bug where `env` option was
assuming the option was actually an object.
This case is especially bad because it then sets `env == null`
instead of using `process.env`.
Fix #7456
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Before this commit the EventEmitter methods were anonymous functions.
V8 tries to infer names for anonymous functions based on the execution
context but it frequently gets it wrong and when that happens, the
stack trace is usually confusing and unhelpful. This commit names all
methods so V8 can fall back to the method.name property.
The above gotcha applies to all anonymous functions but is exacerbated
for EventEmitter methods because those are invoked with a plenitude of
different receivers.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Currently, if fstat() fails in readFile(), the callback
is invoked without closing the file. This commit closes
the file before calling back.
Closes #7697
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See https://github.com/joyent/node/issues/7675
net.server.listen() behaves inconsistently depending on whether the port
number is provided.
1. port === 0 && host == '' (i.e. false-y), node creates an AF_INET
socket but does not call bind().
2. port > 0 && host == '', node creates an AF_INET6 socket and calls
bind().
The fix makes 1 consistent with 2.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
EMFILE and ENFILE mean 'out of file descriptors'. It's a run-time error
and as such should emit an error on the child process object, not throw
an exception.
Fixes #7453.
Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Avoid sending unsent data and destroying otherwise legitimate sockets
for requests that are aborted while still in the agent queue. This
reduces stress on upstream systems who will likely respond to the
request but client app already knows that it will be dropped on the
floor and also helps avoid killing keep-alive connections.
|
| |
| |
| |
| |
| |
| |
| | |
Not all querystring are utf-8 encoding, make querystring can be used
to encode / decode `non-utf8` encoding string if necessary.
Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
|
| |
| |
| |
| |
| |
| |
| | |
Add a file property to the ENOENT Error returned from ChildProcess's
spawn function.
Signed-off-by: Timothy J Fontaine <tjfontaine@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
When close() is called on a non-listening server, a synchronous
error is thrown. This commit causes the error to be passed to
the asynchronous callback function instead.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| | |
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
stringToFlags() has fall throughs in a case statement.
However, they are not consistently implemented. This commit adds
consistency.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
There was an underlying assumption in readline.emitKeypressEvents (and
by extension emitKey) that the given stream (usually process.stdin)
would emit 'data' once per keypress, which is not always the case.
This commit buffers the input stream and ensures a 'keypress' event is
triggered for every keypress (including escape codes).
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Not removing 'end' listeners for input and output on the 'close' event
resulted in an EventEmitter related memory leak.
This issue also might be reproduced at:
https://github.com/npm/npm/issues/5203
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| | |
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| |
| |
| | |
Also include whitespace fixes to appease jslint.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
See https://code.google.com/p/chromium/issues/detail?id=25916
Parse URLs with backslashes the same as web browsers, by replacing all
backslashes with forward slashes, except those that occur after the
first # character.
Manual rebase of 9520ade
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| |
| |
| | |
Fixes #7551
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
|
| |
| |
| |
| | |
fixes #5715
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Reverted 9520adeb37f5ebe02a68669ec97770f4869705bb
Conflicts:
deps/cares/src/ares_parse_txt_reply.c
deps/uv/.mailmap
deps/uv/AUTHORS
deps/uv/ChangeLog
deps/uv/include/uv.h
deps/uv/src/unix/error.c
deps/uv/src/unix/process.c
deps/uv/src/version.c
deps/uv/src/win/pipe.c
deps/uv/src/win/signal.c
deps/uv/src/win/util.c
deps/uv/test/test-spawn.c
deps/uv/vcbuild.bat
deps/v8/src/platform-posix.cc
deps/v8/tools/gyp/v8.gyp
lib/util.js
src/node.cc
test/simple/test-util-format.js
test/simple/test-util.js
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Conflicts:
lib/util.js
test/simple/test-util-format.js
This is a backport to fix #7253
Signed-off-by: Fedor Indutny <fedor@indutny.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
See https://code.google.com/p/chromium/issues/detail?id=25916
Parse URLs with backslashes the same as web browsers, by replacing all
backslashes with forward slashes, except those that occur after the
first # character.
|