summaryrefslogtreecommitdiff
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* http: remove excess calls to removeSocketDave2015-12-211-2/+0
| | | | | | | | | | | | | | | | | | | | socket.destroy() triggers a 'close' event from the socket which triggers the onClose handler of HTTPAgent which calls self.removeSocket(). So by calling self.removeSocket() prior to socket.destroy() we end up with two calls to self.removeSocket(). If there are pending requests, removeSocket ends up creating a new socket. So if there are pending requests, each time a request completes, we tear down one socket and create two more. So the total number of sockets grows exponentially and without regard for any maxSockets settings. This was noticed in https://github.com/nodejs/node/issues/4050. Let's get rid of the extra calls to removeSocket so we only call it once per completed request. PR-URL: https://github.com/nodejs/node/pull/4172 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
* assert: typed array deepequal performance fixClaudio Rodriguez2015-12-211-0/+5
| | | | | | | | | | | | | assert.deepEqual: when actual and expected are typed arrays, wrap them in a new Buffer each to increase performance significantly. PR-URL: https://github.com/nodejs/node/pull/4330 Fixes: https://github.com/nodejs/node/issues/4294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* repl: use String#repeat instead of Array#joinEvan Lucas2015-12-211-2/+4
| | | | | | | | | String#repeat is quite a bit faster than new Array().join(). PR-URL: https://github.com/nodejs/node/pull/3900 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
* module: always decorate thrown errorsBrian White2015-12-192-5/+19
| | | | | | | | | | This provides more information when encountering a syntax or similar error when executing a file with require(). Fixes: https://github.com/nodejs/node/issues/4286 PR-URL: https://github.com/nodejs/node/pull/4287 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* http: do not emit `upgrade` on advertisementFedor Indutny2015-12-172-0/+20
| | | | | | | | | | | | | | Do not emit `upgrade` if the server is just advertising its protocols support as per RFC 7230 Section 6.7. A server MAY send an Upgrade header field in any other response to advertise that it implements support for upgrading to the listed protocols, in order of descending preference, when appropriate for a future request. Fix: https://github.com/nodejs/node/issues/4334 PR-URL: https://github.com/nodejs/node/pull/4337 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* util: pass on additional error() argsBrian White2015-12-171-1/+10
| | | | | | | | | This fixes breakage introduced in 94b9948d63 when writing the max EventEmitter listeners warning to stderr. PR-URL: https://github.com/nodejs/node/pull/4279 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* http: Remove an unnecessary assignmentBo Borgerson2015-12-171-1/+1
| | | | | | | | | | | This just removes an assignment to `ret` of a value that's not used before it's overwritten. Immediately following the assigment is an `if/else` in which both branches assign to `ret` without using it. PR-URL: https://github.com/nodejs/node/pull/4323 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: use arrow functions instead of bindMinwoo Jung2015-12-176-26/+35
| | | | | | | | | | | use `arrow functions` instead of `bind(this)` in order to improve performance through optimizations. PR-URL: https://github.com/nodejs/node/pull/3622 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
* util: use consistent Dates in inspect()Xotic7502015-12-161-2/+2
| | | | | | | Fix: https://github.com/nodejs/node/issues/4314 PR-URL: https://github.com/nodejs/node/pull/4318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor@indutny.com>
* module,src: do not wrap modules with -1 lineOffsetcjihrig2015-12-161-1/+1
| | | | | | | | | | | | | In b799a74709af69daf13901390df9428c4c38adfc and dfee4e3712ac4673b5fc472a8f77ac65bdc65f87 the module wrapping mechanism was changed for better error reporting. However, the changes causes issues with debuggers and profilers. This commit reverts the wrapping changes. Fixes: https://github.com/nodejs/node/issues/4297 PR-URL: https://github.com/nodejs/node/pull/4298 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
* udp: remove a needless instanceof Buffer checkronkorving2015-12-161-2/+1
| | | | | | | | | | | When a string is passed to udpsock.send, it is automatically converted to a Buffer. In that case, it is no longer needed to test whether or not the argument is a Buffer or not. PR-URL: https://github.com/nodejs/node/pull/4301 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
* https: support disabling session cachingFedor Indutny2015-12-121-0/+4
| | | | | | | | | Zero value of `maxCachedSessions` should disable TLS session caching in `https.Agent` PR-URL: https://github.com/nodejs/node/pull/4252 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* tls: introduce `secureContext` for `tls.connect`Fedor Indutny2015-12-111-1/+1
| | | | | | | | Add `secureContext` option to `tls.connect`. It is useful for caching client certificates, key, and CA certificates. PR-URL: https://github.com/nodejs/node/pull/4246 Reviewed-By: James M Snell <jasnell@gmail.com>
* domains: fix handling of uncaught exceptionsJulien Gilli2015-12-111-13/+20
| | | | | | | | | | | | | | | | | | | | | | Fix node exiting due to an exception being thrown rather than emitting an `'uncaughtException'` event on the process object when: 1. no error handler is set on the domain within which an error is thrown 2. an `'uncaughtException'` event listener is set on the process Also fix an issue where the process would not abort in the proper function call if an error is thrown within a domain with no error handler and `--abort-on-uncaught-exception` is used. Finally, change the behavior of --abort-on-uncaught-exception so that, if the domain within which the error is thrown has no error handler, but a domain further up the domains stack has one, the process will not abort. Fixes #3607 and #3653. PR: #3654 PR-URL: https://github.com/nodejs/node/pull/3654 Reviewed-By: Chris Dickinson <chris@neversaw.us>
* doc: Fixing broken links to the v8 wikiTom Gallacher2015-12-111-1/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/4241 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
* repl: display error message when loading directoryPrince J Wesley2015-12-111-0/+3
| | | | | | | | | | | When loading directory instead of file, no error message is displayed. It's good to display error message for this scenario. PR-URL: https://github.com/nodejs/node/pull/4170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
* buffer: add includes() for parity with TypedArrayAlexander Martin2015-12-101-0/+5
| | | | | | | | | | | | | | | | | Add Buffer#includes() by wrapping an indexOf and performing a strict equals check to -1. The includes method takes the search value, byteOffset, and encoding as arguments. The test is a modified version of the indexOf test. Fixes: https://github.com/nodejs/node/issues/3552 PR-URL: https://github.com/nodejs/node/pull/3567 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* repl: fix require('3rdparty') regressionBen Noordhuis2015-12-091-0/+3
| | | | | | | | | | | | | | Fix module loading of third-party modules in the REPL by inheriting module.paths from the REPL's parent module. Commit ee72ee7 ("module,repl: remove repl require() hack") introduced a regression where require() of modules in node_modules directories no longer worked in the REPL (and fortunately only in the REPL.) It turns out we didn't have test coverage for that but we do now. Fixes: https://github.com/nodejs/node/issues/4208 PR-URL: https://github.com/nodejs/node/pull/4215 Reviewed-By: Roman Reiss <me@silverwind.io>
* assert: accommodate ES6 classes that extend ErrorRich Trott2015-12-091-0/+4
| | | | | | | | | `assert.throws()` and `assert.doesNotThrow()` blow up with a `TypeError` if used with an ES6 class that extends Error. Fixes: https://github.com/nodejs/node/issues/3188 PR-URL: https://github.com/nodejs/node/pull/4166 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* tools: add --prof-process flag to node binaryMatt Loring2015-12-082-0/+144
| | | | | | | | | | | This change cleans up outstanding comments on #3032. It improves error handling when no isolate file is provided and adds the --prof-process flag to the node binary which executes the tick processor on the provided isolate file. PR-URL: https://github.com/nodejs/node/pull/4021 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com>
* buffer: fix range checking for slowToStringMatt Loring2015-12-071-5/+26
| | | | | | | | | | | If `start` is not a valid number in the range, then the default value zero will be used. Same way, if `end` is not a valid number in the accepted range, then, by default, the length of the buffer is assumed. Fixes: https://github.com/nodejs/node/issues/2668 Ref: https://github.com/nodejs/node/pull/2919 PR-URL: https://github.com/nodejs/node/pull/4019 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* stream_wrap: error if stream has StringDecoderFedor Indutny2015-12-061-3/+13
| | | | | | | | | | If `.setEncoding` was called on input stream - all emitted `data` will be `String`s instances, not `Buffer`s. This is unacceptable for `StreamWrap`, and should not lead to the crash. Fix: https://github.com/nodejs/node/issues/3970 PR-URL: https://github.com/nodejs/node/pull/4031 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* fs,doc: use `target` instead of `destination`yorkie2015-12-051-6/+6
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/3912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Bert Belder <bertbelder@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* buffer: Prevent Buffer constructor deoptBryce Baril2015-12-061-2/+2
| | | | | | | | | | | | | The Buffer constructor will generally get inlined, but any call to the Buffer constructor for a string without encoding will cause an eager deoptimization of any function that inlined the Buffer constructor. This is due to a an out-of-bounds read on `arguments[1]`. This change prevents that deopt. PR-URL: https://github.com/nodejs/node/pull/4158 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
* http: fix pipeline regressionFedor Indutny2015-12-041-2/+3
| | | | | | | | | | Always check that socket still has the parser. It may be destroyed interim, and we may end up with an uncaught exception. Fix: https://github.com/nodejs/node/issues/3508 PR-URL: https://github.com/nodejs/node-private/pull/5 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
* stream: be less eager with readable flagBrian White2015-12-031-1/+0
| | | | | | | | | | | | | As of 34b535f4c, test-child-process-flush-stdio was failing on CentOS 5 systems in CI due to the change in stream state checking in `child_process`. This commit fixes those failures by making readable streams less eager in setting their readable flag on EOF. Fixes: https://github.com/nodejs/node/issues/4125 PR-URL: https://github.com/nodejs/node/pull/4141 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib,src: ensure '(node:pid)' prefix for stdout loggingMinwoo Jung2015-12-034-10/+24
| | | | | | | | | | Add '(node:pid)' prefix message for stdout logging PR-URL: https://github.com/nodejs/node/pull/3833 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
* meta: remove use of profanity in sourceMyles Borins2015-12-021-1/+1
| | | | | | | | | The CoC requests to avoid the casual use of profanity. PR-URL: https://github.com/nodejs/node/pull/4122 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
* streams: update .readable/.writable to falseBrian White2015-12-022-1/+3
| | | | | | | | | | | | These properties were initially used to determine stream status back in node v0.8 and earlier. Since streams2 however, these properties were *always* true, which can be misleading for example if you are trying to immediately determine whether a Writable stream is still writable or not (to avoid a "write after end" exception). PR-URL: https://github.com/nodejs/node/pull/4083 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
* util: determine object types in C++cjihrig2015-12-021-5/+4
| | | | | | | | | | | Determine object types of regular expressions, Dates, Maps, and Sets in the C++ layer instead of depending on toString() behavior in JavaScript. PR-URL: https://github.com/nodejs/node/pull/4100 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* timers: optimize callback call: bind -> arrowAndrei Sedoi2015-12-021-9/+9
| | | | | | | | ES6 arrow functions are much more efficient than `.bind()` functions. PR-URL: https://github.com/nodejs/node/pull/4038 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
* util: make inspect more reliableEvan Lucas2015-12-021-17/+4
| | | | | | | | | | | | | | | 34a35919e165cba6d5972e004e6b2cbdf2f4c65a added pretty printing for TypedArray, ArrayBuffer, and DataView. This change allows inspecting those across different contexts. Since instanceof does not work across contexts, we can use v8::Value::IsTypedArray, v8::Value::IsArrayBuffer, and v8::Value::IsDataView PR-URL: https://github.com/nodejs/node/pull/4098 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* repl: allow leading period in multiline inputZirak2015-12-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | When writing multiline input, one can't chain function calls as if the lines begin with a period, since those are treated as REPL commands. Before: > ([0, 1, 2] ... .map(x => x + 1)) Invalid REPL keyword After: > ([0, 1, 2] ... .map(x => x + 1)) [ 1, 2, 3 ] PR-URL: https://github.com/nodejs/node/pull/3835 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
* buffer: fix writeInt{B,L}E for some neg valuesPeter A. Bigot2015-12-011-4/+10
| | | | | | | | | | | The algorithm used to convert negative values to hex generates incorrect values when the low byte(s) of the value are zero because a carried subtraction is applied prematurely. Fixes: https://github.com/nodejs/node/issues/3992 PR-URL: https://github.com/nodejs/node/pull/3994 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
* child_process: flush consuming streamsDave2015-12-011-1/+1
| | | | | | | | | | | | | | | | | When a client calls read() with a nonzero argument on a Socket, that Socket sets this._consuming to true. It never sets this._consuming back to false. ChildProcess.flushStdio() currently doesn't flush any streams where _consuming is truthy. But, that means that it never flushes any stream that has ever been read from. This prevents a child process from ever closing if one of its streams has been read from, causing issue #4049. This commit allows consuming streams to be flushed, and the child process to emit a close event. Fixes: https://github.com/nodejs/node/issues/4049 PR-URL: https://github.com/nodejs/node/pull/4071 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* util: fix constructor/instanceof checksBrian White2015-11-301-8/+12
| | | | | | | | | | | | | These new checks are similar to the one introduced in 089d68861, but for other types of objects. Specifically, if an object was created in a different context, the constructor object will not be the same as the constructor object in the current context, so we have to compare constructor names instead. PR-URL: https://github.com/nodejs/node/pull/3385 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
* util: move .decorateErrorStack to internal/utilBen Noordhuis2015-11-303-19/+23
| | | | | | | | | | | Move the method that was added in commit 8ca412b from earlier this month from lib/util.js to lib/internal/util.js. Avoids exposing a method that we may not wish to expose just yet, seeing how it relies on implementation details. PR-URL: https://github.com/nodejs/node/pull/4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* module,repl: remove repl require() hackBen Noordhuis2015-11-304-38/+39
| | | | | | | | | Remove a hack that was introduced in commit bb6d468d from November 2010. This is groundwork for a follow-up commit that makes it possible to use internal modules in lib/repl.js. PR-URL: https://github.com/nodejs/node/pull/4026 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* path: make format() consistent and more functionalNathan Woltman2015-11-271-23/+13
| | | | | | | | | | | | | | Make the win32 and posix versions of path.format() consistent in when they add a directory separator between the dir and base parts of the path (always add it unless the dir part is the same as the root). Also, path.format() is now more functional in that it uses the name and ext parts of the path if the base part is left out and it uses the root part if the dir part is left out. Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2408
* repl: attach location info to syntax errorscjihrig2015-11-251-0/+1
| | | | | | | | | | | | Currently, when a file with a syntax error is imported in the REPL, no information is provided on the error's location. This commit adds the error's location to the stack trace. Refs: https://github.com/nodejs/node/issues/2762 Refs: https://github.com/nodejs/node/issues/3411 Refs: https://github.com/nodejs/node/issues/3784 PR-URL: https://github.com/nodejs/node/pull/4013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* util: add decorateErrorStack()cjihrig2015-11-251-0/+11
| | | | | | | | | | This commit adds the decorateErrorStack() method. This function uses the internal util's getHiddenValue() method to extract arrow messages from error objects and attach them to the error's stack trace. PR-URL: https://github.com/nodejs/node/pull/4013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* buffer: default to UTF8 in byteLength()Tom Gallacher2015-11-251-0/+1
| | | | | | | | | | | If an undefined encoding is passed to byteLength(), assume that it is UTF8 immediately. This yields a small speedup, as it prevents string operations on the encoding argument. PR-URL: https://github.com/nodejs/node/pull/4010 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
* net: add local address/port for better errorsJan Schär2015-11-241-3/+7
| | | | | | | | | | Adds localAddress and localPort to req so we have better error messages. Also fixes a case where ex is used before it is declared. PR-URL: https://github.com/nodejs/node/pull/3946 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* util,src: allow lookup of hidden valuescjihrig2015-11-241-0/+3
| | | | | | | | | This commit adds an internal util method that makes hidden values in the C++ layer visible in JS. PR-URL: https://github.com/nodejs/node/pull/3988 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
* net: small code cleanupJan Schär2015-11-201-1/+0
| | | | | | | | | | `options` is already a param of the function. PR-URL: https://github.com/nodejs/node/pull/3943 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* module: fix column offsets in errorsTristian Flanagan2015-11-201-2/+2
| | | | | | | | | | | | | Because Node modules are wrapped, errors on the first line of a file leak the wrapper to the user and report the wrong column number. This commit adds a line break to the module wrapper so that the first line is treated the same as all other lines. To compensate for the additional line, a line offset of -1 is also applied to errors. Fixes: https://github.com/nodejs/node/issues/2860 PR-URL: https://github.com/nodejs/node/pull/2867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* buffer: move checkFloat from lib into srcMatt Loring2015-11-201-16/+12
| | | | | | | | | The type and range checks performed by this function can be done more efficiently in native code. PR-URL: https://github.com/nodejs/node/pull/3763 Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: add 'pid' prefix in `internal/util`Minwoo Jung2015-11-201-1/+1
| | | | | | | | | | | | | This PR improves `prefix` in `util` that we've agreed on https://github.com/nodejs/node/pull/3833 (separate code for javascript to move the printing function to C++ directly) PR-URL: https://github.com/nodejs/node/pull/3878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* readline: deprecate undocumented exportscjihrig2015-11-192-391/+409
| | | | | | | | | | | | | | This commit moves several of readline's undocumented functions into an internal module. Specifically, isFullWidthCodePoint, stripVTControlCharacters, getStringWidth, and emitKeys are moved to the internal module. The existing public exports of the first three functions are given a deprecation notice. Refs: https://github.com/nodejs/node/pull/3847 Fixes: https://github.com/nodejs/node/issues/3836 PR-URL: https://github.com/nodejs/node/pull/3862 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
* util: remove pumpWyatt Preul2015-11-182-39/+1
| | | | | | | | Remove util.pump and associated tests PR-URL: https://github.com/nodejs/node/pull/2531 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
View Lorry Controller Status