Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | test: improve internal/buffer.js test coverage | Masashi Hirano | 2018-06-04 | 1 | -1/+1 |
| | | | | | | | | | | | Added tests buffer.js methods to write 48 bit value to improve test coverage. PR-URL: https://github.com/nodejs/node/pull/21061 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> | ||||
* | buffer: do not always use defaults | Ruben Bridgewater | 2018-04-29 | 1 | -0/+165 |
The Buffer#(read|write)U?Int(B|L)E functions should not use a default value. This is very likely a bug and it was never documented that way. Besides that this also improves the tests by adding more tests and by refactoring them to less code lines. PR-URL: https://github.com/nodejs/node/pull/20054 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> |