summaryrefslogtreecommitdiff
path: root/test
Commit message (Collapse)AuthorAgeFilesLines
* test: delete test/pummel/test-repl-empty-maybelocal-crash.jsDarshan Sen2022-06-011-20/+0
| | | | | | | | | | | | | | | | | It was disconnecting the runners from the CI server. Not worth having a resource-intensive test for this kind of an edge cases. Fixes: https://github.com/nodejs/node/issues/42719 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42720 Backport-PR-URL: https://github.com/nodejs/node/pull/42967 Fixes: https://github.com/nodejs/node/issues/42719 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* src,inspector: fix empty MaybeLocal crashDarshan Sen2022-06-011-0/+20
| | | | | | | | | | | | | | | | | | Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: https://github.com/nodejs/node/issues/42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42409 Backport-PR-URL: https://github.com/nodejs/node/pull/42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* esm: fix base URL for network importsBradley Farias2022-04-231-0/+15
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/42131 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* esm: fix relative imports for httpsBradley Farias2022-04-231-0/+12
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42119 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* crypto: fix auth tag length error when mode != GCMTobias Nießen2022-04-231-1/+15
| | | | | PR-URL: https://github.com/nodejs/node/pull/42383 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test,crypto: add and update empty passphrase regression testsDarshan Sen2022-04-231-33/+54
| | | | | | | | | Refs: https://github.com/openssl/openssl/pull/17507 Refs: https://github.com/nodejs/node/issues/41428 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42319 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* http: trace http client by perf_hookstheanarkh2022-04-231-6/+19
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42345 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* worker: do not send message if port is closingRich Trott2022-04-231-0/+8
| | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/42296 PR-URL: https://github.com/nodejs/node/pull/42357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: improve https_renew_cert.sh scriptTobias Nießen2022-04-232-15/+22
| | | | | | | | | | | | | | | | | | | | | | - To avoid unnecessarily large diffs, only generate a new private key if necessary. Otherwise, reuse the existing private key and only issue a new certificate. - Remove an unnecessary conversion step using openssl rsa and the intermediate rsa.pem and csr.pem files. - Extend the certificate validity from 1 year to 10 years. - Show a text representation of the issued certificate upon completion such that the user can verify the validity. - Make the script executable. - Use "#!/usr/bin/env bash" instead of "#!/bin/bash". - Allow the script to be called from any directory. Refs: https://github.com/nodejs/node/pull/42342 Refs: https://github.com/nodejs/node/pull/37990 PR-URL: https://github.com/nodejs/node/pull/42343 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* esm: make extension-less errors in type:module actionableBradley Farias2022-04-231-1/+5
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42301 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: improve _http_incoming.js coverageYoshiki Kurihara2022-04-231-0/+27
| | | | | | PR-URL: https://github.com/nodejs/node/pull/42211 Refs: https://coverage.nodejs.org/coverage-010cb714161102de/lib/_http_incoming.js.html Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: improve _http_outgoing coverageYoshiki Kurihara2022-04-231-0/+10
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42213 Refs: https://coverage.nodejs.org/coverage-29bb2bb57d2a993e/lib/_http_outgoing.js.html Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* esm: improve typings and code coverageBradley Farias2022-04-231-2/+5
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42305 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* url: preserve null char in WHATWG URL errorsRich Trott2022-04-231-0/+8
| | | | | | | | | | | | A null character in the middle of an invalid URL was resulting in an error message that truncated the input string. This preserves the entire input string in the error message. Refs: https://github.com/nodejs/node/issues/39592 PR-URL: https://github.com/nodejs/node/pull/42263 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: add test case for reverted 17.7 regressionRich Trott2022-04-231-0/+1
| | | | | | | | | | | | | Refs: https://github.com/nodejs/node/issues/42279 PR-URL: https://github.com/nodejs/node/pull/42283 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* esm: add runtime warning for specifier resolution flagGeoffrey Booth2022-04-231-0/+24
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/42252 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: use global webcrypto for WPT testsAntoine du Hamel2022-04-231-40/+1
| | | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42236 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* lib: fix AsyncResource.bind not using 'this' from the caller by defaultRoch Devost2022-04-231-1/+6
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42177 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* string_decoder: fix crash when calling __proto__.write()Darshan Sen2022-04-231-0/+7
| | | | | | | | | | This makes the function throw an exception from JS instead of crashing. Fixes: https://github.com/nodejs/node/issues/41949 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42062 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* url: trim leading and trailing C0 control charsRich Trott2022-04-231-0/+15
| | | | | | | | | | | | | | | | | | Emulate the WHATWHG URL parse behavior of trimming leading and trailing C0 control characters. This moves url.parse() slightly closer to WHATWHG URL behavior. The current behavior is possibly insecure for some uses. (The url.parse() API is marked as Legacy and the documentation specifically says it has known bugs and insecure behaviors. Still this change makes a lot of sense.) This issue was reported by P0cas. https://github.com/P0cas PR-URL: https://github.com/nodejs/node/pull/42196 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* src: return proper URLs from node_api_get_module_file_nameAnna Henningsen2022-04-231-7/+38
| | | | | | | | | | Using `file://${path}` does not properly escape special URL characters. PR-URL: https://github.com/nodejs/node/pull/41758 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
* http2: add edge case to GOAWAY requestRafael Silva2022-04-231-0/+22
| | | | | PR-URL: https://github.com/nodejs/node/pull/42190 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* test: cover 32-bit sizes in generatePrimeTobias Nießen2022-04-231-1/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* src: skip revoke_data_object if uuid is not foundXuguang Mei2022-04-231-0/+4
| | | | | | | | | | | | Fix: https://github.com/nodejs/node/issues/42206 PR-URL: https://github.com/nodejs/node/pull/42212 Fixes: https://github.com/nodejs/node/issues/42206 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* loader: fix esm resolve for symlink fileXuguang Mei2022-04-231-0/+40
| | | | | | | | | Fix: https://github.com/nodejs/node/issues/42195 PR-URL: https://github.com/nodejs/node/pull/42197 Fixes: https://github.com/nodejs/node/issues/42195 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* test: fix test-process-env-tz.js by using RegExpKhaidi Chu2022-04-231-9/+9
| | | | | | | | | | | | | Not all environment returns 'Central European Summer Time', 'British Summer Time' and 'Coordinated Universal Time'. E.g. Some environment like Chinese returns '中欧夏令时间', '英国夏令时间' and '协调世界时'. PR-URL: https://github.com/nodejs/node/pull/42113 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* stream: use .chunk when calling adapters's writevXuguang Mei2022-04-232-0/+400
| | | | | | | | | Fix: https://github.com/nodejs/node/issues/42157 PR-URL: https://github.com/nodejs/node/pull/42161 Fixes: https://github.com/nodejs/node/issues/42157 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
* http2: close stream and session on frameErrorRafael Silva2022-04-232-2/+53
| | | | | PR-URL: https://github.com/nodejs/node/pull/42147 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: update V8 trace events test expectationsNikolaos Papaspyrou2022-04-232-2/+2
| | | | | | | | | | | | | | | | The event "V8.GCScavenger" is soon to be deprecated. Most of V8 trace events are either behind flags and disabled by default, or are emitted infrequently. Instead of replacing "V8.GCScavenger" with some other random event, this patch updates the tests to check that there is some event in the category "v8" whose name starts with "V8.". PR-URL: https://github.com/nodejs/node/pull/42120 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* http: add default argument for Agent.prototype.getName小菜2022-04-232-1/+13
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41906 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
* fs: adjust default `length` for `fs.readSync` and fsPromises/`read`Livia Medeiros2022-04-231-12/+42
| | | | | | | Makes default length reasonable when nonzero offset is set. PR-URL: https://github.com/nodejs/node/pull/42128 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* crypto: validate `this` value for `webcrypto.getRandomValues`Antoine du Hamel2022-04-237-26/+42
| | | | | | PR-URL: https://github.com/nodejs/node/pull/41760 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* crypto: add KeyObject.prototype.equals methodFilip Skokan2022-04-231-0/+49
| | | | | PR-URL: https://github.com/nodejs/node/pull/42093 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* lib: clean after the cancel algorithm throw errorGang Chen2022-04-231-0/+30
| | | | | PR-URL: https://github.com/nodejs/node/pull/41366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
* perf_hooks: do not return all entries with getEntriesBy[Name|Type]Xuguang Mei2022-04-231-0/+15
| | | | | | | | Fix: https://github.com/nodejs/node/issues/42028 PR-URL: https://github.com/nodejs/node/pull/42104 Fixes: https://github.com/nodejs/node/issues/42028 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
* test: deflake test-common-expect-warningLuigi Pinca2022-04-231-1/+3
| | | | | | | | | | The subprocess might exit before the data is flushed. Run the assertion after the `'end'` event is emitted. PR-URL: https://github.com/nodejs/node/pull/42046 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* doc,tools: improve navigability of API docsPaolo Insogna2022-04-231-1/+2
| | | | | PR-URL: https://github.com/nodejs/node/pull/41404 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* process: fix named report exportmadflow2022-04-231-1/+2
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41861 Fixes: https://github.com/nodejs/node/issues/41774 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* test: validate `EventEmitterAsyncResource` methods throw on invalid thisYoshiki Kurihara2022-04-231-0/+27
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42041 Refs: https://coverage.nodejs.org/coverage-26f9a91cc9b178d3/lib/events.js.html#L156 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* repl: remove preview when press escapemeixg2022-04-231-1/+1
| | | | | | | | | | | | | Fix: https://github.com/nodejs/node/issues/42040 PR-URL: https://github.com/nodejs/node/pull/42053 Fixes: https://github.com/nodejs/node/issues/42040 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
* test: increase Fibonacci argument to 40Rich Trott2022-04-231-8/+1
| | | | | | | | | Fixes: https://github.com/nodejs/node/issues/34031 PR-URL: https://github.com/nodejs/node/pull/42055 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
* perf_hooks: use arrays to store EntryBuffersXuguang Mei2022-04-231-0/+35
| | | | | | | | | | | | Also order entries by startTime when calling getEntriesByType. Fix: https://github.com/nodejs/node/issues/42004 Fix: https://github.com/nodejs/node/issues/42024 PR-URL: https://github.com/nodejs/node/pull/42032 Fixes: https://github.com/nodejs/node/issues/42004 Fixes: https://github.com/nodejs/node/issues/42024 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: enable es2022 env in ESLint configMichaël Zasso2022-04-231-5/+0
| | | | | | | | | | | | | | | This adds more globals to the set known by ESLint. PR-URL: https://github.com/nodejs/node/pull/42043 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
* tools: lint deprecation codesAntoine du Hamel2022-04-232-0/+70
| | | | | | | Add a rule to make sure deprecation codes are in order. PR-URL: https://github.com/nodejs/node/pull/41992 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* esm: improve `fetch_module` test coverage and remove hackAntoine du Hamel2022-04-232-5/+54
| | | | | PR-URL: https://github.com/nodejs/node/pull/41947 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
* test: remove test-stdout-close-catch flaky designationRich Trott2022-04-231-2/+0
| | | | | | | | | | | | | The corresponding issue was closed 3 months ago and it has apparently been a long time since the failure has been seen in CI. Refs: https://github.com/nodejs/node/issues/28803 PR-URL: https://github.com/nodejs/node/pull/42045 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
* esm: remove erroneous `context.parentURL` property passed to `load` hookJacob Smith2022-04-231-0/+76
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41975 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
* tools: fix bugs in prefer-primordials linter ruleAntoine du Hamel2022-04-231-0/+28
| | | | | | | | The ESLint rule would repport false positive if code is using an identifier that happens to have the same name as a primordials member. PR-URL: https://github.com/nodejs/node/pull/42010 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* test: check that fetch globals are disabled by defaultMichaël Zasso2022-04-231-0/+9
| | | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/42015 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
* test: improve vm test coverageYoshiki Kurihara2022-04-231-0/+8
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/41847 Refs: https://coverage.nodejs.org/coverage-cd5689eed3be54a5/lib/vm.js.html#L364 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
View Lorry Controller Status