summaryrefslogtreecommitdiff
path: root/vcbuild.bat
Commit message (Collapse)AuthorAgeFilesLines
* build,win: use x64 Node when building for ARM64Dennis Ameling2020-08-201-1/+20
| | | | | | | | | | | | Uses x64 node executable for running .js files in arm64 cross-compilation scenarios. MSI can now be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/34009 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build: fix test-ci-js task in MakefileRich Trott2020-07-291-2/+2
| | | | | | | | | | Move benchmark CI to native suite since it requires building an addon. Refs: https://github.com/nodejs/node/issues/34427#issuecomment-660760789 PR-URL: https://github.com/nodejs/node/pull/34433 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* build: do not run benchmark tests on 'make test'Rich Trott2020-07-291-3/+5
| | | | | | | | | | | Fixes: https://github.com/nodejs/node/issues/34427 PR-URL: https://github.com/nodejs/node/pull/34434 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build: add benchmark tests to CI runsRich Trott2020-07-291-1/+1
| | | | | | | | Closes: https://github.com/nodejs/node/issues/34321 PR-URL: https://github.com/nodejs/node/pull/34288 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
* tools: remove lint-js.jsRich Trott2020-07-161-9/+1
| | | | | | | | | | | | | | | | | | | | | | lint-js.js was implemented before ESLint had a caching feature. It is now only used in CI. Let's remove it on the following grounds: * It results in occasional (and puzzling) yellow CI runs for node-test-linter because the tap file is corrupted somehow. Interleaved maybe? I don't know, but a simple solution is removing it and running ESLint directly. * On my local laptop, it reduces the linting from about 75 seconds to about 55 seconds. This kind of savings is not worth the added complexity and the instability noted above. PR-URL: https://github.com/nodejs/node/pull/30955 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* build,win: add support for MSVC cross-compilationRichard Townsend2020-06-021-0/+1
| | | | | | | | | | | * Fixes cases in icutools where commands were issued without .exe * Changes to build scripts * Add /fp:strict flag so that MSVC's floating point behaves correctly * Enables marmasm PR-URL: https://github.com/nodejs/node/pull/32867 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com>
* Revert "src: add test/abort build tasks"Richard Lau2020-05-071-26/+4
| | | | | | | | | | This reverts commit e08ac095690015a8c488e05251e05feb2acc57a0. PR-URL: https://github.com/nodejs/node/pull/33196 Refs: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* build: fix vcbuild error for missing Visual StudioThomas2020-04-281-1/+1
| | | | | | | | | | | | | | The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
* win,build: set exit_code on configure failureBartlomiej Brzozowski2020-03-301-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/32205 Fixes: https://github.com/nodejs/node/issues/31573 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: add test/abort build tasksChristian Niederer2020-03-301-4/+26
| | | | | | | | | | | | The Aliased*Array overflow check test introduced a dependency to a compiled artifact. Add this artifact to the build process in a similar fashion as test/addons and test/js-native-api do. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* build: remove enable_vtune from vcbuild.batRichard Lau2020-01-151-5/+1
| | | | | | | | | | vcbuild.bat wasn't updated when vtune support was removed in https://github.com/nodejs/node/pull/28522 Refs: https://github.com/nodejs/node/pull/28522 PR-URL: https://github.com/nodejs/node/pull/31338 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: add vs2019 to vcbuild.bat helpRichard Lau2020-01-151-1/+1
| | | | | | PR-URL: https://github.com/nodejs/node/pull/31338 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: fix goto exit in vcbuildJoão Reis2019-12-141-0/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/30931 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build,win: support building MSI with VS2019João Reis2019-12-131-3/+5
| | | | | | | | | | | Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible. PR-URL: https://github.com/nodejs/node/pull/30895 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: propagate error codes in vcbuildJoão Reis2019-12-021-1/+4
| | | | | | | | | | Don't exit vcbuild with error code 0 when cctest fails. PR-URL: https://github.com/nodejs/node/pull/30724 Refs: https://github.com/nodejs/build/issues/1996 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: add test-ci-native and test-ci-jsJoão Reis2019-12-021-4/+9
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/30724 Refs: https://github.com/nodejs/build/issues/1996 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: fix detection of Visual Studio 2017Richard Lau2019-11-041-0/+4
| | | | | | | | | | | | | | | | | | When run in a Visual Studio 2017 command prompt the `VCINSTALLDIR` environment variable will be already set and is not cleared by the `tools/msvs/vswhere_usability_wrapper.cmd` utility when it fails to find Visual Studio 2019. This causes `vcbuild.bat` to incorrectly assume Visual Studio 2019 and generate an incompatible configuration. Clearing the value of `VCINSTALLDIR` before calling the utility fixes the detection logic. PR-URL: https://github.com/nodejs/node/pull/30119 Fixes: https://github.com/nodejs/node/issues/30118 Refs: https://github.com/nodejs/node/pull/30022 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build: vcbuild uses default Python, not Py2João Reis2019-10-251-3/+0
| | | | | | | | | | | vcbuild now searches for the first python.exe found, and uses it, where it used to look for Python 2 first. PR-URL: https://github.com/nodejs/node/pull/30091 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* build: default Windows build to Visual Studio 2019Michaël Zasso2019-10-201-32/+32
| | | | | | | | | | | | | Building and testing Node.js with Visual Studio 2019 is now working as expected. Fallback to VS 2017 if VS 2019 was not found. Fixes: https://github.com/nodejs/node/issues/27214 PR-URL: https://github.com/nodejs/node/pull/30022 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
* build: make full-icu the default for releasesRichard Lau2019-10-101-2/+2
| | | | | | | | | | | | | | | | | | | Release builds specifically set the `--with-intl=` configure option instead of relying on the default. Explicitly set to `full-icu`. Refs: https://github.com/nodejs/node/pull/29522 PR-URL: https://github.com/nodejs/node/pull/29887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* build,win: goto lint only after defining node_exeJoão Reis2019-09-271-5/+4
| | | | | | | | | | | | | | When running `vcbuild lint` on a new prompt where vcbuild was not run before, `%node_exe%` was not defined and `eslint.js`, `lint-js.js` and `lint-md.js` would be run directly using the program defined in Windows (usually the Windows Scripting Host or Notepad). This moves the goto statement to after `%node_exe%` is defined. Fixes: https://github.com/nodejs/node/issues/29602 PR-URL: https://github.com/nodejs/node/pull/29616 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* build,win: accept Python 3 if 2 is not availableJoão Reis2019-09-021-0/+3
| | | | | | | | | If there is no Python 2 available, use Python 3. This allows to test running configure with Python 3. PR-URL: https://github.com/nodejs/node/pull/29236 Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build: add a testclean targetDaniel Bevenius2019-08-161-0/+8
| | | | | | | | | | | This commit adds a target named testclean to allow for cleaning the temporary files generated during a test run without having to use the clean target. PR-URL: https://github.com/nodejs/node/pull/29094 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,tools: support building with Visual Studio 2019Michaël Zasso2019-07-271-2/+39
| | | | | | | | Add a `vs2019` option to `vcbuild.bat` to use VS 2019 instead of VS 2017 PR-URL: https://github.com/nodejs/node/pull/28781 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
* build,win: delegate lint-cpp to makeRefael Ackermann2019-06-131-43/+9
| | | | | | | | | * look for GNU Make in the Path or use wsl PR-URL: https://github.com/nodejs/node/pull/28102 Fixes: https://github.com/nodejs/node/issues/28086 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build,win: create junction instead of symlink to `out\%config%`Refael Ackermann2019-05-251-2/+3
| | | | | PR-URL: https://github.com/nodejs/node/pull/27736 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* build: add arm64 to vcbuild.bat help messageJon Kunkee2019-05-171-1/+1
| | | | | | | | PR-URL: https://github.com/nodejs/node/pull/27683 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* build,win: deprecate `vcbuild test-ci`Refael Ackermann2019-04-221-2/+3
| | | | | | PR-URL: https://github.com/nodejs/node/pull/27231 Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* deps,test: bump googletest to 39f72ea6f5Refael Ackermann2019-04-221-1/+1
| | | | | | | Refs: https://github.com/google/googletest/tree/39f72ea6f5cd458860b563d7bcb7ea67546e6ea3 PR-URL: https://github.com/nodejs/node/pull/27231 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* build,win: bail vcbuild if mklink failsRefael Ackermann2019-04-201-0/+3
| | | | | PR-URL: https://github.com/nodejs/node/pull/27216 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* build,win: rename node.lib to libnode.libRefael Ackermann2019-04-191-3/+3
| | | | | | | eliminate the need for `rename_node_bin_win` PR-URL: https://github.com/nodejs/node/pull/27150 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* build: run `mkcodecache` as an actionRefael Ackermann2019-04-161-0/+1
| | | | | | | | * fix test-code-cache (for the common cases) * deprecate `configure --code-cache-path` PR-URL: https://github.com/nodejs/node/pull/27161 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
* build,win: put all compilation artifacts into `out`Refael Ackermann2019-04-121-8/+11
| | | | | | | | | * Add symlink from Release to out\Release for backward compat PR-URL: https://github.com/nodejs/node/pull/27149 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
* build: remove unused label from vcbuild.batBen Noordhuis2019-03-301-5/+1
| | | | | | | | | | Remove the :wix-not-found label and harmonize the spelling of "WiX". PR-URL: https://github.com/nodejs/node/pull/26901 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
* build,win: simplify new `msbuild_arg` optionRefael Ackermann2019-03-071-3/+4
| | | | | | | | | PR-URL: https://github.com/nodejs/node/pull/26431 Refs: https://github.com/nodejs/node/pull/25994 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* win,build: add ARM64 support to vcbuild.batJon Kunkee2019-03-041-1/+4
| | | | | PR-URL: https://github.com/nodejs/node/pull/25995 Reviewed-By: João Reis <reis@janeasystems.com>
* win,build: add arbitrary and binlog optionsJon Kunkee2019-03-041-1/+8
| | | | | | | | | | | | | | | | | This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: https://github.com/nodejs/node/pull/25994 Reviewed-By: João Reis <reis@janeasystems.com>
* build,win: emit MSBuild summaryRefael Ackermann2019-02-141-1/+1
| | | | | PR-URL: https://github.com/nodejs/node/pull/25931 Reviewed-By: João Reis <reis@janeasystems.com>
* build,win: always build with PCHRefael Ackermann2019-02-141-6/+2
| | | | | PR-URL: https://github.com/nodejs/node/pull/25931 Reviewed-By: João Reis <reis@janeasystems.com>
* win, build: fix building addons on WindowsBartosz Sosnowski2018-12-311-2/+2
| | | | | | | | | | | Building addons would fail because addon-verify.js dependencies from tools\doc where not installed. This fixes this issue by installing those dependencies if addons are to be built. Fixes: https://github.com/nodejs/node/issues/25096 PR-URL: https://github.com/nodejs/node/pull/25108 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
* tools: report unused disable-directives for ESLintRich Trott2018-12-211-1/+1
| | | | | | | | | | | | Refs: https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives PR-URL: https://github.com/nodejs/node/pull/25119 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* build,win: pack the install-tools scripts for distRefael Ackermann2018-12-051-26/+29
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/24233 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* test: partition N-API testsGabriel Schulhof2018-12-041-15/+40
| | | | | | | | | | Partition test/addons-napi into test/js-native-api and test/node-api to isolate the Node.js-agnostic portion of the N-API tests from the Node.js-specific portion. PR-URL: https://github.com/nodejs/node/pull/24557 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
* win, build: skip building cctest by defaultBartosz Sosnowski2018-11-291-4/+12
| | | | | | | | | vcbuild will build cctest only if it will be run, or for CI and release builds PR-URL: https://github.com/nodejs/node/pull/21408 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
* test: move benchmark tests out of main test suiteRich Trott2018-11-101-1/+2
| | | | | | | | | | | | | | Move benchmark tests (which are slow) out of the main test suite. We can hopefully add them to node-daily-master so that they are still run daily on CI. PR-URL: https://github.com/nodejs/node/pull/24265 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* doc: remove GA trackingBen Noordhuis2018-10-041-1/+1
| | | | | | | | | | | | | | | | | The Google Analytics tracking wasn't wholly uncontroversial and hasn't been used in practice. Remove it. PR-URL: https://github.com/nodejs/node/pull/23083 Fixes: https://github.com/nodejs/node/issues/22652 Refs: https://github.com/nodejs/node/pull/6601 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* build: exclude npm test directories on WindowsRichard Lau2018-10-021-4/+14
| | | | | | | | | | | | | npm test directories are excluded on other platforms by `tools/install.py`. Do the same on Windows. Fixes: https://github.com/nodejs/node/issues/22901 PR-URL: https://github.com/nodejs/node/pull/23001 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build: make config verbose on CIconfig-verbose-in-CIRefael Ackermann2018-09-211-0/+1
| | | | | | | PR-URL: https://github.com/nodejs/node/pull/22935 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* src: deprecate global COUNTER_* and remove perfctrJames M Snell2018-09-191-10/+2
| | | | | | | | | | | | | | | | | | To support Performance Counters on Windows, a number of global `COUNTER_` methods were added that are undocumented and really only intended to be used internally by Node.js. Unfortunately, the perfctr support apparently hasn't even worked for quite a while and no one has even complained. This removes the perfctr support and replaces the global functions with deprecated non-ops for now, with the intent of removing those outright in the next major release cycle. PR-URL: https://github.com/nodejs/node/pull/22485 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
* build: skip cctest on Windows shared lib buildYihong Wang2018-09-171-0/+1
| | | | | | | | | | | | | cctest depends on some internal APIs which don't declare `__declspec(dllexport)` and causes build failure when building node as shared lib on Windows. Since we already have good test coverage in static lib, we decide to skip the cctest in shared lib build on Windows. Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/21228 Reviewed-By: Refael Ackermann <refack@gmail.com>