From 975f6c1f7077fd33db95eaeee6ccfa49e4a29348 Mon Sep 17 00:00:00 2001 From: cjihrig Date: Thu, 3 May 2018 14:40:48 -0400 Subject: fs: move fs/promises to fs.promises PR-URL: https://github.com/nodejs/node/pull/20504 Refs: https://github.com/nodejs/TSC/issues/389 Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: James M Snell Reviewed-By: Myles Borins Reviewed-By: Shingo Inoue Reviewed-By: Joyee Cheung Reviewed-By: Tiancheng "Timothy" Gu Reviewed-By: Ali Ijaz Sheikh --- benchmark/fs/bench-stat-promise.js | 2 +- doc/api/fs.md | 4 +- lib/fs.js | 18 +- lib/fs/promises.js | 520 --------------------- lib/internal/fs.js | 408 ---------------- lib/internal/fs/promises.js | 517 ++++++++++++++++++++ lib/internal/fs/utils.js | 408 ++++++++++++++++ lib/internal/modules/cjs/loader.js | 2 +- lib/internal/modules/esm/default_resolve.js | 2 +- lib/internal/process/stdio.js | 2 +- node.gyp | 4 +- test/parallel/test-fs-filehandle.js | 2 +- test/parallel/test-fs-open-flags.js | 2 +- .../test-fs-promises-file-handle-append-file.js | 4 +- .../parallel/test-fs-promises-file-handle-chmod.js | 4 +- test/parallel/test-fs-promises-file-handle-read.js | 4 +- .../test-fs-promises-file-handle-readFile.js | 4 +- test/parallel/test-fs-promises-file-handle-stat.js | 4 +- .../parallel/test-fs-promises-file-handle-write.js | 4 +- .../test-fs-promises-file-handle-writeFile.js | 4 +- test/parallel/test-fs-promises-readfile.js | 2 +- test/parallel/test-fs-promises-writefile.js | 2 +- test/parallel/test-fs-promises.js | 2 +- test/parallel/test-fs-syncwritestream.js | 4 +- test/parallel/test-internal-fs-syncwritestream.js | 2 +- test/parallel/test-internal-fs.js | 2 +- test/sequential/test-async-wrap-getasyncid.js | 2 +- 27 files changed, 974 insertions(+), 961 deletions(-) delete mode 100644 lib/fs/promises.js delete mode 100644 lib/internal/fs.js create mode 100644 lib/internal/fs/promises.js create mode 100644 lib/internal/fs/utils.js diff --git a/benchmark/fs/bench-stat-promise.js b/benchmark/fs/bench-stat-promise.js index b031745572..96c7058fa6 100644 --- a/benchmark/fs/bench-stat-promise.js +++ b/benchmark/fs/bench-stat-promise.js @@ -1,7 +1,7 @@ 'use strict'; const common = require('../common'); -const fsPromises = require('fs/promises'); +const fsPromises = require('fs').promises; const bench = common.createBenchmark(main, { n: [20e4], diff --git a/doc/api/fs.md b/doc/api/fs.md index bace6d9483..30d6729d48 100644 --- a/doc/api/fs.md +++ b/doc/api/fs.md @@ -3382,9 +3382,9 @@ Synchronous versions of [`fs.write()`][]. Returns the number of bytes written. > Stability: 1 - Experimental -The `fs/promises` API provides an alternative set of asynchronous file system +The `fs.promises` API provides an alternative set of asynchronous file system methods that return `Promise` objects rather than using callbacks. The -API is accessible via `require('fs/promises')`. +API is accessible via `require('fs').promises`. ### class: FileHandle