From 6f5655a18e51f739b382cc99083156ac3f9724c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Wed, 21 Sep 2022 15:47:37 +0200 Subject: deps: always define V8_EXPORT_PRIVATE as no-op dllexport introduces issues when compiling with MSVC. PR-URL: https://github.com/nodejs/node/pull/47251 Reviewed-By: Yagiz Nizipli Reviewed-By: Jiawen Geng Reviewed-By: Rafael Gonzaga Reviewed-By: Richard Lau --- deps/v8/src/base/macros.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'deps') diff --git a/deps/v8/src/base/macros.h b/deps/v8/src/base/macros.h index cd5b91f745..c267b8f1e9 100644 --- a/deps/v8/src/base/macros.h +++ b/deps/v8/src/base/macros.h @@ -389,9 +389,9 @@ bool is_inbounds(float_t v) { // Setup for Windows shared library export. #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllexport) +#define V8_EXPORT_PRIVATE #elif USING_V8_SHARED -#define V8_EXPORT_PRIVATE __declspec(dllimport) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif // BUILDING_V8_SHARED @@ -401,7 +401,7 @@ bool is_inbounds(float_t v) { // Setup for Linux shared library export. #if V8_HAS_ATTRIBUTE_VISIBILITY #ifdef BUILDING_V8_SHARED -#define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) +#define V8_EXPORT_PRIVATE #else #define V8_EXPORT_PRIVATE #endif -- cgit v1.2.1