From b705b73e46193c7691be40b732330a49affacedb Mon Sep 17 00:00:00 2001 From: Gabriel Wicke Date: Thu, 25 Sep 2014 09:59:18 -0700 Subject: url: make query() consistent Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. Fixes: https://github.com/joyent/node/issues/8332 Reviewed-by: Trevor Norris --- doc/api/url.markdown | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'doc/api/url.markdown') diff --git a/doc/api/url.markdown b/doc/api/url.markdown index e6a43f72bc..6b8ff9d507 100644 --- a/doc/api/url.markdown +++ b/doc/api/url.markdown @@ -69,9 +69,10 @@ The following methods are provided by the URL module: Take a URL string, and return an object. -Pass `true` as the second argument to also parse -the query string using the `querystring` module. -Defaults to `false`. +Pass `true` as the second argument to also parse the query string using the +`querystring` module. If `true` then the `query` property will always be +assigned an object, and the `search` property will always be a (possibly +empty) string. Defaults to `false`. Pass `true` as the third argument to treat `//foo/bar` as `{ host: 'foo', pathname: '/bar' }` rather than -- cgit v1.2.1