From f34a07d3a78fe34e6221c42721ae3f2f6a3d8cf0 Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Thu, 27 Apr 2023 13:14:39 +0530 Subject: stream: prevent pipeline hang with generator functions Fixes: https://github.com/nodejs/node/issues/47708 PR-URL: https://github.com/nodejs/node/pull/47712 Reviewed-By: Robert Nagy Reviewed-By: Antoine du Hamel Reviewed-By: Feng Yu --- lib/internal/streams/pipeline.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'lib') diff --git a/lib/internal/streams/pipeline.js b/lib/internal/streams/pipeline.js index 95737d95e4..062bdc192d 100644 --- a/lib/internal/streams/pipeline.js +++ b/lib/internal/streams/pipeline.js @@ -138,10 +138,9 @@ async function pumpToNode(iterable, writable, finish, { end }) { if (end) { writable.end(); + await wait(); } - await wait(); - finish(); } catch (err) { finish(error !== err ? aggregateTwoErrors(error, err) : err); -- cgit v1.2.1