From f14fa1bbca5022166037cbf2a3d7d884ff157120 Mon Sep 17 00:00:00 2001 From: legendecas Date: Tue, 20 Dec 2022 01:43:39 +0800 Subject: node-api: generalize finalizer second pass callback Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: https://github.com/nodejs/node/pull/44141 Refs: https://github.com/nodejs/node/issues/44071 Reviewed-By: Michael Dawson --- node.gyp | 1 - 1 file changed, 1 deletion(-) (limited to 'node.gyp') diff --git a/node.gyp b/node.gyp index 448cb8a8c7..4ef15c6248 100644 --- a/node.gyp +++ b/node.gyp @@ -1003,7 +1003,6 @@ 'test/cctest/test_base_object_ptr.cc', 'test/cctest/test_node_postmortem_metadata.cc', 'test/cctest/test_environment.cc', - 'test/cctest/test_js_native_api_v8.cc', 'test/cctest/test_linked_binding.cc', 'test/cctest/test_node_api.cc', 'test/cctest/test_per_process.cc', -- cgit v1.2.1