From 02dc307ae2f51903c39a6a51821b3aa6c864eb33 Mon Sep 17 00:00:00 2001 From: Joyee Cheung Date: Tue, 17 Apr 2018 00:23:20 +0800 Subject: src: throw ERR_MISSING_MODULE in module_wrap.cc PR-URL: https://github.com/nodejs/node/pull/20121 Reviewed-By: Daniel Bevenius Reviewed-By: Anna Henningsen Reviewed-By: Matteo Collina Reviewed-By: James M Snell Reviewed-By: Jeremiah Senkpiel --- src/module_wrap.cc | 3 +-- src/node_errors.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/module_wrap.cc b/src/module_wrap.cc index b735fd8e3b..48af2daa13 100644 --- a/src/module_wrap.cc +++ b/src/module_wrap.cc @@ -685,8 +685,7 @@ void ModuleWrap::Resolve(const FunctionCallbackInfo& args) { Maybe result = node::loader::Resolve(env, specifier_std, url); if (result.IsNothing() || (result.FromJust().flags() & URL_FLAGS_FAILED)) { std::string msg = "Cannot find module " + specifier_std; - env->ThrowError(msg.c_str()); - return; + return node::THROW_ERR_MISSING_MODULE(env, msg.c_str()); } args.GetReturnValue().Set(result.FromJust().ToObject(env)); diff --git a/src/node_errors.h b/src/node_errors.h index fadbdbe374..133fb3ab96 100644 --- a/src/node_errors.h +++ b/src/node_errors.h @@ -21,6 +21,7 @@ namespace node { V(ERR_INDEX_OUT_OF_RANGE, RangeError) \ V(ERR_INVALID_ARG_TYPE, TypeError) \ V(ERR_MEMORY_ALLOCATION_FAILED, Error) \ + V(ERR_MISSING_MODULE, Error) \ V(ERR_STRING_TOO_LONG, Error) \ V(ERR_BUFFER_TOO_LARGE, Error) -- cgit v1.2.1