From 6bbf2a57fcf33266c5859497f8cc32e1389a358a Mon Sep 17 00:00:00 2001 From: Feng Yu Date: Mon, 15 May 2023 02:24:15 -0700 Subject: vm: fix crash when setting __proto__ on context's globalThis PR-URL: https://github.com/nodejs/node/pull/47939 Reviewed-By: Zeyu "Alex" Yang Reviewed-By: James M Snell Reviewed-By: Darshan Sen Reviewed-By: Anna Henningsen --- src/node_contextify.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/node_contextify.cc b/src/node_contextify.cc index 7f9f71ba74..eb84d35985 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -530,7 +530,8 @@ void ContextifyContext::PropertySetterCallback( if (is_declared_on_sandbox && ctx->sandbox() ->GetOwnPropertyDescriptor(context, property) - .ToLocal(&desc)) { + .ToLocal(&desc) && + !desc->IsUndefined()) { Environment* env = Environment::GetCurrent(context); Local desc_obj = desc.As(); -- cgit v1.2.1