From 37db277bb4f7fe9a00e728b91f354b62b3c279ce Mon Sep 17 00:00:00 2001 From: Luigi Pinca Date: Tue, 27 Mar 2018 19:35:03 +0200 Subject: test: refactor test-net-dns-error - Use `common.mustCall()` and `common.mustNotCall()`. - Use ternary operator. PR-URL: https://github.com/nodejs/node/pull/19640 Reviewed-By: Richard Lau Reviewed-By: Rich Trott Reviewed-By: Trivikram Kamat Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- test/parallel/test-net-dns-error.js | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) (limited to 'test/parallel/test-net-dns-error.js') diff --git a/test/parallel/test-net-dns-error.js b/test/parallel/test-net-dns-error.js index a5ae415592..0d943bf6cd 100644 --- a/test/parallel/test-net-dns-error.js +++ b/test/parallel/test-net-dns-error.js @@ -21,27 +21,20 @@ 'use strict'; const common = require('../common'); -const assert = require('assert'); +const assert = require('assert'); const net = require('net'); const host = '*'.repeat(256); +const errCode = common.isOpenBSD ? 'EAI_FAIL' : 'ENOTFOUND'; -let errCode = 'ENOTFOUND'; -if (common.isOpenBSD) - errCode = 'EAI_FAIL'; - -function do_not_call() { - throw new Error('This function should not have been called.'); -} - -const socket = net.connect(42, host, do_not_call); +const socket = net.connect(42, host, common.mustNotCall()); socket.on('error', common.mustCall(function(err) { assert.strictEqual(err.code, errCode); })); -socket.on('lookup', function(err, ip, type) { +socket.on('lookup', common.mustCall(function(err, ip, type) { assert(err instanceof Error); assert.strictEqual(err.code, errCode); assert.strictEqual(ip, undefined); assert.strictEqual(type, undefined); -}); +})); -- cgit v1.2.1