From f2defcac4dd10f018215e3db530bed1314ce2225 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Mon, 26 Feb 2018 14:19:52 +0100 Subject: src: fix error message in async_hooks constructor There are two minor issues in the AsyncHook constructor, if the object passed in has an after and/or destroy property that are not functions the errors thrown will still be: TypeError [ERR_ASYNC_CALLBACK]: before must be a function This commit updates the code and adds a unit test. PR-URL: https://github.com/nodejs/node/pull/19000 Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Matheus Marchini Reviewed-By: Tiancheng "Timothy" Gu --- test/parallel/test-async-hooks-constructor.js | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 test/parallel/test-async-hooks-constructor.js (limited to 'test') diff --git a/test/parallel/test-async-hooks-constructor.js b/test/parallel/test-async-hooks-constructor.js new file mode 100644 index 0000000000..f2b4df6a9f --- /dev/null +++ b/test/parallel/test-async-hooks-constructor.js @@ -0,0 +1,23 @@ +'use strict'; + +// This tests that AsyncHooks throws an error if bad parameters are passed. + +const common = require('../common'); +const async_hooks = require('async_hooks'); +const non_function = 10; + +typeErrorForFunction('init'); +typeErrorForFunction('before'); +typeErrorForFunction('after'); +typeErrorForFunction('destroy'); +typeErrorForFunction('promiseResolve'); + +function typeErrorForFunction(functionName) { + common.expectsError(() => { + async_hooks.createHook({ [functionName]: non_function }); + }, { + code: 'ERR_ASYNC_CALLBACK', + type: TypeError, + message: `hook.${functionName} must be a function` + }); +} -- cgit v1.2.1