summaryrefslogtreecommitdiff
path: root/deps/npm/node_modules/request/CONTRIBUTING.md
blob: 17d383e8e3dd91744ed94ddb24fe2528af02b3a6 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
# This is an OPEN Open Source Project

-----------------------------------------

## What?

Individuals making significant and valuable contributions are given
commit-access to the project to contribute as they see fit. This project is
more like an open wiki than a standard guarded open source project.

## Rules

There are a few basic ground-rules for contributors:

1. **No `--force` pushes** or modifying the Git history in any way.
1. **Non-master branches** ought to be used for ongoing work.
1. **External API changes and significant modifications** ought to be subject
   to an **internal pull-request** to solicit feedback from other contributors.
1. Internal pull-requests to solicit feedback are *encouraged* for any other
   non-trivial contribution but left to the discretion of the contributor.
1. For significant changes wait a full 24 hours before merging so that active
   contributors who are distributed throughout the world have a chance to weigh
   in.
1. Contributors should attempt to adhere to the prevailing code-style.
1. Run `npm test` locally before submitting your PR, to catch any easy to miss
   style & testing issues.  To diagnose test failures, there are two ways to
   run a single test file:
     - `node_modules/.bin/taper tests/test-file.js` - run using the default
       [`taper`](/nylen/taper) test reporter.
     - `node tests/test-file.js` - view the raw
       [tap](https://testanything.org/) output.


## Releases

Declaring formal releases remains the prerogative of the project maintainer.

## Changes to this arrangement

This is an experiment and feedback is welcome! This document may also be
subject to pull-requests or changes by contributors where you believe you have
something valuable to add or change.

-----------------------------------------