diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-03-06 05:11:07 +0100 |
|---|---|---|
| committer | Timothy J Fontaine <tjfontaine@gmail.com> | 2014-03-23 16:11:08 -0700 |
| commit | 7989f42f866699b726f596add387fb19fa39bc55 (patch) | |
| tree | 89943c342665f924d5de4f1a1228fce93bc53be8 | |
| parent | 43a29f53ca11ab48e1d1ef6b2a0e673ae43a42a0 (diff) | |
| download | node-7989f42f866699b726f596add387fb19fa39bc55.tar.gz | |
build: fix g++ 4.8 build, disable -Werror
Turn off -Werror when building V8, it hits -Werror=unused-local-typedefs
with g++ 4.8. The warning itself is harmless so don't abort the build.
This was originally implemented in commit d2ab314e back in 2011 but the
build process has gone through a few iterations since then, that change
no longer works.
| -rw-r--r-- | common.gypi | 1 | ||||
| -rw-r--r-- | node.gyp | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/common.gypi b/common.gypi index 4193b5ab6..8adafe393 100644 --- a/common.gypi +++ b/common.gypi @@ -1,5 +1,6 @@ { 'variables': { + 'werror': '', # Turn off -Werror in V8 build. 'visibility%': 'hidden', # V8's visibility setting 'target_arch%': 'ia32', # set v8's target architecture 'host_arch%': 'ia32', # set v8's host architecture @@ -1,9 +1,6 @@ { 'variables': { 'v8_use_snapshot%': 'true', - # Turn off -Werror in V8 - # See http://codereview.chromium.org/8159015 - 'werror': '', 'node_use_dtrace%': 'false', 'node_use_etw%': 'false', 'node_use_perfctr%': 'false', |