summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFedor Indutny <fedor@indutny.com>2014-07-17 09:55:07 +0400
committerFedor Indutny <fedor@indutny.com>2014-07-17 15:16:29 +0400
commit1d3d8c0e5545b1f253dbe4c3525eeb2f1312b689 (patch)
treed2854731cb48246d149ec7bab4807846d6297d7f
parent9d9fc3fa3063c9117119c56e69679269250c1213 (diff)
downloadnode-1d3d8c0e5545b1f253dbe4c3525eeb2f1312b689.tar.gz
gyp: do not let `v8dbg_` slip away on osx
Pass `-force_load` to linker when linking to `libv8_base` to preserve `v8dbg_` symbols, which are useful for debugging.
-rw-r--r--common.gypi2
-rw-r--r--node.gyp8
2 files changed, 9 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi
index c05b793e9..542214218 100644
--- a/common.gypi
+++ b/common.gypi
@@ -21,7 +21,7 @@
['OS != "win"', {
'v8_postmortem_support': 'true'
}],
- ['GENERATOR == "ninja"', {
+ ['GENERATOR == "ninja" or OS== "mac"', {
'OBJ_DIR': '<(PRODUCT_DIR)/obj',
'V8_BASE': '<(PRODUCT_DIR)/libv8_base.a',
}, {
diff --git a/node.gyp b/node.gyp
index f6586c4d4..38311a1cc 100644
--- a/node.gyp
+++ b/node.gyp
@@ -271,6 +271,14 @@
'PLATFORM="darwin"',
],
}],
+ [ 'OS=="mac" and v8_postmortem_support=="true"', {
+ # Do not let `v8dbg_` symbols slip away
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [
+ '-Wl,-force_load,<(V8_BASE)',
+ ],
+ },
+ }],
[ 'OS=="freebsd"', {
'libraries': [
'-lutil',