summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoel Martin <github@martintribe.org>2011-07-07 11:47:11 -0500
committerJoel Martin <github@martintribe.org>2011-07-07 11:47:11 -0500
commit123e5e74452842ec216612bfbfd27aedc0e04e41 (patch)
treeeec4108fcb7ff149f7a748751d9cca92972a20ab
parenta4ff1f573d0cc7cecd3438f380adcb0a60efd8f6 (diff)
downloadnovnc-123e5e74452842ec216612bfbfd27aedc0e04e41.tar.gz
Pull IPv6 support from websockify.
Pull from websockify 247b74950d.
-rwxr-xr-xutils/websocket.py32
-rwxr-xr-xutils/websockify18
2 files changed, 32 insertions, 18 deletions
diff --git a/utils/websocket.py b/utils/websocket.py
index 9895707..90346a5 100755
--- a/utils/websocket.py
+++ b/utils/websocket.py
@@ -87,17 +87,17 @@ Sec-WebSocket-Accept: %s\r
class EClose(Exception):
pass
- def __init__(self, listen_host='', listen_port=None,
+ def __init__(self, listen_host='', listen_port=None, source_is_ipv6=False,
verbose=False, cert='', key='', ssl_only=None,
daemon=False, record='', web=''):
# settings
- self.verbose = verbose
- self.listen_host = listen_host
- self.listen_port = listen_port
- self.ssl_only = ssl_only
- self.daemon = daemon
- self.handler_id = 1
+ self.verbose = verbose
+ self.listen_host = listen_host
+ self.listen_port = listen_port
+ self.ssl_only = ssl_only
+ self.daemon = daemon
+ self.handler_id = 1
# Make paths settings absolute
self.cert = os.path.abspath(cert)
@@ -113,7 +113,7 @@ Sec-WebSocket-Accept: %s\r
os.chdir(self.web)
# Sanity checks
- if ssl and self.ssl_only:
+ if not ssl and self.ssl_only:
raise Exception("No 'ssl' module and SSL-only specified")
if self.daemon and not resource:
raise Exception("Module 'resource' required to daemonize")
@@ -142,6 +142,17 @@ Sec-WebSocket-Accept: %s\r
#
# WebSocketServer static methods
#
+
+ @staticmethod
+ def addrinfo(host, port=None):
+ """ Resolve a host (and optional port) to an IPv4 or IPv6 address.
+ Returns: family, socktype, proto, canonname, sockaddr
+ """
+ addrs = socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM, socket.IPPROTO_TCP)
+ if not addrs:
+ raise Exception("Could resolve host '%s'" % self.target_host)
+ return addrs[0]
+
@staticmethod
def daemonize(keepfd=None, chdir='/'):
os.umask(0)
@@ -534,6 +545,7 @@ Sec-WebSocket-Accept: %s\r
if not os.path.exists(self.cert):
raise self.EClose("SSL connection but '%s' not found"
% self.cert)
+ retsock = None
try:
retsock = ssl.wrap_socket(
sock,
@@ -724,8 +736,8 @@ Sec-WebSocket-Accept: %s\r
is a WebSockets client then call new_client() method (which must
be overridden) for each new client connection.
"""
-
- lsock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+ addr = self.addrinfo(self.listen_host, self.listen_port)
+ lsock = socket.socket(addr[0], addr[1])
lsock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
lsock.bind((self.listen_host, self.listen_port))
lsock.listen(100)
diff --git a/utils/websockify b/utils/websockify
index 9aaf0dd..8ee48cb 100755
--- a/utils/websockify
+++ b/utils/websockify
@@ -39,10 +39,10 @@ Traffic Legend:
def __init__(self, *args, **kwargs):
# Save off proxy specific options
- self.target_host = kwargs.pop('target_host')
- self.target_port = kwargs.pop('target_port')
- self.wrap_cmd = kwargs.pop('wrap_cmd')
- self.wrap_mode = kwargs.pop('wrap_mode')
+ self.target_host = kwargs.pop('target_host')
+ self.target_port = kwargs.pop('target_port')
+ self.wrap_cmd = kwargs.pop('wrap_cmd')
+ self.wrap_mode = kwargs.pop('wrap_mode')
# Last 3 timestamps command was run
self.wrap_times = [0, 0, 0]
@@ -141,7 +141,8 @@ Traffic Legend:
# Connect to the target
self.msg("connecting to: %s:%s" % (
self.target_host, self.target_port))
- tsock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
+ addr = self.addrinfo(self.target_host, self.target_port)
+ tsock = socket.socket(addr[0], addr[1])
tsock.connect((self.target_host, self.target_port))
if self.verbose and not self.daemon:
@@ -255,18 +256,19 @@ if __name__ == '__main__':
# Parse host:port and convert ports to numbers
if args[0].count(':') > 0:
- opts.listen_host, opts.listen_port = args[0].split(':')
+ opts.listen_host, sep, opts.listen_port = args[0].rpartition(':')
else:
opts.listen_host, opts.listen_port = '', args[0]
+
try: opts.listen_port = int(opts.listen_port)
except: parser.error("Error parsing listen port")
-
+
if opts.wrap_cmd:
opts.target_host = None
opts.target_port = None
else:
if args[1].count(':') > 0:
- opts.target_host, opts.target_port = args[1].split(':')
+ opts.target_host, sep, opts.target_port = args[1].rpartition(':')
else:
parser.error("Error parsing target")
try: opts.target_port = int(opts.target_port)