diff options
author | Chris J <chrisjdev@users.noreply.github.com> | 2019-11-07 15:15:15 -0500 |
---|---|---|
committer | Samuel Mannehed <samuel@cendio.se> | 2019-12-05 12:13:11 +0100 |
commit | 01d4514deed5e61d849c6f720b6f165a88f2e106 (patch) | |
tree | e2518b573bf6516cdd13545e4f9666268b9eee39 | |
parent | c15502525e12f18d613aaaa972ffa75b77bc9362 (diff) | |
download | novnc-01d4514deed5e61d849c6f720b6f165a88f2e106.tar.gz |
Allow connecting with empty string credentials
Checking for undefined instead of falsy. That way an empty strings are allowed.
-rw-r--r-- | core/rfb.js | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/core/rfb.js b/core/rfb.js index dfcab7c..9ef369d 100644 --- a/core/rfb.js +++ b/core/rfb.js @@ -940,9 +940,9 @@ export default class RFB extends EventTargetMixin { // authentication _negotiate_xvp_auth() { - if (!this._rfb_credentials.username || - !this._rfb_credentials.password || - !this._rfb_credentials.target) { + if (this._rfb_credentials.username === undefined || + this._rfb_credentials.password === undefined || + this._rfb_credentials.target === undefined) { this.dispatchEvent(new CustomEvent( "credentialsrequired", { detail: { types: ["username", "password", "target"] } })); @@ -961,7 +961,7 @@ export default class RFB extends EventTargetMixin { _negotiate_std_vnc_auth() { if (this._sock.rQwait("auth challenge", 16)) { return false; } - if (!this._rfb_credentials.password) { + if (this._rfb_credentials.password === undefined) { this.dispatchEvent(new CustomEvent( "credentialsrequired", { detail: { types: ["password"] } })); |